Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87129/?format=api
{ "id": 87129, "url": "https://patches.dpdk.org/api/patches/87129/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-19-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122191925.24308-19-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122191925.24308-19-lironh@marvell.com", "date": "2021-01-22T19:19:06", "name": "[v2,18/37] net/mvpp2: use generic name for the 'cfg'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7204505378964275c99a47b2430d3bffe498a4b4", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-19-lironh@marvell.com/mbox/", "series": [ { "id": 14911, "url": "https://patches.dpdk.org/api/series/14911/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14911", "date": "2021-01-22T19:18:48", "name": "net/mvpp2: misc updates", "version": 2, "mbox": "https://patches.dpdk.org/series/14911/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87129/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAEAFA0A0A;\n\tFri, 22 Jan 2021 20:22:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EDEE714110C;\n\tFri, 22 Jan 2021 20:20:26 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 2F26D141102\n for <dev@dpdk.org>; Fri, 22 Jan 2021 20:20:24 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10MJBQvb008774 for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:23 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3668p32v9q-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:23 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 11:20:21 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 22 Jan 2021 11:20:20 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=gYlApLpa7PJI2W/fSeEEPQTib2RW04o6oXi1Jg0FhU0=;\n b=E+X2+/U3R1S3q9Tm8a4NYA9CnEIz6ETKmJ7B/BlWvZMMrbFbYkcv6w6dCrdNxkT8qJfA\n XgvizWNSQFv1Pc3o7V+fwtrao78xZ5cc0T3CKmju+26/u9UqUHeFvCfsDaqDFNAbf4Ul\n M5cWqYeIY5DBaNU3dvQE6TB+7H8HGV/Nu2z9oTXZQ8ICmMNKQUQEh+AJpbAnNIaRtGzE\n muXil4z6OAONHgKd9ZKf/oyfhT7XmoLz8ALy5SAh8GzQbSwjhA18jT5NHLeGm0mliL1i\n ZrdxovmuIgk6vMIu+z60EbCScOboCQusegc6R60+plRFvC5etUahyMxf38dBgvg34f4N 0w==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Liron Himi <lironh@marvell.com>", "Date": "Fri, 22 Jan 2021 21:19:06 +0200", "Message-ID": "<20210122191925.24308-19-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210122191925.24308-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>\n <20210122191925.24308-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-22_14:2021-01-22,\n 2021-01-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 18/37] net/mvpp2: use generic name for the\n 'cfg'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nAs the config file is not just for 'qos'\nit is more accurate to replace the name from 'qos_cfg'\nto 'cfg'\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 12 ++++++------\n drivers/net/mvpp2/mrvl_qos.c | 31 +++++++++++++++----------------\n drivers/net/mvpp2/mrvl_qos.h | 13 ++++++-------\n 3 files changed, 27 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 635403d39..368446020 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -698,9 +698,9 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t\t priv->pp_id, priv->ppio_id);\n \tpriv->ppio_params.match = match;\n \tpriv->ppio_params.eth_start_hdr = PP2_PPIO_HDR_ETH;\n-\tif (mrvl_qos_cfg)\n+\tif (mrvl_cfg)\n \t\tpriv->ppio_params.eth_start_hdr =\n-\t\t\tmrvl_qos_cfg->port[dev->data->port_id].eth_start_hdr;\n+\t\t\tmrvl_cfg->port[dev->data->port_id].eth_start_hdr;\n \n \t/*\n \t * Calculate the minimum bpool size for refill feature as follows:\n@@ -784,8 +784,8 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t}\n \n \t/* For default QoS config, don't start classifier. */\n-\tif (mrvl_qos_cfg &&\n-\t mrvl_qos_cfg->port[dev->data->port_id].use_global_defaults == 0) {\n+\tif (mrvl_cfg &&\n+\t mrvl_cfg->port[dev->data->port_id].use_global_defaults == 0) {\n \t\tret = mrvl_start_qos_mapping(priv);\n \t\tif (ret) {\n \t\t\tMRVL_LOG(ERR, \"Failed to setup QoS mapping\");\n@@ -3210,7 +3210,7 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)\n \t * The below system initialization should be done only once,\n \t * on the first provided configuration file\n \t */\n-\tif (!mrvl_qos_cfg) {\n+\tif (!mrvl_cfg) {\n \t\tcfgnum = rte_kvargs_count(kvlist, MRVL_CFG_ARG);\n \t\tMRVL_LOG(INFO, \"Parsing config file!\");\n \t\tif (cfgnum > 1) {\n@@ -3218,7 +3218,7 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)\n \t\t\tgoto out_free_kvlist;\n \t\t} else if (cfgnum == 1) {\n \t\t\trte_kvargs_process(kvlist, MRVL_CFG_ARG,\n-\t\t\t\t\t mrvl_get_qoscfg, &mrvl_qos_cfg);\n+\t\t\t\t\t mrvl_get_cfg, &mrvl_cfg);\n \t\t}\n \t}\n \ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex 976cb06a8..18cf470dd 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -71,8 +71,8 @@\n /** Maximum possible value of DSCP. */\n #define MAX_DSCP 63\n \n-/** Global QoS configuration. */\n-struct mrvl_qos_cfg *mrvl_qos_cfg;\n+/** Global configuration. */\n+struct mrvl_cfg *mrvl_cfg;\n \n /**\n * Convert string to uint32_t with extra checks for result correctness.\n@@ -104,12 +104,12 @@ get_val_securely(const char *string, uint32_t *val)\n * @param file Path to the configuration file.\n * @param port Port number.\n * @param outq Out queue number.\n- * @param cfg Pointer to the Marvell QoS configuration structure.\n+ * @param cfg Pointer to the Marvell configuration structure.\n * @returns 0 in case of success, negative value otherwise.\n */\n static int\n get_outq_cfg(struct rte_cfgfile *file, int port, int outq,\n-\t\tstruct mrvl_qos_cfg *cfg)\n+\t\tstruct mrvl_cfg *cfg)\n {\n \tchar sec_name[32];\n \tconst char *entry;\n@@ -315,7 +315,7 @@ get_entry_values(const char *entry, uint8_t *tab,\n */\n static int\n parse_tc_cfg(struct rte_cfgfile *file, int port, int tc,\n-\t\tstruct mrvl_qos_cfg *cfg)\n+\t\tstruct mrvl_cfg *cfg)\n {\n \tchar sec_name[32];\n \tconst char *entry;\n@@ -409,7 +409,7 @@ parse_tc_cfg(struct rte_cfgfile *file, int port, int tc,\n */\n static int\n parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n-\t\tstruct mrvl_qos_cfg *cfg)\n+\t\tstruct mrvl_cfg *cfg)\n {\n \tconst char *entry;\n \tuint32_t val;\n@@ -478,7 +478,7 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n }\n \n /**\n- * Parse QoS configuration - rte_kvargs_process handler.\n+ * Parse configuration - rte_kvargs_process handler.\n *\n * Opens configuration file and parses its content.\n *\n@@ -488,10 +488,9 @@ parse_policer(struct rte_cfgfile *file, int port, const char *sec_name,\n * @returns 0 in case of success, exits otherwise.\n */\n int\n-mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n-\t\tvoid *extra_args)\n+mrvl_get_cfg(const char *key __rte_unused, const char *path, void *extra_args)\n {\n-\tstruct mrvl_qos_cfg **cfg = extra_args;\n+\tstruct mrvl_cfg **cfg = extra_args;\n \tstruct rte_cfgfile *file = rte_cfgfile_load(path, 0);\n \tuint32_t val;\n \tint n, i, ret;\n@@ -506,7 +505,7 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n \t/* Create configuration. This is never accessed on the fast path,\n \t * so we can ignore socket.\n \t */\n-\t*cfg = rte_zmalloc(\"mrvl_qos_cfg\", sizeof(struct mrvl_qos_cfg), 0);\n+\t*cfg = rte_zmalloc(\"mrvl_cfg\", sizeof(struct mrvl_cfg), 0);\n \tif (*cfg == NULL) {\n \t\tMRVL_LOG(ERR, \"Cannot allocate configuration %s\\n\", path);\n \t\treturn -1;\n@@ -764,8 +763,8 @@ mrvl_configure_rxqs(struct mrvl_priv *priv, uint16_t portid,\n {\n \tsize_t i, tc;\n \n-\tif (mrvl_qos_cfg == NULL ||\n-\t\tmrvl_qos_cfg->port[portid].use_global_defaults) {\n+\tif (mrvl_cfg == NULL ||\n+\t\tmrvl_cfg->port[portid].use_global_defaults) {\n \t\t/*\n \t\t * No port configuration, use default: 1 TC, no QoS,\n \t\t * TC color set to green.\n@@ -783,7 +782,7 @@ mrvl_configure_rxqs(struct mrvl_priv *priv, uint16_t portid,\n \t}\n \n \t/* We need only a subset of configuration. */\n-\tstruct port_cfg *port_cfg = &mrvl_qos_cfg->port[portid];\n+\tstruct port_cfg *port_cfg = &mrvl_cfg->port[portid];\n \n \tpriv->qos_tbl_params.type = port_cfg->mapping_priority;\n \n@@ -896,10 +895,10 @@ mrvl_configure_txqs(struct mrvl_priv *priv, uint16_t portid,\n \t\tuint16_t max_queues)\n {\n \t/* We need only a subset of configuration. */\n-\tstruct port_cfg *port_cfg = &mrvl_qos_cfg->port[portid];\n+\tstruct port_cfg *port_cfg = &mrvl_cfg->port[portid];\n \tint i;\n \n-\tif (mrvl_qos_cfg == NULL)\n+\tif (mrvl_cfg == NULL)\n \t\treturn 0;\n \n \tpriv->ppio_params.rate_limit_enable = port_cfg->rate_limit_enable;\ndiff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h\nindex 0934752cf..928cfe366 100644\n--- a/drivers/net/mvpp2/mrvl_qos.h\n+++ b/drivers/net/mvpp2/mrvl_qos.h\n@@ -17,8 +17,8 @@\n /** Value used as \"unknown\". */\n #define MRVL_UNKNOWN_TC (0xFF)\n \n-/* QoS config. */\n-struct mrvl_qos_cfg {\n+/* config. */\n+struct mrvl_cfg {\n \tstruct port_cfg {\n \t\tenum pp2_ppio_eth_start_hdr eth_start_hdr;\n \t\tint rate_limit_enable;\n@@ -48,11 +48,11 @@ struct mrvl_qos_cfg {\n \t} port[RTE_MAX_ETHPORTS];\n };\n \n-/** Global QoS configuration. */\n-extern struct mrvl_qos_cfg *mrvl_qos_cfg;\n+/** Global configuration. */\n+extern struct mrvl_cfg *mrvl_cfg;\n \n /**\n- * Parse QoS configuration - rte_kvargs_process handler.\n+ * Parse configuration - rte_kvargs_process handler.\n *\n * Opens configuration file and parses its content.\n *\n@@ -62,8 +62,7 @@ extern struct mrvl_qos_cfg *mrvl_qos_cfg;\n * @returns 0 in case of success, exits otherwise.\n */\n int\n-mrvl_get_qoscfg(const char *key __rte_unused, const char *path,\n-\t\tvoid *extra_args);\n+mrvl_get_cfg(const char *key __rte_unused, const char *path, void *extra_args);\n \n /**\n * Configure RX Queues in a given port.\n", "prefixes": [ "v2", "18/37" ] }