Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85695/?format=api
{ "id": 85695, "url": "https://patches.dpdk.org/api/patches/85695/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201224035748.67012-1-dapengx.yu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201224035748.67012-1-dapengx.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201224035748.67012-1-dapengx.yu@intel.com", "date": "2020-12-24T03:57:48", "name": "app/testpmd: avoid exit without resource release", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5b13a7143596fe439ed17faf1861005fbd577dd7", "submitter": { "id": 2042, "url": "https://patches.dpdk.org/api/people/2042/?format=api", "name": "Yu, DapengX", "email": "dapengx.yu@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201224035748.67012-1-dapengx.yu@intel.com/mbox/", "series": [ { "id": 14447, "url": "https://patches.dpdk.org/api/series/14447/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14447", "date": "2020-12-24T03:57:48", "name": "app/testpmd: avoid exit without resource release", "version": 1, "mbox": "https://patches.dpdk.org/series/14447/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85695/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB27AA09FF;\n\tThu, 24 Dec 2020 04:58:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD4AEC9C2;\n\tThu, 24 Dec 2020 04:58:05 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 2E78CC9C0;\n Thu, 24 Dec 2020 04:58:02 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Dec 2020 19:58:00 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.93])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Dec 2020 19:57:58 -0800" ], "IronPort-SDR": [ "\n FSFozEcsl2Rvqh0crvHgP0VCYrc4JkDobv57B+jYvWGq6g4qdypgHujgVhnTiKrUd/QqUiIzlD\n ueDgtUpqkp0A==", "\n eO1/I6jUiPnNnUS6g1SqCgc6XcZehcZbJ8SI/MJkeCy4+dREsq8Outps84bjYU67CaEPrmw94F\n 4TxQhp/HqvWw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9844\"; a=\"237663675\"", "E=Sophos;i=\"5.78,444,1599548400\"; d=\"scan'208\";a=\"237663675\"", "E=Sophos;i=\"5.78,444,1599548400\"; d=\"scan'208\";a=\"374230856\"" ], "From": "dapengx.yu@intel.com", "To": "wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com", "Cc": "dev@dpdk.org,\n\tYU DAPENG <dapengx.yu@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 24 Dec 2020 11:57:48 +0800", "Message-Id": "<20201224035748.67012-1-dapengx.yu@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: YU DAPENG <dapengx.yu@intel.com>\n\nIn interactive mode, if testpmd exit by calling rte_exit without cmdline\nresource release, terminal will not echo keyboard input. So add code to\njust show error message, but not exit testpmd when unexpected happens\non starting packet forwarding in interactive mode. User can type \"quit\"\nto exit testpmd later.\n\nFixes: 5a8fb55c48ab (\"app/testpmd: support unidirectional configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: YU DAPENG <dapengx.yu@intel.com>\n---\n app/test-pmd/testpmd.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 33fc0fddf..0071c7235 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2194,10 +2194,18 @@ start_packet_forwarding(int with_tx_first)\n \n \tif ((strcmp(cur_fwd_eng->fwd_mode_name, \"rxonly\") != 0 &&\n \t\tstrcmp(cur_fwd_eng->fwd_mode_name, \"txonly\") != 0) &&\n-\t\t(!nb_rxq || !nb_txq))\n+\t\t(!nb_rxq || !nb_txq)) {\n+#ifdef RTE_LIB_CMDLINE\n+\t\tif (interactive == 1) {\n+\t\t\tprintf(\"Either rxq or txq are 0, cannot use %s fwd mode\\n\",\n+\t\t\t\tcur_fwd_eng->fwd_mode_name);\n+\t\t\treturn;\n+\t\t}\n+#endif\n \t\trte_exit(EXIT_FAILURE,\n \t\t\t\"Either rxq or txq are 0, cannot use %s fwd mode\\n\",\n \t\t\tcur_fwd_eng->fwd_mode_name);\n+\t}\n \n \tif (all_ports_started() == 0) {\n \t\tprintf(\"Not all ports were started\\n\");\n", "prefixes": [] }