Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84834/?format=api
{ "id": 84834, "url": "https://patches.dpdk.org/api/patches/84834/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-15-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201208201134.47844-15-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201208201134.47844-15-ajit.khaparde@broadcom.com", "date": "2020-12-08T20:11:31", "name": "[14/17] net/bnxt: fix PF resource query", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b9afbf052a815d556c179bc18b059be9df33b66", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-15-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14211, "url": "https://patches.dpdk.org/api/series/14211/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14211", "date": "2020-12-08T20:11:17", "name": "fixes and refactoring changes for bnxt", "version": 1, "mbox": "https://patches.dpdk.org/series/14211/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84834/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D12A7A09E9;\n\tTue, 8 Dec 2020 21:16:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CDB8DC9D2;\n\tTue, 8 Dec 2020 21:12:07 +0100 (CET)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 91CB3CA06\n for <dev@dpdk.org>; Tue, 8 Dec 2020 21:12:00 +0100 (CET)", "by mail-pl1-f195.google.com with SMTP id u4so1871591plr.12\n for <dev@dpdk.org>; Tue, 08 Dec 2020 12:12:00 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.56\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 08 Dec 2020 12:11:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=SLh6EC7m7xgJ8GgF/4EYQn9rt9YCo3QR3oMiURAC5r4=;\n b=W+sF1ytUpU42vvtYysM9aJzcE5oCeLWRxtMd9q2weRlyiHntYvaS/7sCAZd2v7WPXQ\n GfE4yyv8azjP5K5JUvTQAOWmKPV1yQcO4KRp3NXtNNS0E2Z4vxFX5nl6lOmQF3T47ond\n l0b7xSGulxfHb/V5/+SZL/R9Y4tnFCiNVu51s=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=SLh6EC7m7xgJ8GgF/4EYQn9rt9YCo3QR3oMiURAC5r4=;\n b=Olqwi2c7k7t1wXj5OeN5iJC3yzOjfu05DmXA72IOu0zDqTeicicdPynGgZ8knZ7kxP\n F7YVrOt0Xj/JQAeFK9Pny2yzs+Y5wj7k6P4okWTw4fLFft+EANpeoq1K6xO8Q+i4pMQk\n r4gRnyrJ4rTdYxYnFPjVgC+DJIyvBLQoZW7NV4OZIh8MnOfDPEbvJY0ipH++gB+Gwfhu\n FVbFkJfLu/Q0mf3cf1mGCHhCPWYWyjsbGvRXLL6yksUAdVAN6O/XSxTSeG7bUzhebWEG\n f5Dy728YMHK+L35qEv6Q1bN6pd1S3Ri427gKTIzelEvFXfhZgg19b6HFqdsr5ACI8GEl\n QTgg==", "X-Gm-Message-State": "AOAM530x4yBAiZ/7GzPVuUaI1iagqx7mw7bTM/LacEmR8+goWH+ogHZ7\n W+sxFa3IdKDEMWS/5LivV8LHqde2KuS2zSXZzp4xWBGX8Gi3M3fXwoat8OXAvTfD+66uqnuC18v\n rbSpgnVRHROePNIVk7h76/BllAYRkufkO8Wun1/nBnXmz/zZoIRtRJIVtA2XjjRsy4A==", "X-Google-Smtp-Source": "\n ABdhPJxa2geOLFB488axy96Tnm4hWsYKXbaVF2fM36zruW5ovpR7J9r438PWwOlWRVwWm2FO61TC3Q==", "X-Received": "by 2002:a17:902:b08a:b029:d9:eca:7d38 with SMTP id\n p10-20020a170902b08ab02900d90eca7d38mr22670627plr.72.1607458318329;\n Tue, 08 Dec 2020 12:11:58 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>, stable@dpdk.org,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Tue, 8 Dec 2020 12:11:31 -0800", "Message-Id": "<20201208201134.47844-15-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "References": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 14/17] net/bnxt: fix PF resource query", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nThis cmd should be called by every driver after 'hwrm_func_cfg'\nto get the actual number of resources allocated by the HWRM.\nThe values returned in the cmd are the max values for that PF.\n\nAlso, now that the max values for the PF are computed in probe itself,\nno need to invoke FUNC_QCAPs or any other cmd in dev_configure_op()\nas that would just override the actual max values obtained above.\n\nFixes: f8168ca0e690 (\"net/bnxt: support thor controller\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 7 -------\n drivers/net/bnxt/bnxt_hwrm.c | 36 +++++++++++++++++++++++++++++++++-\n 2 files changed, 35 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex bf8963577..21d9e26ca 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1071,13 +1071,6 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)\n \t\t}\n \n \t\tpthread_mutex_unlock(&bp->def_cp_lock);\n-\t} else {\n-\t\t/* legacy driver needs to get updated values */\n-\t\trc = bnxt_hwrm_func_qcaps(bp);\n-\t\tif (rc) {\n-\t\t\tPMD_DRV_LOG(ERR, \"hwrm func qcaps fail:%d\\n\", rc);\n-\t\t\treturn rc;\n-\t\t}\n \t}\n \n \t/* Inherit new configurations */\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex cee2656c1..a3eb133c0 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -3456,6 +3456,35 @@ static int bnxt_update_max_resources(struct bnxt *bp,\n \treturn 0;\n }\n \n+/* Update the PF resource values based on how many resources\n+ * got allocated to it.\n+ */\n+static int bnxt_update_max_resources_pf_only(struct bnxt *bp)\n+{\n+\tstruct hwrm_func_qcfg_input req = {0};\n+\tstruct hwrm_func_qcfg_output *resp = bp->hwrm_cmd_resp_addr;\n+\tint rc;\n+\n+\t/* Get the actual allocated values now */\n+\tHWRM_PREP(&req, HWRM_FUNC_QCFG, BNXT_USE_CHIMP_MB);\n+\treq.fid = rte_cpu_to_le_16(0xffff);\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\tHWRM_CHECK_RESULT();\n+\n+\tbp->max_rsscos_ctx = rte_le_to_cpu_16(resp->alloc_rsscos_ctx);\n+\tbp->max_stat_ctx = rte_le_to_cpu_16(resp->alloc_stat_ctx);\n+\tbp->max_cp_rings = rte_le_to_cpu_16(resp->alloc_cmpl_rings);\n+\tbp->max_tx_rings = rte_le_to_cpu_16(resp->alloc_tx_rings);\n+\tbp->max_rx_rings = rte_le_to_cpu_16(resp->alloc_rx_rings);\n+\tbp->max_l2_ctx = rte_le_to_cpu_16(resp->alloc_l2_ctx);\n+\tbp->max_ring_grps = rte_le_to_cpu_16(resp->alloc_hw_ring_grps);\n+\tbp->max_vnics = rte_le_to_cpu_16(resp->alloc_vnics);\n+\n+\tHWRM_UNLOCK();\n+\n+\treturn 0;\n+}\n+\n int bnxt_hwrm_func_qcfg_current_vf_vlan(struct bnxt *bp, int vf)\n {\n \tstruct hwrm_func_qcfg_input req = {0};\n@@ -3555,8 +3584,13 @@ int bnxt_hwrm_allocate_pf_only(struct bnxt *bp)\n \t\t HWRM_FUNC_CFG_INPUT_FLAGS_STD_TX_RING_MODE_DISABLE);\n \tbp->pf->func_cfg_flags |=\n \t\tHWRM_FUNC_CFG_INPUT_FLAGS_STD_TX_RING_MODE_DISABLE;\n+\n \trc = bnxt_hwrm_pf_func_cfg(bp, &pf_resc);\n-\trc = __bnxt_hwrm_func_qcaps(bp);\n+\tif (rc)\n+\t\treturn rc;\n+\n+\trc = bnxt_update_max_resources_pf_only(bp);\n+\n \treturn rc;\n }\n \n", "prefixes": [ "14/17" ] }