Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84762/?format=api
{ "id": 84762, "url": "https://patches.dpdk.org/api/patches/84762/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-6-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201204201646.51746-6-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201204201646.51746-6-aboyer@pensando.io", "date": "2020-12-04T20:16:42", "name": "[v3,5/9] net/ionic: remove some unused fields", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5704fe16e87c834ca4f00c42d5747621568568f8", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-6-aboyer@pensando.io/mbox/", "series": [ { "id": 14190, "url": "https://patches.dpdk.org/api/series/14190/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14190", "date": "2020-12-04T20:16:37", "name": "net/ionic: minor updates and documentation", "version": 3, "mbox": "https://patches.dpdk.org/series/14190/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84762/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35C4AA09E3;\n\tFri, 4 Dec 2020 21:19:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1399CC9E7;\n\tFri, 4 Dec 2020 21:17:47 +0100 (CET)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id E5318C9E6\n for <dev@dpdk.org>; Fri, 4 Dec 2020 21:17:44 +0100 (CET)", "by mail-pf1-f194.google.com with SMTP id i3so947164pfd.6\n for <dev@dpdk.org>; Fri, 04 Dec 2020 12:17:44 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id z20sm2911805pjq.16.2020.12.04.12.17.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 04 Dec 2020 12:17:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=+UN3D+R0myJIne4WHo0dq814V/OBAhKajB/2vJYztX4=;\n b=H78U5shkyKjCEQsoSoJaqBjZgLzg/PTv/1d+IaljAdZJNYau0zg/AzPg1eM1+OIR45\n JPmsPecNyPB/PQb0BpThZs4QfU7xjYg4lXwZEmYKX7kUokT8lmtWK/ikhRJv/xB4vgFN\n AHcTw7fVwUwMAIwBVYUyk69qGcQlu/TwC88Fexek124DJx0bEVdOXE9FbYwqxRa5GqT+\n 0HFk3GmHpKIFKt4QM2Ui9HUmq40GxunurWGQLPxBKVfctMghjikzjiPasBPB3oi/Yayk\n SYuFleEtaw9pGnO8SND3+iqQ8WKYDkc/wSgAg6D1HVEiqMlUjukxCzTFFzkNsKkdMo5K\n ojag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=+UN3D+R0myJIne4WHo0dq814V/OBAhKajB/2vJYztX4=;\n b=qDkmnnLWftg53zJEWL1cxywaMyTP6gJqWF4kI0DrbP+MnYK72wQGIXa+04KPv/zjhc\n BtiIkWOr14X2hEOINEYmY85yCshrrz6euYqWh9EtyOgZWxp4Y5o2JSYi43PnwI/D5S7H\n 8nTPgf/OSzc6f1lnc4PgfLaBj+aFO8LgO3xB5RaWyeFfsBFFN7H5lyJCB1z6hvRNl7Oz\n LaZLWeMIi8xHAO2s0atLw9l0/I9Ir8egH9yOH562bECR9bxciiI8YsuJ/WpeNbWbnjH1\n WTzD58e9FFBpXu4CZ05Xt/Wq2eyN8DPyFXDelzawjEOT6dhdB3DONaa9K7GVQKqDtfOO\n KvHA==", "X-Gm-Message-State": "AOAM533f144MG6xT9hZIKE8Am24wnNFrulUx8xGHYwHMcO2vLB5gF3pj\n KLJa9jftd4beYuF3yD97kMJrroyAL8zLkQ==", "X-Google-Smtp-Source": "\n ABdhPJxPN7CxXqiVigLLtcDIpPdb+6c8I1Givl4o4i44H9+yooMks9iG1ZDOwa2kJFfQSQJR7JUJKw==", "X-Received": "by 2002:a63:f915:: with SMTP id h21mr8842372pgi.389.1607113062771;\n Fri, 04 Dec 2020 12:17:42 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Fri, 4 Dec 2020 12:16:42 -0800", "Message-Id": "<20201204201646.51746-6-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "References": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v3 5/9] net/ionic: remove some unused fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This conserves resources.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic.h | 1 -\n drivers/net/ionic/ionic_dev.c | 5 +----\n drivers/net/ionic/ionic_dev.h | 7 +------\n drivers/net/ionic/ionic_ethdev.c | 2 --\n drivers/net/ionic/ionic_lif.c | 22 ++++++----------------\n drivers/net/ionic/ionic_lif.h | 2 --\n drivers/net/ionic/ionic_regs.h | 6 ------\n 7 files changed, 8 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic.h b/drivers/net/ionic/ionic.h\nindex 1538df309..a93110326 100644\n--- a/drivers/net/ionic/ionic.h\n+++ b/drivers/net/ionic/ionic.h\n@@ -59,7 +59,6 @@ struct ionic_adapter {\n \tuint32_t link_speed;\n \tuint32_t nintrs;\n \tbool intrs[IONIC_INTR_CTRL_REGS_MAX];\n-\tbool is_mgmt_nic;\n \tbool link_up;\n \tchar fw_version[IONIC_DEVINFO_FWVERS_BUFLEN];\n \tstruct rte_pci_device *pci_dev;\ndiff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c\nindex 5c2820b7a..fc68f5c74 100644\n--- a/drivers/net/ionic/ionic_dev.c\n+++ b/drivers/net/ionic/ionic_dev.c\n@@ -65,7 +65,6 @@ ionic_dev_setup(struct ionic_adapter *adapter)\n \t}\n \n \tidev->db_pages = bar->vaddr;\n-\tidev->phy_db_pages = bar->bus_addr;\n \n \treturn 0;\n }\n@@ -343,7 +342,6 @@ ionic_dev_cmd_adminq_init(struct ionic_dev *idev,\n \t\t.q_init.type = q->type,\n \t\t.q_init.index = q->index,\n \t\t.q_init.flags = IONIC_QINIT_F_ENA,\n-\t\t.q_init.pid = q->pid,\n \t\t.q_init.intr_index = intr_index,\n \t\t.q_init.ring_size = rte_log2_u32(q->num_descs),\n \t\t.q_init.ring_base = q->base_pa,\n@@ -419,7 +417,7 @@ ionic_cq_service(struct ionic_cq *cq, uint32_t work_to_do,\n int\n ionic_q_init(struct ionic_lif *lif, struct ionic_dev *idev,\n \t struct ionic_queue *q, uint32_t index, uint32_t num_descs,\n-\t size_t desc_size, size_t sg_desc_size, uint32_t pid)\n+\t size_t desc_size, size_t sg_desc_size)\n {\n \tuint32_t ring_size;\n \n@@ -439,7 +437,6 @@ ionic_q_init(struct ionic_lif *lif, struct ionic_dev *idev,\n \tq->sg_desc_size = sg_desc_size;\n \tq->head_idx = 0;\n \tq->tail_idx = 0;\n-\tq->pid = pid;\n \n \treturn 0;\n }\ndiff --git a/drivers/net/ionic/ionic_dev.h b/drivers/net/ionic/ionic_dev.h\nindex dc64a6d28..7150f7f2c 100644\n--- a/drivers/net/ionic/ionic_dev.h\n+++ b/drivers/net/ionic/ionic_dev.h\n@@ -120,10 +120,7 @@ struct ionic_dev {\n \tunion ionic_dev_cmd_regs __iomem *dev_cmd;\n \n \tstruct ionic_doorbell __iomem *db_pages;\n-\trte_iova_t phy_db_pages;\n-\n \tstruct ionic_intr __iomem *intr_ctrl;\n-\n \tstruct ionic_intr_status __iomem *intr_status;\n \n \tstruct ionic_port_info *port_info;\n@@ -163,11 +160,9 @@ struct ionic_queue {\n \tuint32_t num_descs;\n \tuint32_t desc_size;\n \tuint32_t sg_desc_size;\n-\tuint32_t pid;\n \tuint32_t qid;\n \tuint32_t qtype;\n \tstruct ionic_doorbell __iomem *db;\n-\tvoid *nop_desc;\n };\n \n #define IONIC_INTR_INDEX_NOT_ASSIGNED\t(-1)\n@@ -257,7 +252,7 @@ uint32_t ionic_cq_service(struct ionic_cq *cq, uint32_t work_to_do,\n \n int ionic_q_init(struct ionic_lif *lif, struct ionic_dev *idev,\n \tstruct ionic_queue *q, uint32_t index, uint32_t num_descs,\n-\tsize_t desc_size, size_t sg_desc_size, uint32_t pid);\n+\tsize_t desc_size, size_t sg_desc_size);\n void ionic_q_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n void ionic_q_sg_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n void ionic_q_flush(struct ionic_queue *q);\ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 600333e20..cd79f250e 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1178,8 +1178,6 @@ eth_ionic_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tgoto err_free_adapter;\n \t}\n \n-\tadapter->is_mgmt_nic = (pci_dev->id.device_id == IONIC_DEV_ID_ETH_MGMT);\n-\n \tadapter->num_bars = 0;\n \tfor (i = 0; i < PCI_MAX_RESOURCE && i < IONIC_BARS_MAX; i++) {\n \t\tresource = &pci_dev->mem_resource[i];\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 60a5f3d53..bc15d75fd 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -536,8 +536,6 @@ ionic_lif_change_mtu(struct ionic_lif *lif, int new_mtu)\n \tif (err)\n \t\treturn err;\n \n-\tlif->mtu = new_mtu;\n-\n \treturn 0;\n }\n \n@@ -583,7 +581,7 @@ ionic_qcq_alloc(struct ionic_lif *lif, uint8_t type,\n \t\tuint32_t desc_size,\n \t\tuint32_t cq_desc_size,\n \t\tuint32_t sg_desc_size,\n-\t\tuint32_t pid, struct ionic_qcq **qcq)\n+\t\tstruct ionic_qcq **qcq)\n {\n \tstruct ionic_dev *idev = &lif->adapter->idev;\n \tstruct ionic_qcq *new;\n@@ -633,7 +631,7 @@ ionic_qcq_alloc(struct ionic_lif *lif, uint8_t type,\n \tnew->q.type = type;\n \n \terr = ionic_q_init(lif, idev, &new->q, index, num_descs,\n-\t\tdesc_size, sg_desc_size, pid);\n+\t\tdesc_size, sg_desc_size);\n \tif (err) {\n \t\tIONIC_PRINT(ERR, \"Queue initialization failed\");\n \t\treturn err;\n@@ -734,7 +732,7 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index, uint16_t nrxq_descs,\n \t\tsizeof(struct ionic_rxq_desc),\n \t\tsizeof(struct ionic_rxq_comp),\n \t\tsizeof(struct ionic_rxq_sg_desc),\n-\t\tlif->kern_pid, &lif->rxqcqs[index]);\n+\t\t&lif->rxqcqs[index]);\n \tif (err)\n \t\treturn err;\n \n@@ -756,7 +754,7 @@ ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t index, uint16_t ntxq_descs,\n \t\tsizeof(struct ionic_txq_desc),\n \t\tsizeof(struct ionic_txq_comp),\n \t\tsizeof(struct ionic_txq_sg_desc),\n-\t\tlif->kern_pid, &lif->txqcqs[index]);\n+\t\t&lif->txqcqs[index]);\n \tif (err)\n \t\treturn err;\n \n@@ -777,7 +775,7 @@ ionic_admin_qcq_alloc(struct ionic_lif *lif)\n \t\tsizeof(struct ionic_admin_cmd),\n \t\tsizeof(struct ionic_admin_comp),\n \t\t0,\n-\t\tlif->kern_pid, &lif->adminqcq);\n+\t\t&lif->adminqcq);\n \tif (err)\n \t\treturn err;\n \n@@ -798,7 +796,7 @@ ionic_notify_qcq_alloc(struct ionic_lif *lif)\n \t\tsizeof(struct ionic_notifyq_cmd),\n \t\tsizeof(union ionic_notifyq_comp),\n \t\t0,\n-\t\tlif->kern_pid, &lif->notifyqcq);\n+\t\t&lif->notifyqcq);\n \tif (err)\n \t\treturn err;\n \n@@ -831,8 +829,6 @@ ionic_lif_alloc(struct ionic_lif *lif)\n \trte_spinlock_init(&lif->adminq_lock);\n \trte_spinlock_init(&lif->adminq_service_lock);\n \n-\tlif->kern_pid = 0;\n-\n \tdbpage_num = ionic_db_page_num(lif, 0);\n \n \tlif->kern_dbpage = ionic_bus_map_dbpage(adapter, dbpage_num);\n@@ -1211,13 +1207,11 @@ ionic_lif_notifyq_init(struct ionic_lif *lif)\n \t\t\t.index = q->index,\n \t\t\t.flags = (IONIC_QINIT_F_IRQ | IONIC_QINIT_F_ENA),\n \t\t\t.intr_index = qcq->intr.index,\n-\t\t\t.pid = q->pid,\n \t\t\t.ring_size = rte_log2_u32(q->num_descs),\n \t\t\t.ring_base = q->base_pa,\n \t\t}\n \t};\n \n-\tIONIC_PRINT(DEBUG, \"notifyq_init.pid %d\", ctx.cmd.q_init.pid);\n \tIONIC_PRINT(DEBUG, \"notifyq_init.index %d\",\n \t\tctx.cmd.q_init.index);\n \tIONIC_PRINT(DEBUG, \"notifyq_init.ring_base 0x%\" PRIx64 \"\",\n@@ -1320,7 +1314,6 @@ ionic_lif_txq_init(struct ionic_qcq *qcq)\n \t\t\t.index = q->index,\n \t\t\t.flags = IONIC_QINIT_F_SG,\n \t\t\t.intr_index = cq->bound_intr->index,\n-\t\t\t.pid = q->pid,\n \t\t\t.ring_size = rte_log2_u32(q->num_descs),\n \t\t\t.ring_base = q->base_pa,\n \t\t\t.cq_ring_base = cq->base_pa,\n@@ -1329,7 +1322,6 @@ ionic_lif_txq_init(struct ionic_qcq *qcq)\n \t};\n \tint err;\n \n-\tIONIC_PRINT(DEBUG, \"txq_init.pid %d\", ctx.cmd.q_init.pid);\n \tIONIC_PRINT(DEBUG, \"txq_init.index %d\", ctx.cmd.q_init.index);\n \tIONIC_PRINT(DEBUG, \"txq_init.ring_base 0x%\" PRIx64 \"\",\n \t\tctx.cmd.q_init.ring_base);\n@@ -1368,7 +1360,6 @@ ionic_lif_rxq_init(struct ionic_qcq *qcq)\n \t\t\t.index = q->index,\n \t\t\t.flags = IONIC_QINIT_F_SG,\n \t\t\t.intr_index = cq->bound_intr->index,\n-\t\t\t.pid = q->pid,\n \t\t\t.ring_size = rte_log2_u32(q->num_descs),\n \t\t\t.ring_base = q->base_pa,\n \t\t\t.cq_ring_base = cq->base_pa,\n@@ -1377,7 +1368,6 @@ ionic_lif_rxq_init(struct ionic_qcq *qcq)\n \t};\n \tint err;\n \n-\tIONIC_PRINT(DEBUG, \"rxq_init.pid %d\", ctx.cmd.q_init.pid);\n \tIONIC_PRINT(DEBUG, \"rxq_init.index %d\", ctx.cmd.q_init.index);\n \tIONIC_PRINT(DEBUG, \"rxq_init.ring_base 0x%\" PRIx64 \"\",\n \t\tctx.cmd.q_init.ring_base);\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex 425762d65..4e091719f 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -84,13 +84,11 @@ struct ionic_lif {\n \tstruct ionic_adapter *adapter;\n \tstruct rte_eth_dev *eth_dev;\n \tuint16_t port_id; /**< Device port identifier */\n-\tuint16_t mtu;\n \tuint32_t index;\n \tuint32_t hw_index;\n \tuint32_t state;\n \tuint32_t ntxqcqs;\n \tuint32_t nrxqcqs;\n-\tuint32_t kern_pid;\n \trte_spinlock_t adminq_lock;\n \trte_spinlock_t adminq_service_lock;\n \tstruct ionic_qcq *adminqcq;\ndiff --git a/drivers/net/ionic/ionic_regs.h b/drivers/net/ionic/ionic_regs.h\nindex 6ebc48d04..3bdec3424 100644\n--- a/drivers/net/ionic/ionic_regs.h\n+++ b/drivers/net/ionic/ionic_regs.h\n@@ -130,10 +130,4 @@ enum ionic_dbell_bits {\n \tIONIC_DBELL_INDEX_MASK\t\t= 0xffff,\n };\n \n-static inline void\n-ionic_dbell_ring(u64 __iomem *db_page, int qtype, u64 val)\n-{\n-\twriteq(val, &db_page[qtype]);\n-}\n-\n #endif /* _IONIC_REGS_H_ */\n", "prefixes": [ "v3", "5/9" ] }