Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84619/?format=api
{ "id": 84619, "url": "https://patches.dpdk.org/api/patches/84619/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201127110726.5328-1-nick.connolly@mayadata.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201127110726.5328-1-nick.connolly@mayadata.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201127110726.5328-1-nick.connolly@mayadata.io", "date": "2020-11-27T11:07:26", "name": "windows: build error with mingw debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f4e85900f097fb6876b5337e2c75e2aae5d5228d", "submitter": { "id": 1861, "url": "https://patches.dpdk.org/api/people/1861/?format=api", "name": "Nick Connolly", "email": "nick.connolly@mayadata.io" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201127110726.5328-1-nick.connolly@mayadata.io/mbox/", "series": [ { "id": 14131, "url": "https://patches.dpdk.org/api/series/14131/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14131", "date": "2020-11-27T11:07:26", "name": "windows: build error with mingw debug", "version": 1, "mbox": "https://patches.dpdk.org/series/14131/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84619/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8CD0DA0524;\n\tFri, 27 Nov 2020 12:09:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D2CB5C938;\n\tFri, 27 Nov 2020 12:09:24 +0100 (CET)", "from mail-wm1-f68.google.com (mail-wm1-f68.google.com\n [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id F0076C930\n for <dev@dpdk.org>; Fri, 27 Nov 2020 12:09:21 +0100 (CET)", "by mail-wm1-f68.google.com with SMTP id f190so3141686wme.1\n for <dev@dpdk.org>; Fri, 27 Nov 2020 03:09:21 -0800 (PST)", "from FENIX.localdomain\n (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78])\n by smtp.gmail.com with ESMTPSA id n4sm13041664wmc.30.2020.11.27.03.09.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Nov 2020 03:09:20 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mayadata-io.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=1HTB9zjrYBad6yFMyifFi7ZaM2G2d9zrbHyBap+7eUk=;\n b=xNOjAzxKaSXU/ZH6JkD01eZeCqonhS3aLCM8X6raeHM0vYA3k71v29o75kcI8zxVE6\n rHKpdxma8+8ZSZtJgaR1tL1TG0flmHHcwCtyBjgnQ9DdNpgPaumX8ZcOVZzlIpLpdBrX\n aly+ATPzIR6vfVEKPaPfuLabLp/GJDq4HQwLBjIdh2L+4j/d8z+kjDfERxuLYDcwEYFp\n l9/JxwC73gFFJepGFMignBBL9rU95UnvbRBrq8MHPItBkfKv8H6QNYZ7xYxrlJxR0Tdw\n jWXduujeeDQXzvdensmvy1GpxZIsV6AAGIwntLdAx/sRrhSQfo6A80v5vnfI+SO/YIYr\n TPpQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=1HTB9zjrYBad6yFMyifFi7ZaM2G2d9zrbHyBap+7eUk=;\n b=EvWaI470rKjxru/KfTtTQAnkRaAb436Dg5qN9KrAZMoMVXCN72WcOYv+h+B2tRNIe6\n uxqpbKM2BSAJSKrFVZvOYEvAnHWDTp6FqKTBbD5o8KI/iP+wMe+UHL6aFu9vboSa3mC7\n zIilbGSjTDz8MAapI7igKqSOlMn3SyIgZFjG+UkViok6dxHGCp0N4I6qA0vwKE8DRgTQ\n plHy+Wjj+YNIv/aA5roA1WQKjFGDbgxJ/p0tdn/oMRO/qjJeymaXz9XIaQyaonrl4/oF\n LpMH79Ti1lO+d3puURwPRxCqxOocOC5WSETHDvSOR2Rq5IcivFKv4uNZtGnePuEt1V56\n 5tnQ==", "X-Gm-Message-State": "AOAM533H5nypd6kwE3BC0jOXB0FGIB/g907LukqTYxRJdTlBMxrNiVnD\n lZzemusqjcobztc0anJ5C5nFrQ==", "X-Google-Smtp-Source": "\n ABdhPJxCxT2PpRaLh7s3+l59E+Ygh5SosuVu5k3YgdFx4lJdN1c+mburcr+GZuX3NZu/nnVKIdk6Kg==", "X-Received": "by 2002:a1c:a9c4:: with SMTP id\n s187mr8444938wme.180.1606475361611;\n Fri, 27 Nov 2020 03:09:21 -0800 (PST)", "From": "Nick Connolly <nick.connolly@mayadata.io>", "To": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Keith Wiles <keith.wiles@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ranjit Menon <ranjit.menon@intel.com>", "Cc": "dev@dpdk.org, David Marchand <david.marchand@redhat.com>,\n Nick Connolly <nick.connolly@mayadata.io>, stable@dpdk.org", "Date": "Fri, 27 Nov 2020 11:07:26 +0000", "Message-Id": "<20201127110726.5328-1-nick.connolly@mayadata.io>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] windows: build error with mingw debug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compiling with MinGW in --buildtype=debug produces a redefinition\nerror for strncasecmp.\n\nThe root cause is that rte_os.h shouldn't be injecting POSIX definitions\ninto the environment. It is the applications responsibility to decide\nhow to handle missing functionality.\n\nResolving this properly will require further work, but in the meantime\nwrap all such definitions with #ifndef/#endif. This resolves the specific\nissue with strncasecmp and handles similar issues that applications may\nencounter.\n\nFixes: e8428a9d89f1 (\"eal/windows: add some basic functions and macros\")\nCc: stable@dpdk.org\n\nSigned-off-by: Nick Connolly <nick.connolly@mayadata.io>\n---\n lib/librte_eal/windows/include/rte_os.h | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)", "diff": "diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h\nindex 569ed92d5..ea3fe60e5 100644\n--- a/lib/librte_eal/windows/include/rte_os.h\n+++ b/lib/librte_eal/windows/include/rte_os.h\n@@ -25,22 +25,42 @@ extern \"C\" {\n #define PATH_MAX _MAX_PATH\n #endif\n \n+#ifndef sleep\n #define sleep(x) Sleep(1000 * (x))\n+#endif\n \n+#ifndef strerror_r\n #define strerror_r(a, b, c) strerror_s(b, c, a)\n+#endif\n \n+#ifndef strdup\n /* strdup is deprecated in Microsoft libc and _strdup is preferred */\n #define strdup(str) _strdup(str)\n+#endif\n \n+#ifndef strtok_r\n #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr)\n+#endif\n \n+#ifndef index\n #define index(a, b) strchr(a, b)\n+#endif\n+\n+#ifndef rindex\n #define rindex(a, b) strrchr(a, b)\n+#endif\n \n+#ifndef strncasecmp\n #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)\n+#endif\n \n+#ifndef close\n #define close _close\n+#endif\n+\n+#ifndef unlink\n #define unlink _unlink\n+#endif\n \n /* cpu_set macros implementation */\n #define RTE_CPU_AND(dst, src1, src2) CPU_AND(dst, src1, src2)\n@@ -89,7 +109,9 @@ eal_strerror(int code)\n \treturn buffer;\n }\n \n+#ifndef strerror\n #define strerror eal_strerror\n+#endif\n \n #endif /* RTE_TOOLCHAIN_GCC */\n \n", "prefixes": [] }