Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84147/?format=api
{ "id": 84147, "url": "https://patches.dpdk.org/api/patches/84147/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1605277875-13625-2-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605277875-13625-2-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1605277875-13625-2-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-11-13T14:31:02", "name": "[v12,01/14] build: alias default build as generic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eee4c4d1322fb656cb6c4255f5f09c94e5400c4d", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1605277875-13625-2-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 13874, "url": "https://patches.dpdk.org/api/series/13874/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13874", "date": "2020-11-13T14:31:01", "name": "Arm build options rework", "version": 12, "mbox": "https://patches.dpdk.org/series/13874/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84147/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F4B1A09E0;\n\tFri, 13 Nov 2020 15:31:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20064C87C;\n\tFri, 13 Nov 2020 15:31:26 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id 21C144CA6\n for <dev@dpdk.org>; Fri, 13 Nov 2020 15:31:22 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id E63ECB931F;\n Fri, 13 Nov 2020 15:31:18 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id PQWYa6XVJm3O; Fri, 13 Nov 2020 15:31:17 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id B18E6B92ED;\n Fri, 13 Nov 2020 15:31:16 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Fri, 13 Nov 2020 15:31:02 +0100", "Message-Id": "<1605277875-13625-2-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1605277875-13625-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech>\n <1605277875-13625-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v12 01/14] build: alias default build as generic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current machine='default' build name is not descriptive. The actual\ndefault build is machine='native'. Add an alternative string which does\nthe same build and better describes what we're building:\nmachine='generic'. Leave machine='default' for backwards compatibility.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n config/arm/meson.build | 5 +++--\n config/meson.build | 9 +++++----\n doc/guides/prog_guide/build-sdk-meson.rst | 4 ++--\n meson_options.txt | 2 +-\n 4 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 42b4e43c7..d4066ade8 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -1,12 +1,13 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation.\n # Copyright(c) 2017 Cavium, Inc\n+# Copyright(c) 2020 PANTHEON.tech s.r.o.\n \n # for checking defines we need to use the correct compiler flags\n march_opt = '-march=@0@'.format(machine)\n \n arm_force_native_march = false\n-arm_force_default_march = (machine == 'default')\n+arm_force_generic_march = (machine == 'generic')\n \n flags_common_default = [\n \t# Accelarate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest)\n@@ -148,7 +149,7 @@ else\n \tcmd_generic = ['generic', '', '', 'default', '']\n \tcmd_output = cmd_generic # Set generic by default\n \tmachine_args = [] # Clear previous machine args\n-\tif arm_force_default_march and not meson.is_cross_build()\n+\tif arm_force_generic_march and not meson.is_cross_build()\n \t\tmachine = impl_generic\n \t\timpl_pn = 'default'\n \telif not meson.is_cross_build()\ndiff --git a/config/meson.build b/config/meson.build\nindex a29693b88..04694b8ad 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -70,13 +70,14 @@ else\n \tmachine = get_option('machine')\n endif\n \n-# machine type 'default' is special, it defaults to the per arch agreed common\n-# minimal baseline needed for DPDK.\n+# machine type 'generic' is special, it defaults to the per arch agreed common\n+# minimal baseline needed for DPDK. Machine type 'default' is also supported\n+# with the same meaning for backwards compatibility.\n # That might not be the most optimized, but the most portable version while\n # still being able to support the CPU features required for DPDK.\n # This can be bumped up by the DPDK project, but it can never be an\n # invariant like 'native'\n-if machine == 'default'\n+if machine == 'default' or machine == 'generic'\n \tif host_machine.cpu_family().startswith('x86')\n \t\t# matches the old pre-meson build systems default\n \t\tmachine = 'corei7'\n@@ -84,7 +85,7 @@ if machine == 'default'\n \t\tmachine = 'armv7-a'\n \telif host_machine.cpu_family().startswith('aarch')\n \t\t# arm64 manages defaults in config/arm/meson.build\n-\t\tmachine = 'default'\n+\t\tmachine = 'generic'\n \telif host_machine.cpu_family().startswith('ppc')\n \t\tmachine = 'power8'\n \tendif\ndiff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst\nindex 3429e2647..c7e12eedf 100644\n--- a/doc/guides/prog_guide/build-sdk-meson.rst\n+++ b/doc/guides/prog_guide/build-sdk-meson.rst\n@@ -85,7 +85,7 @@ Project-specific options are passed used -Doption=value::\n \n \tmeson -Denable_docs=true fullbuild # build and install docs\n \n-\tmeson -Dmachine=default # use builder-independent baseline -march\n+\tmeson -Dmachine=generic # use builder-independent baseline -march\n \n \tmeson -Ddisable_drivers=event/*,net/tap # disable tap driver and all\n \t\t\t\t\t# eventdev PMDs for a smaller build\n@@ -114,7 +114,7 @@ Examples of setting some of the same options using meson configure::\n re-scan from meson.\n \n .. note::\n- machine=default uses a config that works on all supported architectures\n+ machine=generic uses a config that works on all supported architectures\n regardless of the capabilities of the machine where the build is happening.\n \n As well as those settings taken from ``meson configure``, other options\ndiff --git a/meson_options.txt b/meson_options.txt\nindex e384e6dbb..dd9b37f98 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -21,7 +21,7 @@ option('kernel_dir', type: 'string', value: '',\n option('lib_musdk_dir', type: 'string', value: '',\n \tdescription: 'path to the MUSDK library installation directory')\n option('machine', type: 'string', value: 'native',\n-\tdescription: 'set the target machine type')\n+\tdescription: 'set the target machine type. Set to generic for a build usable on all machines of the build machine architecture, set to native to let the compiler pick the architecture of the build machine.')\n option('max_ethports', type: 'integer', value: 32,\n \tdescription: 'maximum number of Ethernet devices')\n option('max_lcores', type: 'integer', value: 128,\n", "prefixes": [ "v12", "01/14" ] }