Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83613/?format=api
{ "id": 83613, "url": "https://patches.dpdk.org/api/patches/83613/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103144858.1317742-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103144858.1317742-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103144858.1317742-1-bruce.richardson@intel.com", "date": "2020-11-03T14:48:58", "name": "raw/ioat: fix queue index calculation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "79b1c174409daeace6de7be7ad117738d3b33b9a", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103144858.1317742-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 13625, "url": "https://patches.dpdk.org/api/series/13625/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13625", "date": "2020-11-03T14:48:58", "name": "raw/ioat: fix queue index calculation", "version": 1, "mbox": "https://patches.dpdk.org/series/13625/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83613/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/83613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D84AA0521;\n\tTue, 3 Nov 2020 15:49:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65414CB93;\n\tTue, 3 Nov 2020 15:49:37 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id A9FD5CB63\n for <dev@dpdk.org>; Tue, 3 Nov 2020 15:49:30 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Nov 2020 06:49:24 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by fmsmga004.fm.intel.com with ESMTP; 03 Nov 2020 06:49:22 -0800" ], "IronPort-SDR": [ "\n 4HNW74Atr3kAfp6jI7/kPZ5JVv4GfCs86oE6zwz/p+sHIEukUargAXSZGNl3kf3sigB5yB/SNj\n X3SREaLsDwpw==", "\n SDVRO9GtcuPIDiJCBxEfEEoyD1heCVhrGT2oXQ1dU5kh6zfmqacwvauDy9FAQrpuCf6l98EZXd\n EAC1qwKUU1fQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9793\"; a=\"148915917\"", "E=Sophos;i=\"5.77,448,1596524400\"; d=\"scan'208\";a=\"148915917\"", "E=Sophos;i=\"5.77,448,1596524400\"; d=\"scan'208\";a=\"353351811\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "kevin.laatz@intel.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 3 Nov 2020 14:48:58 +0000", "Message-Id": "<20201103144858.1317742-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] raw/ioat: fix queue index calculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity flags a possible problem where the 8-bit wq_idx value may have\nerrors when shifted and sign-extended to 64-bits. Since this can only occur\nif the shift index is larger than any expected value from hardware, it's\nunlikely to cause any real problems, but we can eliminate any\npossible errors, and the coverity issue, by explicitly typecasting\nthe uint8_t value to 64-bits before any shift operations occur.\n\nCoverity issue: 363695\nFixes: a33969462135 (\"raw/ioat: fix work-queue config size\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/idxd_pci.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/raw/ioat/idxd_pci.c b/drivers/raw/ioat/idxd_pci.c\nindex 99ecfbbb4..7bc125014 100644\n--- a/drivers/raw/ioat/idxd_pci.c\n+++ b/drivers/raw/ioat/idxd_pci.c\n@@ -47,7 +47,8 @@ idxd_pci_dev_command(struct idxd_rawdev *idxd, enum rte_idxd_cmds command)\n static uint32_t *\n idxd_get_wq_cfg(struct idxd_pci_common *pci, uint8_t wq_idx)\n {\n-\treturn RTE_PTR_ADD(pci->wq_regs_base, wq_idx << (5 + pci->wq_cfg_sz));\n+\treturn RTE_PTR_ADD(pci->wq_regs_base,\n+\t\t\t(uint64_t)wq_idx << (5 + pci->wq_cfg_sz));\n }\n \n static int\n", "prefixes": [] }