Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83597/?format=api
{ "id": 83597, "url": "https://patches.dpdk.org/api/patches/83597/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-7-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103140931.488700-7-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103140931.488700-7-thomas@monjalon.net", "date": "2020-11-03T14:09:21", "name": "[v5,06/16] net/mlx5: fix dynamic mbuf offset lookup check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3ecb9e72680d57e105bdcfe83b96098bcd665915", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-7-thomas@monjalon.net/mbox/", "series": [ { "id": 13621, "url": "https://patches.dpdk.org/api/series/13621/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13621", "date": "2020-11-03T14:09:15", "name": "remove mbuf timestamp", "version": 5, "mbox": "https://patches.dpdk.org/series/13621/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83597/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83597/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8341DA0521;\n\tTue, 3 Nov 2020 15:12:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8EFC7CB35;\n\tTue, 3 Nov 2020 15:09:58 +0100 (CET)", "from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com\n [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id CB52CCB19;\n Tue, 3 Nov 2020 15:09:55 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id 44974580A4B;\n Tue, 3 Nov 2020 09:09:54 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:09:54 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id D259E3280060;\n Tue, 3 Nov 2020 09:09:52 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=N5XVBGmRr4nw6\n +7oDevfRN3r39vrlkp7xLtpl8ya5Kk=; b=F2NT0MEylcAIpFZYEs6o8Ww60jJld\n 7lBx36+IN+wDrGCsXQAnBv+V1FXK9oHLziRw0UnPWrc7+bsfCQkeES4nYc/uii4w\n 1uIGg682vX1CqQYyPyZgXXjOUZj761gi7NwpHSk+ZMBZJRQBrxDKKucxp7dhq61l\n mMJb9Px+DXhQ0HvLj6R/8NGDII4cxNSZJUr2qFW02zZhqY0q+sl0NfhD+unnceta\n uQL1nXPAYRHK+quOEMemjhnvIHQjwEG1v/4lT+c70LkcDFs0QoBnq0qCZh7HskBO\n fcPggsA9LPrUm+NHjVnYIL51DM3JI8nmkUAfkP7rPP+0UkFkhdR/a24/Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=N5XVBGmRr4nw6+7oDevfRN3r39vrlkp7xLtpl8ya5Kk=; b=Otn+kg0h\n 6LJIsBJ/67HjsPph9LJUag/wznGuUZfO4wPZlRgCL/vZfTCAOtAFZRJM7AYss8FY\n dcu0DcwUxYaFtKx6vq9+yVg2Dkt6PqclAOe4a/FoQjmOG9k7L/T9yz/j8CLs/hu0\n mTQr+1BW7SbJkd1A3miaoPcV3Web1Z/G2ybRXHKNKOPRzkgmrwqsldbuQHzJrbyW\n I/UqXWEZkQ+2OQ8hrx16zz/rPYJbA0A92PJDlJIkxUn658OsMntWArwke5Zny21L\n CB6KqxlKzEbdRkCIzbodzX1Tdg0T4bA81kymF/34gqJtRbaRrCfMLcpqjVR7dQOO\n dHO7bokwUbv4Wg==" ], "X-ME-Sender": "<xms:smShX3uOD1kuS5qYRMCCekhvGS9ez7q2csAqeEAsOC8KvyzupZCjIA>\n <xme:smShX4dI_DDUG_bib27_0xj2QqoV_-6EZfeQV8Piizxh4GdoiSDZkST6jZWzcDcS0\n jFlWrzAYskYVfs28A>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgheekucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:smShX6yDaGo4ptkIQIGI2CvOkBNOqzGpngjfCOuZ5May0hLKDdhOcw>\n <xmx:smShX2MEQATzZgr4gx0YirQsVTiX0Ps3RTPjSnFyhDfUl5d1C-MmUA>\n <xmx:smShX3-UunSA3O8aDt-XC2IpT81LRVbUvmu4321zZrcNk7-P5DHYYA>\n <xmx:smShX-YDO86cE1yU9YV9TRlL4NA2uRa2JbjrT9YLYHvkVvQSzyNvng>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,\n stable@dpdk.org, Matan Azrad <matan@nvidia.com>,\n Shahaf Shuler <shahafs@nvidia.com>, Ori Kam <orika@mellanox.com>", "Date": "Tue, 3 Nov 2020 15:09:21 +0100", "Message-Id": "<20201103140931.488700-7-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201103140931.488700-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>\n <20201103140931.488700-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 06/16] net/mlx5: fix dynamic mbuf offset\n\tlookup check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The functions rte_mbuf_dynfield_lookup() and rte_mbuf_dynflag_lookup()\ncan return an offset starting with 0 or a negative error code.\n\nIn reality the first offsets are probably reserved forever,\nbut for the sake of strict API compliance,\nthe checks which considered 0 as an error are fixed.\n\nFixes: efa79e68c8cd (\"net/mlx5: support fine grain dynamic flag\")\nFixes: 3172c471b86f (\"net/mlx5: prepare Tx queue structures to support timestamp\")\nFixes: 0febfcce3693 (\"net/mlx5: prepare Tx to support scheduling\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\nAcked-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 4 ++--\n drivers/net/mlx5/mlx5_trigger.c | 2 +-\n drivers/net/mlx5/mlx5_txq.c | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex b530ff421f..e86468b67a 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -5661,9 +5661,9 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)\n \t}\n \tif (tx_offloads & DEV_TX_OFFLOAD_SEND_ON_TIMESTAMP &&\n \t rte_mbuf_dynflag_lookup\n-\t\t\t(RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL) > 0 &&\n+\t\t\t(RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL) >= 0 &&\n \t rte_mbuf_dynfield_lookup\n-\t\t\t(RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL) > 0) {\n+\t\t\t(RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL) >= 0) {\n \t\t/* Offload configured, dynamic entities registered. */\n \t\tolx |= MLX5_TXOFF_CONFIG_TXPP;\n \t}\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 7735f022a3..917b433c4a 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -302,7 +302,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)\n \tDRV_LOG(DEBUG, \"port %u starting device\", dev->data->port_id);\n \tfine_inline = rte_mbuf_dynflag_lookup\n \t\t(RTE_PMD_MLX5_FINE_GRANULARITY_INLINE, NULL);\n-\tif (fine_inline > 0)\n+\tif (fine_inline >= 0)\n \t\trte_net_mlx5_dynf_inline_mask = 1UL << fine_inline;\n \telse\n \t\trte_net_mlx5_dynf_inline_mask = 0;\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex af84f5f72b..8ed2bcff7b 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -1305,7 +1305,7 @@ mlx5_txq_dynf_timestamp_set(struct rte_eth_dev *dev)\n \t\t\t\t(RTE_MBUF_DYNFLAG_TX_TIMESTAMP_NAME, NULL);\n \toff = rte_mbuf_dynfield_lookup\n \t\t\t\t(RTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL);\n-\tif (nbit > 0 && off >= 0 && sh->txpp.refcnt)\n+\tif (nbit >= 0 && off >= 0 && sh->txpp.refcnt)\n \t\tmask = 1ULL << nbit;\n \tfor (i = 0; i != priv->txqs_n; ++i) {\n \t\tdata = (*priv->txqs)[i];\n", "prefixes": [ "v5", "06/16" ] }