Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83464/?format=api
{ "id": 83464, "url": "https://patches.dpdk.org/api/patches/83464/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103001407.2931963-14-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103001407.2931963-14-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103001407.2931963-14-thomas@monjalon.net", "date": "2020-11-03T00:14:04", "name": "[v3,13/16] ethdev: add doxygen comment for Rx timestamp API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "79d4c4801a8c588cadf7b86370466c262e90837e", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103001407.2931963-14-thomas@monjalon.net/mbox/", "series": [ { "id": 13585, "url": "https://patches.dpdk.org/api/series/13585/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13585", "date": "2020-11-03T00:13:51", "name": "remove mbuf timestamp", "version": 3, "mbox": "https://patches.dpdk.org/series/13585/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83464/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 85F91A04E7;\n\tTue, 3 Nov 2020 01:18:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 51081AA1F;\n\tTue, 3 Nov 2020 01:14:55 +0100 (CET)", "from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com\n [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id AD205BE55\n for <dev@dpdk.org>; Tue, 3 Nov 2020 01:14:53 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id 73ABBB17;\n Mon, 2 Nov 2020 19:14:51 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 02 Nov 2020 19:14:52 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 13B97306467E;\n Mon, 2 Nov 2020 19:14:49 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=Nvjvcp834/ohH\n 4yHfu4NlXAupxaGuLa5aQnU3e9zlds=; b=HoGaQNQUqO2KvOtTCRem88/mUeEFD\n kE5At94QRuHAuSDKtc7Yvqu4CKDz0BBrhGPD/t2UBp606SHJsBG2JSGQbFHy3HaY\n Aar7o5mYjO9MnW7kS7qgYscSM0I6gJpXIzbGxlwt2kv+L6YB39OogG5kjAFsAAQD\n hrUhhoSeWWWPf3QFTgGUOYDJmWi3yrqdkctnzgIUBc/xn3BrALaNa63rBy9xSM+F\n m3wjYM/k9m7iXuVXLnfrgwiLoCJ9WimEwIQPp08AB8jF3wlagJrVvVlf0ZiQP6iD\n r6G/Y0YnUBvHbiAKz+L89tddepz39ymU9uGgCScYjLJQtSgnnFp/AvDbw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=Nvjvcp834/ohH4yHfu4NlXAupxaGuLa5aQnU3e9zlds=; b=irW4J9uH\n x/xsFExVbR7tC9p5F8Oag03SjYGhjPifbQ6yvEDd9uBB88/ED3+ZX3IZHFZSRX0W\n bzFhr4c+dxzPR8emml98ivhAsvSSHxqiz0qqjJnCHtsYG3ryacWWjz2DP8q43J+x\n cZZ35WXwDjsd1+GuHhX7BSf7khZ2ZyTvDjfS6n4qKfd28w/OrfpkF/k8TnhW600r\n HoLD+8kN4xL+U2nkJCjsSAR4xqCLuojzuUAN/GGIW0eBX5JbXvmNTDI72xSAEOJj\n /FLa8KQ67hajEeKhqSIaypyLm9i5BjRfpiwbERnp62by+ztAaxBCNce8n1JuUTSC\n kLOsmjkJAxPRDg==" ], "X-ME-Sender": "<xms:-qCgX4RrXVfs4BM2jyCuxbnF1jABizQVdIDVqro31HlupW5k2jXZlA>\n <xme:-qCgX1x7Bf8PPAK1cm_wJOmKZ-sBXQWwTXJlohDGvY5QyFT0scAJtVmXB9-qMmzBo\n sY9d2gKE5Zv2gehlQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtvddgudejucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre\n dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes\n mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvhefgiedvjeegtdevhe\n efhfetleefgfeivefgffevfeejgedtgfeutdehtdegveenucfkphepjeejrddufeegrddv\n tdefrddukeegnecuvehluhhsthgvrhfuihiivgepuddunecurfgrrhgrmhepmhgrihhlfh\n hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:-qCgX12GWvqs4m7hQ5hlGcAYLiqEkq0c6_wyYPpeGkjr0hqrXinOaQ>\n <xmx:-qCgX8Av4rU-JHcoeomOpBj1gDwD7bH0PVKN2-VaK85d8xaHPDTOVQ>\n <xmx:-qCgXxiZeGnVeJw3LFGeVgK4wFE5-b2WENwNlmwh_EE3rgKPFHuXog>\n <xmx:-6CgX_aUrgJJlzekEEgpJladNFHsJCfdF74dgblGBun8c1tfHL-Pgg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com", "Date": "Tue, 3 Nov 2020 01:14:04 +0100", "Message-Id": "<20201103001407.2931963-14-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201103001407.2931963-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>\n <20201103001407.2931963-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 13/16] ethdev: add doxygen comment for Rx\n\ttimestamp API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The offload flag DEV_RX_OFFLOAD_TIMESTAMP had no documentation.\nAfter switching to dynamic mbuf flag and field,\nit becomes even more important to explicit the feature behaviour.\n\nA doxyegn comment for the timesync API was mentioning\nthe deprecated timestamp field, so it is also updated.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_ethdev/rte_ethdev.h | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex ba997f16ce..1fc5f662fa 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1344,6 +1344,11 @@ struct rte_eth_conf {\n #define DEV_RX_OFFLOAD_VLAN_EXTEND\t0x00000400\n #define DEV_RX_OFFLOAD_JUMBO_FRAME\t0x00000800\n #define DEV_RX_OFFLOAD_SCATTER\t\t0x00002000\n+/**\n+ * Timestamp is set by the driver in RTE_MBUF_DYNFIELD_TIMESTAMP_NAME\n+ * and RTE_MBUF_DYNFLAG_RX_TIMESTAMP_NAME is set in ol_flags.\n+ * The mbuf field and flag are registered when the offload is configured.\n+ */\n #define DEV_RX_OFFLOAD_TIMESTAMP\t0x00004000\n #define DEV_RX_OFFLOAD_SECURITY 0x00008000\n #define DEV_RX_OFFLOAD_KEEP_CRC\t\t0x00010000\n@@ -4647,7 +4652,7 @@ int rte_eth_timesync_write_time(uint16_t port_id, const struct timespec *time);\n * rte_eth_read_clock(port, base_clock);\n *\n * Then, convert the raw mbuf timestamp with:\n- * base_time_sec + (double)(mbuf->timestamp - base_clock) / freq;\n+ * base_time_sec + (double)(*timestamp_dynfield(mbuf) - base_clock) / freq;\n *\n * This simple example will not provide a very good accuracy. One must\n * at least measure multiple times the frequency and do a regression.\n", "prefixes": [ "v3", "13/16" ] }