Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 83439,
    "url": "https://patches.dpdk.org/api/patches/83439/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201102183527.69209-7-aboyer@pensando.io/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201102183527.69209-7-aboyer@pensando.io>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201102183527.69209-7-aboyer@pensando.io",
    "date": "2020-11-02T18:35:25",
    "name": "[6/8] ionic: convert 'deferred' boolean to a flag bit",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "e5e166a17fc347192f9d1d37c4a9bf3f25ba7525",
    "submitter": {
        "id": 2036,
        "url": "https://patches.dpdk.org/api/people/2036/?format=api",
        "name": "Andrew Boyer",
        "email": "aboyer@pensando.io"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201102183527.69209-7-aboyer@pensando.io/mbox/",
    "series": [
        {
            "id": 13579,
            "url": "https://patches.dpdk.org/api/series/13579/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13579",
            "date": "2020-11-02T18:35:19",
            "name": "net/ionic: minor updates and documentation",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/13579/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/83439/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/83439/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 13C79A04E7;\n\tMon,  2 Nov 2020 19:37:50 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 228CA2E8F;\n\tMon,  2 Nov 2020 19:36:18 +0100 (CET)",
            "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 5D1642E8D\n for <dev@dpdk.org>; Mon,  2 Nov 2020 19:36:16 +0100 (CET)",
            "by mail-pf1-f195.google.com with SMTP id y14so11854257pfp.13\n for <dev@dpdk.org>; Mon, 02 Nov 2020 10:36:16 -0800 (PST)",
            "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id s4sm178186pjp.17.2020.11.02.10.36.14\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 02 Nov 2020 10:36:14 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=acyheu5Quei1gZLizMaxcGHB0DWJyP2PFS2KjlE0EW8=;\n b=dPs1P4qpM+RPVN8OsNEaC/KCZfLeBD7+2SjEpA89jnL498L7XH3S/Lx3OOQMk1YApr\n f4Qa788OiTgKJvdJEt66molTh9IcNAzs1c19B1dDoRWp05tLYlt82AxD5AEVPBcWoVO/\n WLZkiHCsDmYxZxDlhcXfaFztg4PeSBofMvUgGWyHd8BHf/ACWK650HBDhRlwVafgDXv3\n cYLevYPpsZ7duVJLgozI/wO30PD78s3kYuDz8UHugZjU1mqlAtyjgg0EdgsJRew+mtvN\n r1wCGTTW9DjqaitChAsC8HgZU/Ir2e/rP6do0SPdy9NrWw40oHIPJQwqSCVfDG7PFl0s\n wxyA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=acyheu5Quei1gZLizMaxcGHB0DWJyP2PFS2KjlE0EW8=;\n b=OVjLq4yop4VD7elwMGNBlR6mjioa9XBG1XeP6cW/hHddEb98FnA0v44EMS1ZQEO9rw\n +eKw7J30Yp3BnSWTmfy7PY8/975UKhF4u+b11RLqrkFdkc5xj94DGMaMxMorA29fdAGT\n Z1ZOR3vQvDn23SShFNZtcFEMMO4Uzhbi+OTpgLI2lnmxpkAeGOeIrp4TYe3YymyXMe4N\n XgbCiuVWnaE4ZjHeBIZ1AXaoqMXLeZesuyt3QO//ANPdxCr3ChsdXUkfyvOuvn5h4K5X\n FbTyODaG9S+MtqxQYmxxjQZQxVADrhsuYsz3zA0EUbe8l4QGpuUMSo0fYKnv0691aeFP\n EK/w==",
        "X-Gm-Message-State": "AOAM531RTedkIyoCzBCikQIpYXgRwY1h7ChTDP+dauK8zk6RHF/NlzYb\n 8RzJAaRLakwqnjb0KlEsPUB51zyyEVjq1y22",
        "X-Google-Smtp-Source": "\n ABdhPJzzmpm4e2JrhtAei71x1OgAnv1b9N/qE2yXDhy02lmA8IbaJXvTtkmkbPqE/7CdSSkcH1g7Ug==",
        "X-Received": "by 2002:a63:70d:: with SMTP id 13mr14717921pgh.263.1604342175384;\n Mon, 02 Nov 2020 10:36:15 -0800 (PST)",
        "From": "Andrew Boyer <aboyer@pensando.io>",
        "To": "dev@dpdk.org",
        "Cc": "cardigliano@ntop.org,\n\tAndrew Boyer <aboyer@pensando.io>",
        "Date": "Mon,  2 Nov 2020 10:35:25 -0800",
        "Message-Id": "<20201102183527.69209-7-aboyer@pensando.io>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20201102183527.69209-1-aboyer@pensando.io>",
        "References": "<20201102183527.69209-1-aboyer@pensando.io>",
        "Subject": "[dpdk-dev] [PATCH 6/8] ionic: convert 'deferred' boolean to a flag\n\tbit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This saves space in the structure.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.c  |  4 ++--\n drivers/net/ionic/ionic_lif.h  |  2 +-\n drivers/net/ionic/ionic_rxtx.c | 10 ++++++----\n 3 files changed, 9 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex bc15d75fd..2e33fb8d9 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -1590,7 +1590,7 @@ ionic_lif_start(struct ionic_lif *lif)\n \n \tfor (i = 0; i < lif->nrxqcqs; i++) {\n \t\tstruct ionic_qcq *rxq = lif->rxqcqs[i];\n-\t\tif (!rxq->deferred_start) {\n+\t\tif (!(rxq->flags & IONIC_QCQ_F_DEFERRED)) {\n \t\t\terr = ionic_dev_rx_queue_start(lif->eth_dev, i);\n \n \t\t\tif (err)\n@@ -1600,7 +1600,7 @@ ionic_lif_start(struct ionic_lif *lif)\n \n \tfor (i = 0; i < lif->ntxqcqs; i++) {\n \t\tstruct ionic_qcq *txq = lif->txqcqs[i];\n-\t\tif (!txq->deferred_start) {\n+\t\tif (!(txq->flags & IONIC_QCQ_F_DEFERRED)) {\n \t\t\terr = ionic_dev_tx_queue_start(lif->eth_dev, i);\n \n \t\t\tif (err)\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex 4e091719f..8e2b42443 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -50,6 +50,7 @@ struct ionic_rx_stats {\n #define IONIC_QCQ_F_SG\t\tBIT(1)\n #define IONIC_QCQ_F_INTR\tBIT(2)\n #define IONIC_QCQ_F_NOTIFYQ\tBIT(3)\n+#define IONIC_QCQ_F_DEFERRED\tBIT(4)\n \n /* Queue / Completion Queue */\n struct ionic_qcq {\n@@ -68,7 +69,6 @@ struct ionic_qcq {\n \tuint32_t total_size;\n \tuint32_t flags;\n \tstruct ionic_intr_info intr;\n-\tbool deferred_start;\n };\n \n #define IONIC_Q_TO_QCQ(q)\tcontainer_of(q, struct ionic_qcq, q)\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 2592f5cab..b953aff49 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -64,7 +64,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \n \tqinfo->nb_desc = q->num_descs;\n \tqinfo->conf.offloads = txq->offloads;\n-\tqinfo->conf.tx_deferred_start = txq->deferred_start;\n+\tqinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED;\n }\n \n static inline void __rte_cold\n@@ -196,7 +196,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \t}\n \n \t/* Do not start queue with rte_eth_dev_start() */\n-\ttxq->deferred_start = tx_conf->tx_deferred_start;\n+\tif (tx_conf->tx_deferred_start)\n+\t\ttxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n \ttxq->offloads = offloads;\n \n@@ -605,7 +606,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->mp = rxq->mb_pool;\n \tqinfo->scattered_rx = dev->data->scattered_rx;\n \tqinfo->nb_desc = q->num_descs;\n-\tqinfo->conf.rx_deferred_start = rxq->deferred_start;\n+\tqinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED;\n \tqinfo->conf.offloads = rxq->offloads;\n }\n \n@@ -703,7 +704,8 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \t */\n \n \t/* Do not start queue with rte_eth_dev_start() */\n-\trxq->deferred_start = rx_conf->rx_deferred_start;\n+\tif (rx_conf->rx_deferred_start)\n+\t\trxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n \trxq->offloads = offloads;\n \n",
    "prefixes": [
        "6/8"
    ]
}