Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82553/?format=api
{ "id": 82553, "url": "https://patches.dpdk.org/api/patches/82553/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1603875616-272798-14-git-send-email-suanmingm@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603875616-272798-14-git-send-email-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603875616-272798-14-git-send-email-suanmingm@nvidia.com", "date": "2020-10-28T08:59:54", "name": "[v5,13/34] net/mlx5: add flow table tunnel offload attribute", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "77a32f98d73d8cde74dd6e4c359182df8a423198", "submitter": { "id": 1887, "url": "https://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1603875616-272798-14-git-send-email-suanmingm@nvidia.com/mbox/", "series": [ { "id": 13411, "url": "https://patches.dpdk.org/api/series/13411/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13411", "date": "2020-10-28T08:59:42", "name": "net/mlx5: support multiple-thread flow operations", "version": 5, "mbox": "https://patches.dpdk.org/series/13411/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82553/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82553/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05E7AA04DD;\n\tWed, 28 Oct 2020 10:05:25 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C26ABE95;\n\tWed, 28 Oct 2020 10:03:25 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id CD32BC31F\n for <dev@dpdk.org>; Wed, 28 Oct 2020 10:02:17 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n suanmingm@nvidia.com) with SMTP; 28 Oct 2020 11:00:54 +0200", "from nvidia.com (mtbc-r640-04.mtbc.labs.mlnx [10.75.70.9])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09S90JmD024495;\n Wed, 28 Oct 2020 11:00:52 +0200" ], "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, rasland@nvidia.com", "Date": "Wed, 28 Oct 2020 16:59:54 +0800", "Message-Id": "<1603875616-272798-14-git-send-email-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603875616-272798-1-git-send-email-suanmingm@nvidia.com>", "References": "<1601984948-313027-1-git-send-email-suanmingm@nvidia.com>\n <1603875616-272798-1-git-send-email-suanmingm@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v5 13/34] net/mlx5: add flow table tunnel offload\n\tattribute", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As flow table is shared between the ports in the same shared IB device,\nflow table may be created by one port and released by other port.\n\nCurrently, the tunnel offloading active check in flow table release is\nbased on the port which release the flow table. Since the flow table\ncreate port and release port may have different tunnel offloading\nconfiguration, it will cause invalid tunnel offloading release or\ntunnel offloading resource leaks.\n\nAdd the flow table tunnel offloading attribute to indicate the flow\ntable has tunnel offloading resource or not to avoid wrong tunnel\noffloading operation.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.h | 1 +\n drivers/net/mlx5/mlx5_flow_dv.c | 3 ++-\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex cc64792..62c5e7c 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -538,6 +538,7 @@ struct mlx5_flow_tbl_data_entry {\n \tconst struct mlx5_flow_tunnel *tunnel;\n \tuint32_t group_id;\n \tbool external;\n+\tbool tunnel_offload; /* Tunnel offlod table or not. */\n };\n \n /* Sub rdma-core actions list. */\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 13bc46d..0b4b7ff 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -7986,6 +7986,7 @@ struct field_modify_info modify_tcp[] = {\n \ttbl_data->tunnel = tunnel;\n \ttbl_data->group_id = group_id;\n \ttbl_data->external = external;\n+\ttbl_data->tunnel_offload = is_tunnel_offload_active(dev);\n \ttbl = &tbl_data->tbl;\n \tpos = &tbl_data->entry;\n \tif (transfer)\n@@ -8061,7 +8062,7 @@ struct field_modify_info modify_tcp[] = {\n \n \t\tmlx5_flow_os_destroy_flow_tbl(tbl->obj);\n \t\ttbl->obj = NULL;\n-\t\tif (is_tunnel_offload_active(dev) && tbl_data->external) {\n+\t\tif (tbl_data->tunnel_offload && tbl_data->external) {\n \t\t\tstruct mlx5_hlist_entry *he;\n \t\t\tstruct mlx5_hlist *tunnel_grp_hash;\n \t\t\tstruct mlx5_flow_tunnel_hub *thub =\n", "prefixes": [ "v5", "13/34" ] }