Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80803/?format=api
{ "id": 80803, "url": "https://patches.dpdk.org/api/patches/80803/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20201014210225.16759-1-ohilyard@iol.unh.edu/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20201014210225.16759-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dts/20201014210225.16759-1-ohilyard@iol.unh.edu", "date": "2020-10-14T21:02:24", "name": "rte flow: fixing checkpatch issues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "10ee1a569dc650024a1c61b295a7a3fac81e7e08", "submitter": { "id": 1829, "url": "https://patches.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20201014210225.16759-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 12975, "url": "https://patches.dpdk.org/api/series/12975/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=12975", "date": "2020-10-14T21:02:24", "name": "rte flow: fixing checkpatch issues", "version": 1, "mbox": "https://patches.dpdk.org/series/12975/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80803/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/80803/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9615EA04DB;\n\tWed, 14 Oct 2020 23:02:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 85DAC1D631;\n\tWed, 14 Oct 2020 23:02:48 +0200 (CEST)", "from mail-qt1-f176.google.com (mail-qt1-f176.google.com\n [209.85.160.176]) by dpdk.org (Postfix) with ESMTP id ABFC01BFE6\n for <dts@dpdk.org>; Wed, 14 Oct 2020 23:02:46 +0200 (CEST)", "by mail-qt1-f176.google.com with SMTP id h19so338591qtq.4\n for <dts@dpdk.org>; Wed, 14 Oct 2020 14:02:46 -0700 (PDT)", "from ohilyard-Alienware-m17.unh.edu (nt-238-90.w4.unh.edu.\n [132.177.238.90])\n by smtp.googlemail.com with ESMTPSA id n2sm323375qtr.6.2020.10.14.14.02.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 14 Oct 2020 14:02:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ewdmdbqSQJ7IzeLk7rlDtQziiH0TygP3M34fykRSA80=;\n b=UjjBrq2x3mDp2qxjB8fYwVXtjDiNjnctjTEokC6HwHfUtbelXFqJdZLxFB8MuHyS82\n ZhCC7+zUFe2qUWSnh56h0JGY/viyR8Xjx7OD+Ahkctz4jrS8vCU2gj04h/3FQ+NAXpYl\n hZuws7QIzCyUR2WYArGVbeNorrDG31hHeDX8w=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ewdmdbqSQJ7IzeLk7rlDtQziiH0TygP3M34fykRSA80=;\n b=gzoTBceq+SvsPKhZpAScwYcK2zFNEMxEl2nz/1UB1Iv366w7cVyJlBFRc5mSLFq1/A\n 36wfw7Sh6eUSbg3TfxnQQRemTSQfc9ZHMLcaigNUgIdQ3Gmq3CXjiyPGGcnUlwZ2d4id\n zbtwg+JNzlFaVACZ1USh3A3ESu8fTSkgZHZmE7v8FIHyej8KnOp9165jFYaRODKasC8X\n +mtNeiOLIabQx1vj+1sO3/7gMOoHwJwGXi0qR9vN6iR1E9VPRlopL27qhnNvoiQD+cwV\n R+KexYKjlAB7vQG3YyWDJ7naljlXMh7VJWNLjQpw0+c+M3H2gvn2MaHMgK6CNfmn0bLF\n wadw==", "X-Gm-Message-State": "AOAM5312mLzLNyNQyayrDlNaDsA3K0B4ojxxqL3LGTrnFe+7MJI74WF1\n Y3zUjj/ZKV4mp5A3PLk56zf+sUtDdCpjB5GGloEdUcVZhuyl6vje3BBgMgLaJMpLKTI+CPkxAzF\n 23/TpRvtt/Wmpars9NHGiOJNS3XsHCrw4gsTCyij7Pb28Y10HjS99T9Z1mw==", "X-Google-Smtp-Source": "\n ABdhPJxOlWrLR0ZYuGLi94Coms1SCyYvvFddvP0eFGi1moApz3+lurs22GqCP5BZPX0595XXPxlb7w==", "X-Received": "by 2002:ac8:c04:: with SMTP id k4mr1172906qti.66.1602709364674;\n Wed, 14 Oct 2020 14:02:44 -0700 (PDT)", "From": "Owen Hilyard <ohilyard@iol.unh.edu>", "To": "dts@dpdk.org,\n\tlihongx.ma@intel.com", "Cc": "ohilyard@iol.unh.edu, lylavoie@iol.unh.edu, zhaoyan.chen@intel.com,\n yuan.peng@intel.com, lijuan.tu@intel.com, shall@iol.unh.edu", "Date": "Wed, 14 Oct 2020 17:02:24 -0400", "Message-Id": "<20201014210225.16759-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201014205051.16205-1-ohilyard@iol.unh.edu>", "References": "<20201014205051.16205-1-ohilyard@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dts] [PATCH] rte flow: fixing checkpatch issues", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "Apparently my linter didn't catch these issues.\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\n---\n framework/flow/flow_action_items.py | 6 +--\n framework/flow/flow_pattern_items.py | 58 ++++++++++++++--------------\n tests/TestSuite_rte_flow.py | 8 ++--\n 3 files changed, 35 insertions(+), 37 deletions(-)", "diff": "diff --git a/framework/flow/flow_action_items.py b/framework/flow/flow_action_items.py\nindex 50201ee2..d856cd1d 100644\n--- a/framework/flow/flow_action_items.py\n+++ b/framework/flow/flow_action_items.py\n@@ -72,7 +72,7 @@ class ActionFlowItem(FlowItem):\n \n class FlowActionVoid(ActionFlowItem):\n type = FlowActionType.VOID\n- \n+\n test_case = {\n 'test': ('ingress pattern eth / ipv4 src is 192.168.0.1 / udp / end actions void / end',\n frozenset({\"Ether() / IP(src=\\\"192.168.0.1\\\") / UDP() / ('\\\\x00' * 64)\"}),\n@@ -549,7 +549,7 @@ class FlowActionNvgre_encap(ActionFlowItem):\n # NVGRE PACKETS NOT SUPPORTED BY SCAPY.\n '''\n test_case = {\n- 'test': ('ingress pattern eth / ipv4 src is 192.168.0.1 \n+ 'test': ('ingress pattern eth / ipv4 src is 192.168.0.1\n / udp / end actions nvgre_encap definition 0x112233 / end',\n frozenset({\"Ether() / IP(src=\\\"192.168.0.1\\\") / UDP() / NVGRE() / ('\\\\x00' * 64)\"}),\n frozenset({\"Ether() / IP(src=\\\"192.168.0.2\\\") / UDP() / NVGRE() / ('\\\\x00' * 64)\",\n@@ -900,7 +900,7 @@ class FlowActionSet_meta(ActionFlowItem):\n \n class FlowActionSet_ipv4_dscp(ActionFlowItem):\n type = FlowActionType.SET_IPV4_DSCP\n- \n+\n test_case = {\n 'test': ('ingress pattern eth / ipv4 src is 192.168.0.1 '\n '/ udp / end actions set_ipv4_dscp dscp 2 / end',\ndiff --git a/framework/flow/flow_pattern_items.py b/framework/flow/flow_pattern_items.py\nindex 77e2de0d..25823cc8 100644\n--- a/framework/flow/flow_pattern_items.py\n+++ b/framework/flow/flow_pattern_items.py\n@@ -93,7 +93,7 @@ class FlowItemArp_eth_ipv4(PatternFlowItem):\n valid_parent_items: List[FlowItemType] = [FlowItemType.IPV4]\n \"\"\"\n - ``hdr``: hardware type, normally 1. => hwtype\n- - ``pro``: protocol type, normally 0x0800. => ptype = 2048 \n+ - ``pro``: protocol type, normally 0x0800. => ptype = 2048\n - ``hln``: hardware address length, normally 6. => hwlen\n - ``pln``: protocol address length, normally 4. => plen\n - ``op``: opcode (1 for request, 2 for reply). => op\n@@ -276,7 +276,6 @@ class FlowItemIcmp(PatternFlowItem):\n This definition includes:\n icmp_type (8 bits; for IPv4 echo request it's \"8\")\n icmp_code (8 bits)\n- \n THE FOLLOWING ARE NOT SUPPORTED IN TESTPMD:\n icmp_cksum (16 bits)\n icmp_ident (16 bits)\n@@ -384,7 +383,7 @@ class FlowItemIpv4(PatternFlowItem):\n valid_parent_items: List[FlowItemType] = [FlowItemType.ETH, FlowItemType.GRE]\n \"\"\"\n Note: IPv4 options are handled by dedicated pattern items.\n- \n+\n - ``hdr``: IPv4 header definition (``rte_ip.h``).\n - Default ``mask`` matches source and destination addresses only.\n \"\"\"\n@@ -458,7 +457,7 @@ class FlowItemIpv6(PatternFlowItem):\n \"\"\"\n Note: IPv6 options are handled by dedicated pattern items, see `Item:\n IPV6_EXT`_.\n- \n+\n - ``hdr``: IPv6 header definition (``rte_ip.h``).\n - Default ``mask`` matches source and destination addresses only.\n \"\"\"\n@@ -547,9 +546,9 @@ class FlowItemSctp(PatternFlowItem):\n valid_next_items = list(ALWAYS_ALLOWED_ITEMS)\n valid_parent_items: List[FlowItemType] = [FlowItemType.IPV4, FlowItemType.IPV6]\n \"\"\"\n- \n+\n **chunks?\n- \n+\n - ``hdr``: SCTP header definition (``rte_sctp.h``).\n - Default ``mask`` matches source and destination ports only.\n \"\"\"\n@@ -603,26 +602,26 @@ class FlowItemTcp(PatternFlowItem):\n \"\"\"\n - ``hdr``: TCP header definition (``rte_tcp.h``).\n - Default ``mask`` matches source and destination ports only.\n- \n+\n #define \tRTE_TCP_CWR_FLAG 0x80\n- \n+\n #define \tRTE_TCP_ECE_FLAG 0x40\n- \n+\n #define \tRTE_TCP_URG_FLAG 0x20\n- \n+\n #define \tRTE_TCP_ACK_FLAG 0x10\n- \n+\n #define \tRTE_TCP_PSH_FLAG 0x08\n- \n+\n #define \tRTE_TCP_RST_FLAG 0x04\n- \n+\n #define \tRTE_TCP_SYN_FLAG 0x02\n- \n+\n #define \tRTE_TCP_FIN_FLAG 0x01\n- \n- Can we set multiple flags at once in testing (ex. SYN, ACK)? \n+\n+ Can we set multiple flags at once in testing (ex. SYN, ACK)?\n Probably, and we can definitely test them if necessary.\n- \n+\n \"\"\"\n possible_properties = {\n # THE FOLLOWING PROPERTIES ARE UNSUPPORTED BY TESTPMD AT THE TIME OF WRITING.\n@@ -752,20 +751,19 @@ class FlowItemVlan(PatternFlowItem):\n preceding pattern item.\n If a ``VLAN`` item is present in the pattern, then only tagged packets will\n match the pattern.\n- \n+\n - ``tci``: tag control information.\n - ``inner_type``: inner EtherType or TPID.\n - Default ``mask`` matches the VID part of TCI only (lower 12 bits).\n- \n+\n tci in testpmd = pcp, dei, and vid, altogether.\n- \n+\n pcp in testpmd = prio in scapy\n- dei in testpmd = id in scapy? \n+ dei in testpmd = id in scapy?\n vid in testpmd = vlan in scapy\n- \n+\n tpid in testpmd = type in scapy\n- \n- \n+\n \"\"\"\n possible_properties = {\n \n@@ -827,8 +825,8 @@ class FlowItemVxlan(PatternFlowItem):\n - ``vni``: VXLAN network identifier.\n - ``rsvd1``: reserved, normally 0x00.\n - Default ``mask`` matches VNI only.\n- \n- TESTPMD ONLY SUPPORTS VNI. \n+\n+ TESTPMD ONLY SUPPORTS VNI.\n \"\"\"\n \n \n@@ -886,7 +884,7 @@ class FlowItemVxlan_gpe(PatternFlowItem):\n - ``vni``: VXLAN network identifier.\n - ``rsvd1``: reserved, normally 0x00.\n - Default ``mask`` matches VNI only.\n- \n+\n NOT CURRENTLY SUPPORTED BY TESTPMD.\n \"\"\"\n \n@@ -979,7 +977,7 @@ class FlowItemMeta(PatternFlowItem):\n type = FlowItemType.META\n \"\"\"\n Matches an application specific 32 bit metadata item.\n- \n+\n - Default ``mask`` matches the specified metadata value.\n \"\"\"\n \n@@ -989,9 +987,9 @@ class FlowItemTag(PatternFlowItem):\n \"\"\"\n Matches tag item set by other flows. Multiple tags are supported by specifying\n ``index``.\n- \n+\n - Default ``mask`` matches the specified tag value and index.\n- \n+\n +----------+----------+----------------------------------------+\n | Field | Subfield | Value |\n +==========+===========+=======================================+\ndiff --git a/tests/TestSuite_rte_flow.py b/tests/TestSuite_rte_flow.py\nindex 56277a18..0464a2df 100644\n--- a/tests/TestSuite_rte_flow.py\n+++ b/tests/TestSuite_rte_flow.py\n@@ -97,7 +97,7 @@ class RteFlow(TestCase):\n for packet in packets:\n output = self.send_scapy_packet(0, packet)\n time.sleep(5) # Allow the packet to be processed\n- self.verify(\"Sent\" in output, \"Broken scapy packet definiton: \" + packet)\n+ self.verify(\"Sent\" in output, \"Broken scapy packet definition: \" + packet)\n output = self.pmdout.get_output()\n self.verify(pass_fail_function(output),\n error_message + \"\\r\\n\" + output)\n@@ -151,8 +151,8 @@ class RteFlow(TestCase):\n \n \"\"\"\n Edge Cases\n- \n- These are tests which are designed to deal with edge cases. \n+\n+ These are tests which are designed to deal with edge cases.\n \"\"\"\n \n def test_excessive_voids(self):\n@@ -185,7 +185,7 @@ class RteFlow(TestCase):\n \n \"\"\"\n Action Test Cases\n- \n+\n These are test cases built for testing various actions\n \"\"\"\n \n", "prefixes": [] }