Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80239/?format=api
{ "id": 80239, "url": "https://patches.dpdk.org/api/patches/80239/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201009220202.20834-12-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201009220202.20834-12-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201009220202.20834-12-l.wojciechow@partner.samsung.com", "date": "2020-10-09T22:01:58", "name": "[v6,11/15] test/distributor: replace delays with spin locks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f50a6d277a76f176cd8dfa25ac6e836b17b1937b", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201009220202.20834-12-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 12840, "url": "https://patches.dpdk.org/api/series/12840/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12840", "date": "2020-10-09T22:01:47", "name": "fix distributor synchronization issues", "version": 6, "mbox": "https://patches.dpdk.org/series/12840/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80239/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/80239/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46B46A04BC;\n\tSat, 10 Oct 2020 00:06:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 929551D687;\n\tSat, 10 Oct 2020 00:03:15 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 8A4761D664\n for <dev@dpdk.org>; Sat, 10 Oct 2020 00:03:08 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20201009220258euoutp0116ed2b148e5d8bdc8fb044f562dec225~8cg_Dcl222277122771euoutp01E\n for <dev@dpdk.org>; Fri, 9 Oct 2020 22:02:58 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20201009220252eucas1p18c131871fbdb533a883d2b01fbf3e6fe~8cg4PW1og1070410704eucas1p1Z;\n Fri, 9 Oct 2020 22:02:52 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id 3F.E2.06318.C0ED08F5; Fri, 9\n Oct 2020 23:02:52 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20201009220250eucas1p18587737171d82a9bde52c767ee8ed24b~8cg3I_pGB0993409934eucas1p1d;\n Fri, 9 Oct 2020 22:02:50 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20201009220250eusmtrp248f73080e8ca700c2302efa00b61d26a~8cg3IfCY81642116421eusmtrp2j;\n Fri, 9 Oct 2020 22:02:50 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 54.5F.06017.A0ED08F5; Fri, 9\n Oct 2020 23:02:50 +0100 (BST)", "from Padamandas.fritz.box (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20201009220249eusmtip111213ace1658ffabcc4181737eb1cdb6~8cg1bharQ1334813348eusmtip1z;\n Fri, 9 Oct 2020 22:02:48 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20201009220258euoutp0116ed2b148e5d8bdc8fb044f562dec225~8cg_Dcl222277122771euoutp01E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1602280978;\n bh=9P4E0B5kieQ8/tBzQ8nyDsGgZm6tUvk7hTzdKz8POqg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=sjbZPTY0IYDSUpN/znyy/DE6KFMsYi9kTIPrfRHwnb3BbBXisyL6XXVo+7efEiCXw\n DilxPPOOL9B3XtvMU6C1QbxvufAjOibDDHuCqkzI4nXQL6VdpPm80Lv+LuT0IPQdqG\n nuIpViHQ1Nx9IsG9zsS7Y4w/kCna+PhooDz0r8qE=", "X-AuditID": "cbfec7f5-38bff700000018ae-af-5f80de0cdbea", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "David Hunt <david.hunt@intel.com>, Bruce Richardson\n <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org", "Date": "Sat, 10 Oct 2020 00:01:58 +0200", "Message-Id": "<20201009220202.20834-12-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201009220202.20834-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7o89xriDWb2slrcWGVv0TfpI5PF\n u0/bmSye9axjtPjX8YfdgdXj14KlrB6L97xk8jj4bg9TAHMUl01Kak5mWWqRvl0CV8b7zSsY\n C7pEK46dPMjcwLhGsIuRk0NCwERif9MW1i5GLg4hgRWMErd3XWGDcL4wSpzc950JwvkM5Nx7\n zgTTcmp2IyNEYjmjxKNHV1kgnE+MEmdv3mEDqWITsJU4MvMrK4gtIhAm0dy8F6iIg4NZwFni\n yVewEmEBL4mmnoPMIDaLgKrEzSl7wcp5BdwkPu9dyQyxTF5i9YYDYDYnULx11zKwXRICl9kk\n HnX2sUEUuUjMmDGTFcIWlnh1fAs7hC0j8X/nfCaIhm2MEld//2SEcPYzSlzvXQFVZS1x+N9v\n NojrNCXW79KHCDtKrLj/hAkkLCHAJ3HjLTjAmIHMSdumM0OEeSU62oQgqvUknvZMZYRZ+2ft\n ExYI20Piyrop7JDwucoo8eXlHOYJjPKzEJYtYGRcxSieWlqcm55abJyXWq5XnJhbXJqXrpec\n n7uJERj/p/8d/7qDcd+fpEOMAhyMSjy8DckN8UKsiWXFlbmHGCU4mJVEeJ3Ono4T4k1JrKxK\n LcqPLyrNSS0+xCjNwaIkzmu86GWskEB6YklqdmpqQWoRTJaJg1OqgdFYNCDuwkwGvcLnm/NT\n 5QuspkRdSFVYtXCBH9Nr4a3zY16fFo6XNeo4LPhLzWd5IZdXkviUO9eCzNf9Yv7ik8hjtmiP\n QmUgx4e8i/asyZt7HvvOXXKQ7cnJF9wOaTkWL1cyLcoUXHEpPLBG9EnctbKjflN2TpAK/SSS\n uffC8sydp+2q8h6YeCixFGckGmoxFxUnAgCe4RDl+wIAAA==", "\n H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xu7pc9xriDf7eN7G4screom/SRyaL\n d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj\n PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYz3m1cwFnSJVhw7eZC5gXGNYBcjJ4eE\n gInEqdmNjF2MXBxCAksZJd5ca2XuYuQASshIfLgkAFEjLPHnWhcbRM0HRokfp64zgSTYBGwl\n jsz8ygpSLyIQJnFipT9ImFnAXWLL4qnMILawgJdEU89BMJtFQFXi5pS9rCA2r4CbxOe9K5kh\n 5stLrN5wAMzmBIq37lrGArGrkVFiy4GXzBMY+RYwMqxiFEktLc5Nzy020itOzC0uzUvXS87P\n 3cQIDMVtx35u2cHY9S74EKMAB6MSD69GYkO8EGtiWXFl7iFGCQ5mJRFep7On44R4UxIrq1KL\n 8uOLSnNSiw8xmgJdNZFZSjQ5HxgneSXxhqaG5haWhubG5sZmFkrivB0CB2OEBNITS1KzU1ML\n Uotg+pg4OKUaGJMDzyr1Sxa8LBCxj11oPK+A2951zxZmZ02RfRqtIedSJZwUysQ/LnZ7ankn\n Uqnd8fTRxRcNjwd9s/jaLRfz8NmUJxPr+Bc+U7de8/DK0aS8n9J73Gq8fqi17nexu1isnuUf\n dWpCb1NQvVjfvIbOiXLGz7pW/ubO/GV/XWiX8GMTx+pXhbyMSizFGYmGWsxFxYkAPMcebVsC\n AAA=" ], "X-CMS-MailID": "20201009220250eucas1p18587737171d82a9bde52c767ee8ed24b", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20201009220250eucas1p18587737171d82a9bde52c767ee8ed24b", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20201009220250eucas1p18587737171d82a9bde52c767ee8ed24b", "References": "<20201008052323.11547-1-l.wojciechow@partner.samsung.com>\n <20201009220202.20834-1-l.wojciechow@partner.samsung.com>\n <CGME20201009220250eucas1p18587737171d82a9bde52c767ee8ed24b@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v6 11/15] test/distributor: replace delays with\n\tspin locks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of making delays in test code and waiting\nfor worker hopefully to reach proper states,\nsynchronize worker shutdown test cases with spin lock\non atomic variable.\n\nFixes: c0de0eb82e40 (\"distributor: switch over to new API\")\nCc: david.hunt@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n app/test/test_distributor.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex ed03040d1..e8dd75078 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -27,6 +27,7 @@ struct worker_params worker_params;\n /* statics - all zero-initialized by default */\n static volatile int quit; /**< general quit variable for all threads */\n static volatile int zero_quit; /**< var for when we just want thr0 to quit*/\n+static volatile int zero_sleep; /**< thr0 has quit basic loop and is sleeping*/\n static volatile unsigned worker_idx;\n static volatile unsigned zero_idx;\n \n@@ -376,8 +377,10 @@ handle_work_for_shutdown_test(void *arg)\n \t\t/* for worker zero, allow it to restart to pick up last packet\n \t\t * when all workers are shutting down.\n \t\t */\n+\t\t__atomic_store_n(&zero_sleep, 1, __ATOMIC_RELEASE);\n \t\twhile (zero_quit)\n \t\t\tusleep(100);\n+\t\t__atomic_store_n(&zero_sleep, 0, __ATOMIC_RELEASE);\n \n \t\tnum = rte_distributor_get_pkt(d, id, buf, NULL, 0);\n \n@@ -445,7 +448,12 @@ sanity_test_with_worker_shutdown(struct worker_params *wp,\n \n \t/* flush the distributor */\n \trte_distributor_flush(d);\n-\trte_delay_us(10000);\n+\twhile (!__atomic_load_n(&zero_sleep, __ATOMIC_ACQUIRE))\n+\t\trte_distributor_flush(d);\n+\n+\tzero_quit = 0;\n+\twhile (__atomic_load_n(&zero_sleep, __ATOMIC_ACQUIRE))\n+\t\trte_delay_us(100);\n \n \tfor (i = 0; i < rte_lcore_count() - 1; i++)\n \t\tprintf(\"Worker %u handled %u packets\\n\", i,\n@@ -505,9 +513,14 @@ test_flush_with_worker_shutdown(struct worker_params *wp,\n \t/* flush the distributor */\n \trte_distributor_flush(d);\n \n-\trte_delay_us(10000);\n+\twhile (!__atomic_load_n(&zero_sleep, __ATOMIC_ACQUIRE))\n+\t\trte_distributor_flush(d);\n \n \tzero_quit = 0;\n+\n+\twhile (__atomic_load_n(&zero_sleep, __ATOMIC_ACQUIRE))\n+\t\trte_delay_us(100);\n+\n \tfor (i = 0; i < rte_lcore_count() - 1; i++)\n \t\tprintf(\"Worker %u handled %u packets\\n\", i,\n \t\t\t__atomic_load_n(&worker_stats[i].handled_packets,\n@@ -615,6 +628,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)\n \tquit = 0;\n \tworker_idx = 0;\n \tzero_idx = RTE_MAX_LCORE;\n+\tzero_quit = 0;\n+\tzero_sleep = 0;\n }\n \n static int\n", "prefixes": [ "v6", "11/15" ] }