Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80144/?format=api
{ "id": 80144, "url": "https://patches.dpdk.org/api/patches/80144/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201009111130.10422-14-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201009111130.10422-14-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201009111130.10422-14-somnath.kotur@broadcom.com", "date": "2020-10-09T11:11:30", "name": "[13/13] net/bnxt: remove parent fid validation in vnic change event processing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7c161cbb8f189d7fc603314ace1081b0d17f3422", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201009111130.10422-14-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 12818, "url": "https://patches.dpdk.org/api/series/12818/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12818", "date": "2020-10-09T11:11:17", "name": "bnxt patches", "version": 1, "mbox": "https://patches.dpdk.org/series/12818/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80144/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/80144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7ED4CA04C0;\n\tFri, 9 Oct 2020 13:24:10 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A58101D55B;\n\tFri, 9 Oct 2020 13:19:15 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (saphodev.broadcom.com\n [192.19.232.172]) by dpdk.org (Postfix) with ESMTP id 388B21D524;\n Fri, 9 Oct 2020 13:19:13 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 2FC26829A;\n Fri, 9 Oct 2020 04:19:09 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 2FC26829A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1602242351;\n bh=PGkQOJYIsrQSMlQy9DhxLnEDN7o/6EmqhFdQTF/91xU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=oYuRzHhTxmayGniC61G5mBS4m7acVVo/UulP0SwcgkotaPshNvYukHnEMkv+Pw8t8\n i5DyFr0HM3lq416Ts7DmoJmxQPCGOq/oMJZj1XrcJpRU5jlY3y6G4sCtQDmt+IypUL\n AzMqFdMWGCr+ZIy1gNgTmxabkN46zWTpSb5GtG7c=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n stable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Fri, 9 Oct 2020 16:41:30 +0530", "Message-Id": "<20201009111130.10422-14-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "In-Reply-To": "<20201009111130.10422-1-somnath.kotur@broadcom.com>", "References": "<20201009111130.10422-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 13/13] net/bnxt: remove parent fid validation in\n\tvnic change event processing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n\nCurrently, when default vnic change async event is received, the async\nevent handler will try to validate whether the parent fid that is coming\nas part of the event data is of the control channel's fid.\nThis validation will fail in case of SR device because the parent\nfunction of the vnic and the control channel function (Foster parent)\nare different.\n\nThis patch fixes the problem by removing this parent fid validation as\nit is not really needed in case of Wh+ also.\n\nFixes: 322bd6e70272 (\"net/bnxt: add port representor infrastructure\")\nCc: stable@dpdk.org\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 5492394..91d1ffe 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -50,7 +50,7 @@ static void\n bnxt_process_default_vnic_change(struct bnxt *bp,\n \t\t\t\t struct hwrm_async_event_cmpl *async_cmp)\n {\n-\tuint16_t fid, vnic_state, parent_id, vf_fid, vf_id;\n+\tuint16_t vnic_state, vf_fid, vf_id;\n \tstruct bnxt_representor *vf_rep_bp;\n \tstruct rte_eth_dev *eth_dev;\n \tbool vfr_found = false;\n@@ -67,10 +67,7 @@ bnxt_process_default_vnic_change(struct bnxt *bp,\n \tif (vnic_state != BNXT_DEFAULT_VNIC_ALLOC)\n \t\treturn;\n \n-\tparent_id = (event_data & BNXT_DEFAULT_VNIC_CHANGE_PF_ID_MASK) >>\n-\t\t\tBNXT_DEFAULT_VNIC_CHANGE_PF_ID_SFT;\n-\tfid = BNXT_PF(bp) ? bp->fw_fid : bp->parent->fid;\n-\tif (parent_id != fid || !bp->rep_info)\n+\tif (!bp->rep_info)\n \t\treturn;\n \n \tvf_fid = (event_data & BNXT_DEFAULT_VNIC_CHANGE_VF_ID_MASK) >>\n", "prefixes": [ "13/13" ] }