Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78906/?format=api
{ "id": 78906, "url": "https://patches.dpdk.org/api/patches/78906/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200927072626.28374-4-robinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200927072626.28374-4-robinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200927072626.28374-4-robinx.zhang@intel.com", "date": "2020-09-27T07:26:21", "name": "[3/8] net/iavf: re-program promiscuous mode on VF interface", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dbd84a5b0c5790f788d903c44eebd4ccff728b2a", "submitter": { "id": 2004, "url": "https://patches.dpdk.org/api/people/2004/?format=api", "name": "Robin Zhang", "email": "robinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200927072626.28374-4-robinx.zhang@intel.com/mbox/", "series": [ { "id": 12526, "url": "https://patches.dpdk.org/api/series/12526/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12526", "date": "2020-09-27T07:26:18", "name": "feature porting from i40evf to iavf", "version": 1, "mbox": "https://patches.dpdk.org/series/12526/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78906/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 842D3A04BC;\n\tSun, 27 Sep 2020 09:48:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4966C1D902;\n\tSun, 27 Sep 2020 09:47:26 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 930DC1D8DD\n for <dev@dpdk.org>; Sun, 27 Sep 2020 09:47:23 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2020 00:47:22 -0700", "from intel-npg-odc-srv03.cd.intel.com ([10.240.178.138])\n by orsmga002.jf.intel.com with ESMTP; 27 Sep 2020 00:47:20 -0700" ], "IronPort-SDR": [ "\n Fn0IMWe5Qhv+uNtYnTgS7IWOsday83tHru+I17SDeAwDyabt5aO+IZ2tekFRWf70Q0X4serg1P\n zXoejhH9qZhg==", "\n ScKPEoUt8veOI4C1vicqWGV3avotGzGwvK8Vma7c6jOIaafWr1EsT+qyXK5ktYjrJayPvytClL\n SDyA8qhENZ0Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9756\"; a=\"223438300\"", "E=Sophos;i=\"5.77,309,1596524400\"; d=\"scan'208\";a=\"223438300\"", "E=Sophos;i=\"5.77,309,1596524400\"; d=\"scan'208\";a=\"323939381\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Robin Zhang <robinx.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com,\n stevex.yang@intel.com, Robin Zhang <robinx.zhang@intel.com>", "Date": "Sun, 27 Sep 2020 07:26:21 +0000", "Message-Id": "<20200927072626.28374-4-robinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200927072626.28374-1-robinx.zhang@intel.com>", "References": "<20200927072626.28374-1-robinx.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/8] net/iavf: re-program promiscuous mode on VF\n\tinterface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During a kernel PF reset, this event is propagated to the VF.\nThe DPDK VF PMD will execute the reset task before the PF is done\nwith his. This results in the admin queue message not being responded\nto leaving the port in \"promiscuous\" mode.\n\nThis patch makes sure the promiscuous mode is configured independently\nof the current admin state.\n\nSigned-off-by: Robin Zhang <robinx.zhang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 12 ------------\n 1 file changed, 12 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex d21e35c17..57640c52a 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -678,9 +678,6 @@ iavf_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n \tint ret;\n \n-\tif (vf->promisc_unicast_enabled)\n-\t\treturn 0;\n-\n \tret = iavf_config_promisc(adapter, true, vf->promisc_multicast_enabled);\n \tif (!ret)\n \t\tvf->promisc_unicast_enabled = true;\n@@ -700,9 +697,6 @@ iavf_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n \tint ret;\n \n-\tif (!vf->promisc_unicast_enabled)\n-\t\treturn 0;\n-\n \tret = iavf_config_promisc(adapter, false,\n \t\t\t\t vf->promisc_multicast_enabled);\n \tif (!ret)\n@@ -723,9 +717,6 @@ iavf_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n \tint ret;\n \n-\tif (vf->promisc_multicast_enabled)\n-\t\treturn 0;\n-\n \tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, true);\n \tif (!ret)\n \t\tvf->promisc_multicast_enabled = true;\n@@ -745,9 +736,6 @@ iavf_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n \tint ret;\n \n-\tif (!vf->promisc_multicast_enabled)\n-\t\treturn 0;\n-\n \tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, false);\n \tif (!ret)\n \t\tvf->promisc_multicast_enabled = false;\n", "prefixes": [ "3/8" ] }