Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78391/?format=api
{ "id": 78391, "url": "https://patches.dpdk.org/api/patches/78391/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200922100111.128316-1-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922100111.128316-1-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922100111.128316-1-pablo.de.lara.guarch@intel.com", "date": "2020-09-22T10:01:10", "name": "[v2,1/2] crypto/aesni_gcm: support SGL on AES-GMAC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6f1ba4865a0a7103678d6872de17f7c8e3110b5b", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200922100111.128316-1-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 12405, "url": "https://patches.dpdk.org/api/series/12405/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12405", "date": "2020-09-22T10:01:10", "name": "[v2,1/2] crypto/aesni_gcm: support SGL on AES-GMAC", "version": 2, "mbox": "https://patches.dpdk.org/series/12405/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78391/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCEF8A04E1;\n\tTue, 22 Sep 2020 12:01:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDE641DC77;\n\tTue, 22 Sep 2020 12:01:21 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id A6E5D1DBA3\n for <dev@dpdk.org>; Tue, 22 Sep 2020 12:01:19 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Sep 2020 03:01:18 -0700", "from silpixa00400637.ir.intel.com ([10.237.213.160])\n by orsmga004.jf.intel.com with ESMTP; 22 Sep 2020 03:01:17 -0700" ], "IronPort-SDR": [ "\n 6e2SxP6/yzSwjWMDozA+SMgCjeeIQLVJiJkkodIP5NkZVIdkP5IV/8KNbS9xEnRTd5XYmUldtw\n mTIwcFk+HeGw==", "\n AjsBfRXpAvmVGytq7K4WtUM4IDAeLDc+vKH82PPjvcVymwnllx0+9in0eVXjHyc11zK1mSKAcV\n UVgwkCh3T9Fg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9751\"; a=\"148234467\"", "E=Sophos;i=\"5.77,290,1596524400\"; d=\"scan'208\";a=\"148234467\"", "E=Sophos;i=\"5.77,290,1596524400\"; d=\"scan'208\";a=\"454438375\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Tue, 22 Sep 2020 10:01:10 +0000", "Message-Id": "<20200922100111.128316-1-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200911120818.2665269-1-pablo.de.lara.guarch@intel.com>", "References": "<20200911120818.2665269-1-pablo.de.lara.guarch@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] crypto/aesni_gcm: support SGL on AES-GMAC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add Scatter-gather list support for AES-GMAC.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n\nChanges:\n- v2: no change\n\n---\n\n doc/guides/cryptodevs/aesni_gcm.rst | 2 -\n doc/guides/rel_notes/release_20_11.rst | 4 ++\n drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 27 ++++++++\n drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 88 +++++++++++++++++++++++-\n 4 files changed, 118 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/aesni_gcm.rst b/doc/guides/cryptodevs/aesni_gcm.rst\nindex 74e0de63a..0e146486e 100644\n--- a/doc/guides/cryptodevs/aesni_gcm.rst\n+++ b/doc/guides/cryptodevs/aesni_gcm.rst\n@@ -31,8 +31,6 @@ Limitations\n -----------\n \n * In out-of-place operations, chained destination mbufs are not supported.\n-* Chained mbufs are only supported by RTE_CRYPTO_AEAD_AES_GCM algorithm,\n- not RTE_CRYPTO_AUTH_AES_GMAC.\n * Cipher only is not supported.\n \n \ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex df227a177..98fd4ae0f 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -55,6 +55,10 @@ New Features\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* **Updated the AESNI GCM crypto PMD.**\n+\n+ * Added SGL support AES-GMAC.\n+\n \n Removed Items\n -------------\ndiff --git a/drivers/crypto/aesni_gcm/aesni_gcm_ops.h b/drivers/crypto/aesni_gcm/aesni_gcm_ops.h\nindex 74acac09c..8a0d074b6 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_ops.h\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_ops.h\n@@ -53,6 +53,23 @@ typedef void (*aesni_gcm_finalize_t)(const struct gcm_key_data *gcm_key_data,\n \t\tuint8_t *auth_tag,\n \t\tuint64_t auth_tag_len);\n \n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+typedef void (*aesni_gmac_init_t)(const struct gcm_key_data *gcm_key_data,\n+\t\tstruct gcm_context_data *gcm_ctx_data,\n+\t\tconst uint8_t *iv,\n+\t\tconst uint64_t iv_len);\n+\n+typedef void (*aesni_gmac_update_t)(const struct gcm_key_data *gcm_key_data,\n+\t\tstruct gcm_context_data *gcm_ctx_data,\n+\t\tconst uint8_t *in,\n+\t\tconst uint64_t plaintext_len);\n+\n+typedef void (*aesni_gmac_finalize_t)(const struct gcm_key_data *gcm_key_data,\n+\t\tstruct gcm_context_data *gcm_ctx_data,\n+\t\tuint8_t *auth_tag,\n+\t\tconst uint64_t auth_tag_len);\n+#endif\n+\n /** GCM library function pointer table */\n struct aesni_gcm_ops {\n \taesni_gcm_t enc; /**< GCM encode function pointer */\n@@ -63,6 +80,11 @@ struct aesni_gcm_ops {\n \taesni_gcm_update_t update_dec;\n \taesni_gcm_finalize_t finalize_enc;\n \taesni_gcm_finalize_t finalize_dec;\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\taesni_gmac_init_t gmac_init;\n+\taesni_gmac_update_t gmac_update;\n+\taesni_gmac_finalize_t gmac_finalize;\n+#endif\n };\n \n /** GCM per-session operation handlers */\n@@ -72,6 +94,11 @@ struct aesni_gcm_session_ops {\n \taesni_gcm_init_t init;\n \taesni_gcm_update_t update;\n \taesni_gcm_finalize_t finalize;\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\taesni_gmac_init_t gmac_init;\n+\taesni_gmac_update_t gmac_update;\n+\taesni_gmac_finalize_t gmac_finalize;\n+#endif\n };\n \n #endif /* _AESNI_GCM_OPS_H_ */\ndiff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\nindex 1d2a0ce00..aea599ebf 100644\n--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c\n@@ -350,6 +350,76 @@ process_gcm_crypto_op(struct aesni_gcm_qp *qp, struct rte_crypto_op *op,\n \t\t\t\t&qp->gdata_ctx,\n \t\t\t\ttag,\n \t\t\t\tsession->gen_digest_length);\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\t} else if (session->op == AESNI_GMAC_OP_GENERATE) {\n+\t\tqp->ops[session->key].gmac_init(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx,\n+\t\t\t\tiv_ptr,\n+\t\t\t\tsession->iv.length);\n+\n+\t\tqp->ops[session->key].gmac_update(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx, src,\n+\t\t\t\t(uint64_t)part_len);\n+\t\ttotal_len = data_length - part_len;\n+\n+\t\twhile (total_len) {\n+\t\t\tm_src = m_src->next;\n+\n+\t\t\tRTE_ASSERT(m_src != NULL);\n+\n+\t\t\tsrc = rte_pktmbuf_mtod(m_src, uint8_t *);\n+\t\t\tpart_len = (m_src->data_len < total_len) ?\n+\t\t\t\t\tm_src->data_len : total_len;\n+\n+\t\t\tqp->ops[session->key].gmac_update(&session->gdata_key,\n+\t\t\t\t\t&qp->gdata_ctx, src,\n+\t\t\t\t\t(uint64_t)part_len);\n+\t\t\ttotal_len -= part_len;\n+\t\t}\n+\n+\t\tif (session->req_digest_length != session->gen_digest_length)\n+\t\t\ttag = qp->temp_digest;\n+\t\telse\n+\t\t\ttag = sym_op->auth.digest.data;\n+\n+\t\tqp->ops[session->key].gmac_finalize(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx,\n+\t\t\t\ttag,\n+\t\t\t\tsession->gen_digest_length);\n+\t} else { /* AESNI_GMAC_OP_VERIFY */\n+\t\tqp->ops[session->key].gmac_init(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx,\n+\t\t\t\tiv_ptr,\n+\t\t\t\tsession->iv.length);\n+\n+\t\tqp->ops[session->key].gmac_update(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx, src,\n+\t\t\t\t(uint64_t)part_len);\n+\t\ttotal_len = data_length - part_len;\n+\n+\t\twhile (total_len) {\n+\t\t\tm_src = m_src->next;\n+\n+\t\t\tRTE_ASSERT(m_src != NULL);\n+\n+\t\t\tsrc = rte_pktmbuf_mtod(m_src, uint8_t *);\n+\t\t\tpart_len = (m_src->data_len < total_len) ?\n+\t\t\t\t\tm_src->data_len : total_len;\n+\n+\t\t\tqp->ops[session->key].gmac_update(&session->gdata_key,\n+\t\t\t\t\t&qp->gdata_ctx, src,\n+\t\t\t\t\t(uint64_t)part_len);\n+\t\t\ttotal_len -= part_len;\n+\t\t}\n+\n+\t\ttag = qp->temp_digest;\n+\n+\t\tqp->ops[session->key].gmac_finalize(&session->gdata_key,\n+\t\t\t\t&qp->gdata_ctx,\n+\t\t\t\ttag,\n+\t\t\t\tsession->gen_digest_length);\n+\t}\n+#else\n \t} else if (session->op == AESNI_GMAC_OP_GENERATE) {\n \t\tqp->ops[session->key].init(&session->gdata_key,\n \t\t\t\t&qp->gdata_ctx,\n@@ -381,6 +451,7 @@ process_gcm_crypto_op(struct aesni_gcm_qp *qp, struct rte_crypto_op *op,\n \t\t\t\ttag,\n \t\t\t\tsession->gen_digest_length);\n \t}\n+#endif\n \n \treturn 0;\n }\n@@ -769,7 +840,7 @@ aesni_gcm_create(const char *name,\n \t\tinit_mb_mgr_avx2(mb_mgr);\n \t\tbreak;\n \tcase RTE_AESNI_GCM_AVX512:\n-\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX2;\n+\t\tdev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;\n \t\tinit_mb_mgr_avx512(mb_mgr);\n \t\tbreak;\n \tdefault:\n@@ -791,6 +862,11 @@ aesni_gcm_create(const char *name,\n \tinternals->ops[GCM_KEY_128].update_dec = mb_mgr->gcm128_dec_update;\n \tinternals->ops[GCM_KEY_128].finalize_enc = mb_mgr->gcm128_enc_finalize;\n \tinternals->ops[GCM_KEY_128].finalize_dec = mb_mgr->gcm128_dec_finalize;\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\tinternals->ops[GCM_KEY_128].gmac_init = mb_mgr->gmac128_init;\n+\tinternals->ops[GCM_KEY_128].gmac_update = mb_mgr->gmac128_update;\n+\tinternals->ops[GCM_KEY_128].gmac_finalize = mb_mgr->gmac128_finalize;\n+#endif\n \n \tinternals->ops[GCM_KEY_192].enc = mb_mgr->gcm192_enc;\n \tinternals->ops[GCM_KEY_192].dec = mb_mgr->gcm192_dec;\n@@ -800,6 +876,11 @@ aesni_gcm_create(const char *name,\n \tinternals->ops[GCM_KEY_192].update_dec = mb_mgr->gcm192_dec_update;\n \tinternals->ops[GCM_KEY_192].finalize_enc = mb_mgr->gcm192_enc_finalize;\n \tinternals->ops[GCM_KEY_192].finalize_dec = mb_mgr->gcm192_dec_finalize;\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\tinternals->ops[GCM_KEY_192].gmac_init = mb_mgr->gmac192_init;\n+\tinternals->ops[GCM_KEY_192].gmac_update = mb_mgr->gmac192_update;\n+\tinternals->ops[GCM_KEY_192].gmac_finalize = mb_mgr->gmac192_finalize;\n+#endif\n \n \tinternals->ops[GCM_KEY_256].enc = mb_mgr->gcm256_enc;\n \tinternals->ops[GCM_KEY_256].dec = mb_mgr->gcm256_dec;\n@@ -809,6 +890,11 @@ aesni_gcm_create(const char *name,\n \tinternals->ops[GCM_KEY_256].update_dec = mb_mgr->gcm256_dec_update;\n \tinternals->ops[GCM_KEY_256].finalize_enc = mb_mgr->gcm256_enc_finalize;\n \tinternals->ops[GCM_KEY_256].finalize_dec = mb_mgr->gcm256_dec_finalize;\n+#if IMB_VERSION(0, 54, 0) < IMB_VERSION_NUM\n+\tinternals->ops[GCM_KEY_256].gmac_init = mb_mgr->gmac256_init;\n+\tinternals->ops[GCM_KEY_256].gmac_update = mb_mgr->gmac256_update;\n+\tinternals->ops[GCM_KEY_256].gmac_finalize = mb_mgr->gmac256_finalize;\n+#endif\n \n \tinternals->max_nb_queue_pairs = init_params->max_nb_queue_pairs;\n \n", "prefixes": [ "v2", "1/2" ] }