Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78222/?format=api
{ "id": 78222, "url": "https://patches.dpdk.org/api/patches/78222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200922012338.11277-3-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922012338.11277-3-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922012338.11277-3-stevex.yang@intel.com", "date": "2020-09-22T01:23:35", "name": "[v2,2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a883ccef74b689ea3f20cb156bd2a9c0493715c9", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200922012338.11277-3-stevex.yang@intel.com/mbox/", "series": [ { "id": 12387, "url": "https://patches.dpdk.org/api/series/12387/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12387", "date": "2020-09-22T01:23:33", "name": "fix default max mtu size when device configured", "version": 2, "mbox": "https://patches.dpdk.org/series/12387/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78222/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 139B4A04DE;\n\tTue, 22 Sep 2020 03:43:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 564061DA66;\n\tTue, 22 Sep 2020 03:42:59 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 50A5D1D95A\n for <dev@dpdk.org>; Tue, 22 Sep 2020 03:42:55 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Sep 2020 18:42:54 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga002.jf.intel.com with ESMTP; 21 Sep 2020 18:42:52 -0700" ], "IronPort-SDR": [ "\n dZLgem72O5s+AESUV6rTH7ac2/9BsKJh2WHibUrna6ceos8b5TCGEISybOkExeCIJ0RkxCfAck\n UsbTzROD24lQ==", "\n 7R0UJ6vzp4r8momQvl1klHfIwrOPG2K2hR1OqBIjRXNCl3oIjULzlZ3DkmuIGtZDhcQRrAdoZ5\n eSUbhYUtEmcg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9751\"; a=\"148265189\"", "E=Sophos;i=\"5.77,288,1596524400\"; d=\"scan'208\";a=\"148265189\"", "E=Sophos;i=\"5.77,288,1596524400\"; d=\"scan'208\";a=\"322045718\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wei.zhao1@intel.com, jia.guo@intel.com, qiming.yang@intel.com,\n qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com,\n konstantin.ananyev@intel.com, SteveX Yang <stevex.yang@intel.com>", "Date": "Tue, 22 Sep 2020 01:23:35 +0000", "Message-Id": "<20200922012338.11277-3-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200922012338.11277-1-stevex.yang@intel.com>", "References": "<20200916055212.25019-1-stevex.yang@intel.com>\n <20200922012338.11277-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/5] net/igc: fix max mtu size packets with\n\tvlan tag cannot be received by default", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "testpmd will initialize default max packet length to 1518 which doesn't\ninclude vlan tag size in ether overheader. Once, send the max mtu length\npacket with vlan tag, the max packet length will exceed 1518 that will\ncause packets dropped directly from NIC hw side.\n\nigc can support single vlan tag that need more 4 bytes for max packet size,\nso, configures the correct max packet size in dev_config ops.\n\nFixes: a5aeb2b9e225 (\"net/igc: support Rx and Tx\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/igc/igc_ethdev.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 810568bc5..36ef325a4 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -341,7 +341,12 @@ eth_igc_configure(struct rte_eth_dev *dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tret = igc_check_mq_mode(dev);\n+\t/* Considering vlan tag packet, max frame size should be MTU and\n+\t * corresponding ether overhead.\n+\t */\n+\teth_igc_mtu_set(dev, dev->data->mtu);\n+\n+\tret = igc_check_mq_mode(dev);\n \tif (ret != 0)\n \t\treturn ret;\n \n", "prefixes": [ "v2", "2/5" ] }