Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78077/?format=api
{ "id": 78077, "url": "https://patches.dpdk.org/api/patches/78077/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200918084924.31784-2-mohammed@hawari.fr/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200918084924.31784-2-mohammed@hawari.fr>", "list_archive_url": "https://inbox.dpdk.org/dev/20200918084924.31784-2-mohammed@hawari.fr", "date": "2020-09-18T08:49:23", "name": "[1/1] build: allow disabling libs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ec5cdd0e6c6438389fbaa42e83c7c76e611d4217", "submitter": { "id": 1985, "url": "https://patches.dpdk.org/api/people/1985/?format=api", "name": "Mohammed Hawari", "email": "mohammed@hawari.fr" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200918084924.31784-2-mohammed@hawari.fr/mbox/", "series": [ { "id": 12338, "url": "https://patches.dpdk.org/api/series/12338/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12338", "date": "2020-09-18T08:49:22", "name": "build: allow disabling libs", "version": 1, "mbox": "https://patches.dpdk.org/series/12338/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78077/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78077/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 21299A04C8;\n\tFri, 18 Sep 2020 10:49:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 635191D93F;\n\tFri, 18 Sep 2020 10:49:34 +0200 (CEST)", "from aer-iport-2.cisco.com (aer-iport-2.cisco.com [173.38.203.52])\n by dpdk.org (Postfix) with ESMTP id 8E00B1D93E\n for <dev@dpdk.org>; Fri, 18 Sep 2020 10:49:33 +0200 (CEST)", "from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com)\n ([173.38.203.22])\n by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 18 Sep 2020 08:49:30 +0000", "from MHAWARI-M-82K5.cisco.com ([10.61.170.176])\n (authenticated bits=0)\n by aer-core-2.cisco.com (8.15.2/8.15.2) with ESMTPSA id 08I8nPlg027565\n (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n Fri, 18 Sep 2020 08:49:30 GMT" ], "X-IronPort-Anti-Spam-Filtered": "true", "X-IronPort-Anti-Spam-Result": "\n A0DkBACQc2Rf/xbLJq1fhXJVASASLI07pFoLAQEBDQEBGxQEAQGESwKCKiU4EwIDAQELAQEFAQEBAgEGBG2FXAyFcwYyAUYQUVcGE4MmAYJ8txaFU4NJgUKBOIguhRmCAIRfhASGMASaUJxcgVqBF4ERh2WRRw8hgRGDIpxPsnYCBAsCFYFrI4FXMxoIHxE7gmkJRxkNkTKLNj8DMDcCBgoBAQMJjBmCRgEB", "X-IronPort-AV": "E=Sophos;i=\"5.77,274,1596499200\"; d=\"scan'208\";a=\"29728453\"", "From": "Mohammed Hawari <mohammed@hawari.fr>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 18 Sep 2020 10:49:23 +0200", "Message-Id": "<20200918084924.31784-2-mohammed@hawari.fr>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200918084924.31784-1-mohammed@hawari.fr>", "References": "<20200918084924.31784-1-mohammed@hawari.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authenticated-User": "mhawari", "X-Outbound-SMTP-Client": "10.61.170.176, [10.61.170.176]", "X-Outbound-Node": "aer-core-2.cisco.com", "Subject": "[dpdk-dev] [PATCH 1/1] build: allow disabling libs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Similarly to the disable_drivers option, the disable_libs option is\nintroduced. This allows to selectively disable the build of elements\nin libs to speed-up the build process.\n\nSigned-off-by: Mohammed Hawari <mohammed@hawari.fr>\n---\n app/meson.build | 12 +++++++++++-\n lib/meson.build | 7 +++++++\n meson.build | 9 +++++++++\n meson_options.txt | 2 ++\n 4 files changed, 29 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/meson.build b/app/meson.build\nindex eb74f215a..93affefa3 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -42,7 +42,17 @@ foreach app:apps\n \n \tsubdir(name)\n \n-\tif build\n+\tforeach d:deps\n+\t\tif dpdk_libs_disabled.contains(d)\n+\t\t\tbuild = false\n+\t\t\treason = 'missing dependency, \"@0@\" '.format (d)\n+\t\tendif\n+\tendforeach\n+\n+\tif not build\n+\t\tdpdk_apps_disabled += name\n+\t\tset_variable(name.underscorify() + '_disable_reason', reason)\n+\telse\n \t\tdep_objs = []\n \t\tforeach d:deps\n \t\t\tdep_objs += get_variable(get_option('default_library')\ndiff --git a/lib/meson.build b/lib/meson.build\nindex d8b358e5f..c8507fda1 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -45,6 +45,8 @@ if is_windows\n \t] # only supported libraries for windows\n endif\n \n+disabled_libs = get_option('disable_libs').split(',')\n+\n default_cflags = machine_args\n default_cflags += ['-DALLOW_EXPERIMENTAL_API']\n default_cflags += ['-DALLOW_INTERNAL_API']\n@@ -79,6 +81,11 @@ foreach l:libraries\n \tdir_name = 'librte_' + l\n \tsubdir(dir_name)\n \n+\tif disabled_libs.contains(l)\n+\t\tbuild = false\n+\t\treason = 'Explicitly disabled via build config'\n+\tendif\n+\n \tif build\n \t\tshared_deps = ext_deps\n \t\tstatic_deps = ext_deps\ndiff --git a/meson.build b/meson.build\nindex 61d9a4f5f..cf04f0e0e 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -21,6 +21,7 @@ dpdk_drivers = []\n dpdk_extra_ldflags = []\n dpdk_libs_disabled = []\n dpdk_drvs_disabled = []\n+dpdk_apps_disabled = []\n abi_version_file = files('ABI_VERSION')\n \n if host_machine.cpu_family().startswith('x86')\n@@ -106,6 +107,14 @@ foreach class:dpdk_driver_classes\n endforeach\n message(output_message + '\\n')\n \n+output_message = '\\n===============\\nApplications Disabled\\n===============\\n'\n+foreach app:dpdk_apps_disabled\n+\treason = get_variable(app.underscorify() + '_disable_reason')\n+\toutput_message += app + ':\\t' + reason + '\\n\\t'\n+endforeach\n+\n+message(output_message + '\\n')\n+\n output_message = '\\n=================\\nContent Skipped\\n=================\\n'\n output_message += '\\nlibs:\\n\\t'\n foreach lib:dpdk_libs_disabled\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9bf18ab6b..d1aa46b8d 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -4,6 +4,8 @@ option('armv8_crypto_dir', type: 'string', value: '',\n \tdescription: 'path to the armv8_crypto library installation directory')\n option('disable_drivers', type: 'string', value: '',\n \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n+option('disable_libs', type: 'string', value: '',\n+\tdescription: 'Comma-separated list of libs to explicitly disable.')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n \tdescription: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n option('enable_docs', type: 'boolean', value: false,\n", "prefixes": [ "1/1" ] }