Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7746/?format=api
{ "id": 7746, "url": "https://patches.dpdk.org/api/patches/7746/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445268976-27491-3-git-send-email-ehkinzie@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445268976-27491-3-git-send-email-ehkinzie@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445268976-27491-3-git-send-email-ehkinzie@gmail.com", "date": "2015-10-19T15:36:14", "name": "[dpdk-dev,v6,2/4] bond mode 4: do not ignore multicast", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa7153883268a3671c32154b05400796367c42ee", "submitter": { "id": 208, "url": "https://patches.dpdk.org/api/people/208/?format=api", "name": "Eric Kinzie", "email": "ehkinzie@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445268976-27491-3-git-send-email-ehkinzie@gmail.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7746/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7746/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 569EF8E82;\n\tMon, 19 Oct 2015 17:37:02 +0200 (CEST)", "from mail-pa0-f50.google.com (mail-pa0-f50.google.com\n\t[209.85.220.50]) by dpdk.org (Postfix) with ESMTP id A1E148E82\n\tfor <dev@dpdk.org>; Mon, 19 Oct 2015 17:37:00 +0200 (CEST)", "by pacfv9 with SMTP id fv9so98784882pac.3\n\tfor <dev@dpdk.org>; Mon, 19 Oct 2015 08:37:00 -0700 (PDT)", "from buildhost2.vyatta.com. ([144.49.132.22])\n\tby smtp.gmail.com with ESMTPSA id\n\tez2sm37002362pbb.5.2015.10.19.08.36.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 19 Oct 2015 08:36:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Z6yYmSGaFigf2qJGeEIwSoeEwwtdIYq3A+DJm/Z23IQ=;\n\tb=i4cJ3FkmK+z6PTqm2Cbj4vU8RtAd3Sd9DzBSY9F/yJFkrdf0E6dnaI4eySr+quMDPa\n\tyP/BYQJzoNv1yQud/da976XQz3VROw9JN1bE8G2ASZ1W+808jmrdwOtvE3jGE0+8qCaC\n\tkzNGOlje02lq+CszVqKpQUGvdEoT12+f1YmxPR8rnqT9ozJsiueDPy0XjtcahUuq3uLR\n\tIRm6TbWkWf3SjL6rOvz7OhXs5Ku1SN/l2XxcLjR+rJEkApN6dOWcYMmkSbcmE8PiR1lR\n\tWVTZo2HVbI2KcNkbohldmWJT5J8OP+aqj/hY+mtWNbvtPbw7kVr2CWBcWziI9UGzdnc+\n\tyQTQ==", "X-Received": "by 10.68.69.108 with SMTP id d12mr34591905pbu.137.1445269020100; \n\tMon, 19 Oct 2015 08:37:00 -0700 (PDT)", "From": "Eric Kinzie <ehkinzie@gmail.com>", "To": "dev@dpdk.org", "Date": "Mon, 19 Oct 2015 08:36:14 -0700", "Message-Id": "<1445268976-27491-3-git-send-email-ehkinzie@gmail.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1445268976-27491-1-git-send-email-ehkinzie@gmail.com>", "References": "<1445268976-27491-1-git-send-email-ehkinzie@gmail.com>", "Cc": "Eric Kinzie <ekinzie@brocade.com>", "Subject": "[dpdk-dev] [PATCH v6 2/4] bond mode 4: do not ignore multicast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Eric Kinzie <ekinzie@brocade.com>\n\nThe bonding PMD in mode 4 puts all enslaved interfaces into promiscuous\nmode in order to receive LACPDUs and must filter unwanted packets\nafter the traffic has been \"collected\". Allow broadcast and multicast\nthrough so that ARP and IPv6 neighbor discovery continue to work.\n\nFixes: 46fb43683679 (\"bond: add mode 4\")\n\nSigned-off-by: Eric Kinzie <ehkinzie@gmail.com>\n---\n app/test/test_link_bonding_mode4.c | 7 +++++--\n drivers/net/bonding/rte_eth_bond_pmd.c | 1 +\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex 460539d..d785393 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -749,8 +749,11 @@ test_mode4_rx(void)\n \trte_eth_macaddr_get(test_params.bonded_port_id, &bonded_mac);\n \tether_addr_copy(&bonded_mac, &dst_mac);\n \n-\t/* Assert that dst address is not bonding address */\n-\tdst_mac.addr_bytes[0]++;\n+\t/* Assert that dst address is not bonding address. Do not set the\n+\t * least significant bit of the zero byte as this would create a\n+\t * multicast address.\n+\t */\n+\tdst_mac.addr_bytes[0] += 2;\n \n \t/* First try with promiscuous mode enabled.\n \t * Add 2 packets to each slave. First with bonding MAC address, second with\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 5cc6372..733022b 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -170,6 +170,7 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,\n \t\t\t * mode and packet address does not match. */\n \t\t\tif (unlikely(hdr->ether_type == ether_type_slow_be ||\n \t\t\t\t!collecting || (!promisc &&\n+\t\t\t\t\t!is_multicast_ether_addr(&hdr->d_addr) &&\n \t\t\t\t\t!is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {\n \n \t\t\t\tif (hdr->ether_type == ether_type_slow_be) {\n", "prefixes": [ "dpdk-dev", "v6", "2/4" ] }