Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7741/?format=api
{ "id": 7741, "url": "https://patches.dpdk.org/api/patches/7741/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445257253-3673-1-git-send-email-maryam.tahhan@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445257253-3673-1-git-send-email-maryam.tahhan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445257253-3673-1-git-send-email-maryam.tahhan@intel.com", "date": "2015-10-19T12:20:53", "name": "[dpdk-dev,v2,1/1] ethdev: distinguish between drop and error stats", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a73c6e1daf50b25e781827dcddf79c2e6f788863", "submitter": { "id": 259, "url": "https://patches.dpdk.org/api/people/259/?format=api", "name": "Tahhan, Maryam", "email": "maryam.tahhan@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445257253-3673-1-git-send-email-maryam.tahhan@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7741/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8AC588E7E;\n\tMon, 19 Oct 2015 14:21:24 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 265AE8E7D\n\tfor <dev@dpdk.org>; Mon, 19 Oct 2015 14:21:22 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 19 Oct 2015 05:20:55 -0700", "from sie-lab-212-170.ir.intel.com (HELO\n\tsilpixa00378251.ir.intel.com) ([10.237.212.170])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Oct 2015 05:20:54 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,701,1437462000\"; d=\"scan'208\";a=\"814322924\"", "From": "Maryam Tahhan <maryam.tahhan@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 19 Oct 2015 13:20:53 +0100", "Message-Id": "<1445257253-3673-1-git-send-email-maryam.tahhan@intel.com>", "X-Mailer": "git-send-email 2.4.3", "Subject": "[dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and\n\terror stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make a distniction between dropped packets and error statistics to allow\na higher level fault management entity to interact with DPDK and take\nappropriate measures when errors are detected. It will also provide\nvaluable information for any applications that collects/extracts DPDK\nstats, such applications include Open vSwitch.\nAfter this patch the distinction is:\nierrors = Total number of packets dropped by hardware (malformed\npackets, ...) Where the # of drops can ONLY be <= the packets received\n(without overlap between registers).\nipkterrors = Total number of erroneous received packets. Where the #\nof errors can be >= the packets received (without overlap between\nregisters), this is because there may be multiple errors associated with\na packet.\n\nv2:\n - Added detailed descriptions for ierrors and ipkterrors.\n\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>\n---\n lib/librte_ether/rte_ethdev.h | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 8a8c82b..e27ba31 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -200,8 +200,18 @@ struct rte_eth_stats {\n \t/**< Deprecated; Total of RX packets with CRC error. */\n \tuint64_t ibadlen;\n \t/**< Deprecated; Total of RX packets with bad length. */\n-\tuint64_t ierrors; /**< Total number of erroneous received packets. */\n+\tuint64_t ierrors;\n+\t/**< Total number of packets dropped by hardware (malformed packets...)\n+\t * Where the # of drops can ONLY be <= the packets received (without\n+\t * overlap between registers).\n+\t */\n \tuint64_t oerrors; /**< Total number of failed transmitted packets. */\n+\tuint64_t ipkterrors;\n+\t/**< Total number of erroneous received packets. Where the number of\n+\t * errors can be >= the packets received (without overlap between\n+\t * registers), this is because there may be multiple errors associated with\n+\t * a packet.\n+\t */\n \tuint64_t imcasts;\n \t/**< Deprecated; Total number of multicast received packets. */\n \tuint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */\n", "prefixes": [ "dpdk-dev", "v2", "1/1" ] }