Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76296,
    "url": "https://patches.dpdk.org/api/patches/76296/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1599035699-358487-1-git-send-email-matan@nvidia.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1599035699-358487-1-git-send-email-matan@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1599035699-358487-1-git-send-email-matan@nvidia.com",
    "date": "2020-09-02T08:34:59",
    "name": "vdpa/mlx5: fix completion queue assertion",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6fba4fa6f13dacf6debb69c54f406b1c55448267",
    "submitter": {
        "id": 1911,
        "url": "https://patches.dpdk.org/api/people/1911/?format=api",
        "name": "Matan Azrad",
        "email": "matan@nvidia.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1599035699-358487-1-git-send-email-matan@nvidia.com/mbox/",
    "series": [
        {
            "id": 11894,
            "url": "https://patches.dpdk.org/api/series/11894/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11894",
            "date": "2020-09-02T08:34:59",
            "name": "vdpa/mlx5: fix completion queue assertion",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/11894/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/76296/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/76296/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8A18A04B7;\n\tWed,  2 Sep 2020 10:35:18 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E09831C0AF;\n\tWed,  2 Sep 2020 10:35:17 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id F00511C07E\n for <dev@dpdk.org>; Wed,  2 Sep 2020 10:35:15 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@nvidia.com) with SMTP; 2 Sep 2020 11:35:12 +0300",
            "from nvidia.com (pegasus25.mtr.labs.mlnx [10.210.16.10])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0828ZB3w001936;\n Wed, 2 Sep 2020 11:35:11 +0300"
        ],
        "From": "Matan Azrad <matan@nvidia.com>",
        "To": "Maxime Coquelin <maxime.coquelin@redhat.com>",
        "Cc": "dev@dpdk.org, stable@dpdk.org",
        "Date": "Wed,  2 Sep 2020 08:34:59 +0000",
        "Message-Id": "<1599035699-358487-1-git-send-email-matan@nvidia.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue assertion",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The CQ configuration enables the collapse feature in HW what cause HW to\nwrite all the completions in the first CQE.\nWhen this feature is enabled the HW doesn't switch the owner bit when it\nstarts a new cycle of the CQ, not like working without the collapse\nfeature.\n\nThe current SW CQ polling wrongly added an assertion to validate the\nowner bit switch what causes a panic in debug mode.\n\nRemove the aforementioned assertion.\n\nFixes: c5f714e50b0e (\"vdpa/mlx5: optimize completion queue poll\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@nvidia.com>\nAcked-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 --\n 1 file changed, 2 deletions(-)",
    "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\nindex 5a2d4fb..742ee62 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n@@ -205,8 +205,6 @@\n \tcomp = (cur_wqe_counter + 1u - next_wqe_counter) & cq_mask;\n \tif (comp) {\n \t\tcq->cq_ci += comp;\n-\t\tMLX5_ASSERT(!!(cq->cq_ci & cq_size) ==\n-\t\t\t    MLX5_CQE_OWNER(last_word.op_own));\n \t\tMLX5_ASSERT(MLX5_CQE_OPCODE(last_word.op_own) !=\n \t\t\t    MLX5_CQE_INVALID);\n \t\tif (unlikely(!(MLX5_CQE_OPCODE(last_word.op_own) ==\n",
    "prefixes": []
}