Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76095/?format=api
{ "id": 76095, "url": "https://patches.dpdk.org/api/patches/76095/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200827161130.14978-2-ed.czeck@atomicrules.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827161130.14978-2-ed.czeck@atomicrules.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827161130.14978-2-ed.czeck@atomicrules.com", "date": "2020-08-27T16:11:30", "name": "[2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a4436eeddb705b7001f665de7d7e0ca214bda0b6", "submitter": { "id": 699, "url": "https://patches.dpdk.org/api/people/699/?format=api", "name": "Ed Czeck", "email": "ed.czeck@atomicrules.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200827161130.14978-2-ed.czeck@atomicrules.com/mbox/", "series": [ { "id": 11830, "url": "https://patches.dpdk.org/api/series/11830/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11830", "date": "2020-08-27T16:11:29", "name": "[1/2] net/ark: remove compile time log macros in favor of run time log control", "version": 1, "mbox": "https://patches.dpdk.org/series/11830/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/76095/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/76095/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E6D6AA04B1;\n\tThu, 27 Aug 2020 18:11:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF4FD1C00D;\n\tThu, 27 Aug 2020 18:11:45 +0200 (CEST)", "from mail-qt1-f196.google.com (mail-qt1-f196.google.com\n [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 3BED61BECB\n for <dev@dpdk.org>; Thu, 27 Aug 2020 18:11:43 +0200 (CEST)", "by mail-qt1-f196.google.com with SMTP id y65so4937114qtd.2\n for <dev@dpdk.org>; Thu, 27 Aug 2020 09:11:43 -0700 (PDT)", "from z390.czeck.local (pool-72-74-133-40.bstnma.fios.verizon.net.\n [72.74.133.40])\n by smtp.gmail.com with ESMTPSA id s4sm2132497qtn.34.2020.08.27.09.11.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 27 Aug 2020 09:11:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=atomicrules-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=MwabYx3N5Ho/gDL0ScG3RSTBwOk1I9/LJH1uB+Cj328=;\n b=DO7Ype4ada7bUD6W31oXT7EeCSFvJUFHkzz55glId9kGaFJuuT5ETjGvUbMEA5eMqq\n jgYGY/cA/4t7tm1GFMOj71at5bK7buhdi7JQtKY7YerUZ4uLWeMYtm0pksa0Av6BU+WQ\n yBA0cOcbzhytGGHp2b1E1pT+knzHIW3ZuKvw8Shc9iemZrCmN0w9wikmGE4Tad35Komz\n SMGKAqrsc1RHLNKGfFxsIE8HZnPJSfE6jrgAAgr9yYtddVbTmZmF6YDGP5q39EdtwN3x\n nIBhpIHe9vjsAOrjkktC0kNdqiO2MWminYseKY5qytsSDk6KjswG5d94f2W8z4GsBdzG\n Hwsw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=MwabYx3N5Ho/gDL0ScG3RSTBwOk1I9/LJH1uB+Cj328=;\n b=QJspezfxwyq8LacDebNf/cb1oLD90tvdZRhDKOnz+RXbdNf+pY+dlqn+ZOhwjzn9/f\n c3Tj/CrYlnYgMb2s1XINJL/OOVmnI+iHyXl5y7W+K32ameSrIjnCJNuTGisjFdN4p5YR\n hK/FH3yK6VdjROK/hbA6vVO88yCguuWoq15K1YITRi98/ugxBiaaQPJhaeyfr8Yn+7cm\n vW3/csxAF49FJ4zpG69xkbQV9f4GqElgNI3PXmmMi08b35LFGuFCPXWu6MbC5ov0Qiaw\n XuowGAf+h6oWXf7HVVU0Xys6FkD2ejqllOy6O6GLZz3fgjlBwA0RiTVekWGTHAi2Bbum\n 56Tg==", "X-Gm-Message-State": "AOAM532ZtmEJRnSIKJVFCdtSC/vIlfo/kmLFVG+gT3kHRP//5sszKRyq\n uJ8kSSfFfAYvucSnuQIZd0WBIeL2R/I7ag==", "X-Google-Smtp-Source": "\n ABdhPJx2Knofa+x3t9RODWtSgj58OKeihVsGn3fwUjjXEIl257X/BZBschyqvAQ3+tsbdXMr2lM1bQ==", "X-Received": "by 2002:ac8:7094:: with SMTP id y20mr19564617qto.52.1598544702167;\n Thu, 27 Aug 2020 09:11:42 -0700 (PDT)", "From": "Ed Czeck <ed.czeck@atomicrules.com>", "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com,\n\tbruce.richardson@intel.com", "Cc": "shepard.siegel@atomicrules.com, john.miller@atomicrules.com,\n Ed Czeck <ed.czeck@atomicrules.com>", "Date": "Thu, 27 Aug 2020 12:11:30 -0400", "Message-Id": "<20200827161130.14978-2-ed.czeck@atomicrules.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200827161130.14978-1-ed.czeck@atomicrules.com>", "References": "<20200819153539.32698-1-ed.czeck@atomicrules.com>\n <20200827161130.14978-1-ed.czeck@atomicrules.com>", "Subject": "[dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX\n\tconfiguration macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN\nwith a default value of 0.\nUpdate documentation as needed.\n\nSigned-off-by: Ed Czeck <ed.czeck@atomicrules.com>\n---\n doc/guides/nics/ark.rst | 16 ++++++++----\n drivers/net/ark/ark_ethdev_tx.c | 43 ++++++++++++++++++---------------\n drivers/net/ark/ark_logs.h | 8 ------\n 3 files changed, 35 insertions(+), 32 deletions(-)", "diff": "diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst\nindex c3ffcbbc2..c7ed4095f 100644\n--- a/doc/guides/nics/ark.rst\n+++ b/doc/guides/nics/ark.rst\n@@ -126,11 +126,10 @@ Configuration Information\n \n The following configuration options are available for the ARK PMD:\n \n- * **CONFIG_RTE_LIBRTE_ARK_PMD** (default y): Enables or disables inclusion\n- of the ARK PMD driver in the DPDK compilation.\n-\n- * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX\n- packets are padded to 60 bytes to support downstream MACS.\n+ * **RTE_LIBRTE_ARK_MIN_TX_PKTLEN** (default 0): Sets the minimum\n+ packet length for tx packets to the FPGA. Packets less than this\n+ length are padded to meet the requirement. This allows padding to\n+ be offloaded or remain in host software.\n \n \n Building DPDK\n@@ -144,6 +143,13 @@ By default the ARK PMD library will be built into the DPDK library.\n For configuring and using UIO and VFIO frameworks, please also refer :ref:`the\n documentation that comes with DPDK suite <linux_gsg>`.\n \n+To build with a non-zero minimum tx packet length, set the above macro in your\n+CFLAGS environment prior to the meson build step. I.e.,\n+\n+ export CFLAGS=\"-DRTE_LIBRTE_ARK_MIN_TX_PKTLEN=60\"\n+ meson build\n+\n+\n Supported ARK RTL PCIe Instances\n --------------------------------\n \ndiff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c\nindex 72624deb3..52ce2ed41 100644\n--- a/drivers/net/ark/ark_ethdev_tx.c\n+++ b/drivers/net/ark/ark_ethdev_tx.c\n@@ -14,6 +14,11 @@\n #define ARK_TX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_TX_META_SIZE)\n #define ARK_TX_MAX_NOCHAIN (RTE_MBUF_DEFAULT_DATAROOM)\n \n+#ifndef RTE_LIBRTE_ARK_MIN_TX_PKTLEN\n+#define ARK_MIN_TX_PKTLEN 0\n+#else\n+#define ARK_MIN_TX_PKTLEN RTE_LIBRTE_ARK_MIN_TX_PKTLEN\n+#endif\n \n /* ************************************************************************* */\n struct ark_tx_queue {\n@@ -104,28 +109,28 @@ eth_ark_xmit_pkts(void *vtxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t ++nb) {\n \t\tmbuf = tx_pkts[nb];\n \n-\t\tif (ARK_TX_PAD_TO_60) {\n-\t\t\tif (unlikely(rte_pktmbuf_pkt_len(mbuf) < 60)) {\n-\t\t\t\t/* this packet even if it is small can be split,\n-\t\t\t\t * be sure to add to the end mbuf\n+#if ARK_MIN_TX_PKTLEN != 0\n+\t\tif (unlikely(rte_pktmbuf_pkt_len(mbuf) < ARK_MIN_TX_PKTLEN)) {\n+\t\t\t/* this packet even if it is small can be split,\n+\t\t\t * be sure to add to the end mbuf\n+\t\t\t */\n+\t\t\tuint16_t to_add = ARK_MIN_TX_PKTLEN -\n+\t\t\t\trte_pktmbuf_pkt_len(mbuf);\n+\t\t\tchar *appended =\n+\t\t\t\trte_pktmbuf_append(mbuf, to_add);\n+\n+\t\t\tif (appended == 0) {\n+\t\t\t\t/* This packet is in error,\n+\t\t\t\t * we cannot send it so just\n+\t\t\t\t * count it and delete it.\n \t\t\t\t */\n-\t\t\t\tuint16_t to_add =\n-\t\t\t\t\t60 - rte_pktmbuf_pkt_len(mbuf);\n-\t\t\t\tchar *appended =\n-\t\t\t\t\trte_pktmbuf_append(mbuf, to_add);\n-\n-\t\t\t\tif (appended == 0) {\n-\t\t\t\t\t/* This packet is in error,\n-\t\t\t\t\t * we cannot send it so just\n-\t\t\t\t\t * count it and delete it.\n-\t\t\t\t\t */\n-\t\t\t\t\tqueue->tx_errors += 1;\n-\t\t\t\t\trte_pktmbuf_free(mbuf);\n-\t\t\t\t\tcontinue;\n-\t\t\t\t}\n-\t\t\t\tmemset(appended, 0, to_add);\n+\t\t\t\tqueue->tx_errors += 1;\n+\t\t\t\trte_pktmbuf_free(mbuf);\n+\t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tmemset(appended, 0, to_add);\n \t\t}\n+#endif\n \n \t\tif (unlikely(mbuf->nb_segs != 1)) {\n \t\t\tstat = eth_ark_tx_jumbo(queue, mbuf);\ndiff --git a/drivers/net/ark/ark_logs.h b/drivers/net/ark/ark_logs.h\nindex c3d7e7d39..ca46d86c9 100644\n--- a/drivers/net/ark/ark_logs.h\n+++ b/drivers/net/ark/ark_logs.h\n@@ -8,14 +8,6 @@\n #include <inttypes.h>\n #include <rte_log.h>\n \n-\n-/* Configuration option to pad TX packets to 60 bytes */\n-#ifdef RTE_LIBRTE_ARK_PAD_TX\n-#define ARK_TX_PAD_TO_60 1\n-#else\n-#define ARK_TX_PAD_TO_60 0\n-#endif\n-\n /* system camel case definition changed to upper case */\n #define PRIU32 PRIu32\n #define PRIU64 PRIu64\n", "prefixes": [ "2/2" ] }