Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7609/?format=api
{ "id": 7609, "url": "https://patches.dpdk.org/api/patches/7609/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-4-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444874628-5453-4-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444874628-5453-4-git-send-email-wenzhuo.lu@intel.com", "date": "2015-10-15T02:03:16", "name": "[dpdk-dev,v2,03/35] e1000/base: fix issue with link flap on 82579", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8927c682841517ce91438b5b40f0407588ae3dcd", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-4-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7609/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 609A88E8F;\n\tThu, 15 Oct 2015 04:04:05 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 01E0B8D99\n\tfor <dev@dpdk.org>; Thu, 15 Oct 2015 04:04:02 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 14 Oct 2015 19:04:03 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Oct 2015 19:04:01 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9F23xms004281;\n\tThu, 15 Oct 2015 10:03:59 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9F23u0v005508; Thu, 15 Oct 2015 10:03:58 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9F23uaU005504; \n\tThu, 15 Oct 2015 10:03:56 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,683,1437462000\"; d=\"scan'208\";a=\"664611898\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Oct 2015 10:03:16 +0800", "Message-Id": "<1444874628-5453-4-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 03/35] e1000/base: fix issue with link flap on\n\t82579", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Several customers have reported a link flap issue on 82579. The symptoms\nare random and intermittent link losses when 82579 is connected to specific\nswitches. Issue has been root caused as interoperability problem between\nthe NIC and at least some Broadcom PHYs in the Energy Efficient Ethernet\nwake mechanism.\nTo fix the issue, we are disabling the Phase Locked Loop shutdown in 100M\nLow Power Idle. This solution will cause an increase of power in 100M EEE\nlink. It may cost additional 28mW in this specific mode.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_ich8lan.c | 11 +++++++++++\n drivers/net/e1000/base/e1000_ich8lan.h | 2 ++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c\nindex 6d998df..f23d810 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.c\n+++ b/drivers/net/e1000/base/e1000_ich8lan.c\n@@ -935,6 +935,17 @@ s32 e1000_set_eee_pchlan(struct e1000_hw *hw)\n \t\t}\n \t}\n \n+\tif (hw->phy.type == e1000_phy_82579) {\n+\t\tret_val = e1000_read_emi_reg_locked(hw, I82579_LPI_PLL_SHUT,\n+\t\t\t\t\t\t &data);\n+\t\tif (ret_val)\n+\t\t\tgoto release;\n+\n+\t\tdata &= ~I82579_LPI_100_PLL_SHUT;\n+\t\tret_val = e1000_write_emi_reg_locked(hw, I82579_LPI_PLL_SHUT,\n+\t\t\t\t\t\t data);\n+\t}\n+\n \t/* R/Clr IEEE MMD 3.1 bits 11:10 - Tx/Rx LPI Received */\n \tret_val = e1000_read_emi_reg_locked(hw, pcs_status, &data);\n \tif (ret_val)\ndiff --git a/drivers/net/e1000/base/e1000_ich8lan.h b/drivers/net/e1000/base/e1000_ich8lan.h\nindex e9b73df..c690d9e 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.h\n+++ b/drivers/net/e1000/base/e1000_ich8lan.h\n@@ -262,12 +262,14 @@ POSSIBILITY OF SUCH DAMAGE.\n #define I82577_MSE_THRESHOLD\t0x0887 /* 82577 Mean Square Error Threshold */\n #define I82579_MSE_LINK_DOWN\t0x2411 /* MSE count before dropping link */\n #define I82579_RX_CONFIG\t\t0x3412 /* Receive configuration */\n+#define I82579_LPI_PLL_SHUT\t\t0x4412 /* LPI PLL Shut Enable */\n #define I82579_EEE_PCS_STATUS\t\t0x182E\t/* IEEE MMD Register 3.1 >> 8 */\n #define I82579_EEE_CAPABILITY\t\t0x0410 /* IEEE MMD Register 3.20 */\n #define I82579_EEE_ADVERTISEMENT\t0x040E /* IEEE MMD Register 7.60 */\n #define I82579_EEE_LP_ABILITY\t\t0x040F /* IEEE MMD Register 7.61 */\n #define I82579_EEE_100_SUPPORTED\t(1 << 1) /* 100BaseTx EEE */\n #define I82579_EEE_1000_SUPPORTED\t(1 << 2) /* 1000BaseTx EEE */\n+#define I82579_LPI_100_PLL_SHUT\t(1 << 2) /* 100M LPI PLL Shut Enabled */\n #define I217_EEE_PCS_STATUS\t0x9401 /* IEEE MMD Register 3.1 */\n #define I217_EEE_CAPABILITY\t0x8000 /* IEEE MMD Register 3.20 */\n #define I217_EEE_ADVERTISEMENT\t0x8001 /* IEEE MMD Register 7.60 */\n", "prefixes": [ "dpdk-dev", "v2", "03/35" ] }