Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74703/?format=api
{ "id": 74703, "url": "https://patches.dpdk.org/api/patches/74703/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200724024712.10727-1-shougangx.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200724024712.10727-1-shougangx.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724024712.10727-1-shougangx.wang@intel.com", "date": "2020-07-24T02:47:12", "name": "[v4] net/i40e: fix incorrect hash look up table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fc1e0a6d932e8d09770c7ff6eead2273d775f2b", "submitter": { "id": 1418, "url": "https://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200724024712.10727-1-shougangx.wang@intel.com/mbox/", "series": [ { "id": 11262, "url": "https://patches.dpdk.org/api/series/11262/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11262", "date": "2020-07-24T02:47:12", "name": "[v4] net/i40e: fix incorrect hash look up table", "version": 4, "mbox": "https://patches.dpdk.org/series/11262/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74703/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58043A0518;\n\tFri, 24 Jul 2020 05:07:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B0D601D5F9;\n\tFri, 24 Jul 2020 05:06:58 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 394ED1D5F6;\n Fri, 24 Jul 2020 05:06:57 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 20:06:56 -0700", "from intel.sh.intel.com ([10.239.255.20])\n by fmsmga001.fm.intel.com with ESMTP; 23 Jul 2020 20:06:54 -0700" ], "IronPort-SDR": [ "\n uFL8guTEZNOeKPc1W9AZQVaitQmvogaSMPe5ds1AFtJUCDUCmhAAa7beQPo2iz+ZkeMU6FUtIV\n 5xQFWLdJAq6A==", "\n BqHXduolLFJJDLCYcKp6G61TL+Ilxnz0V128YF+MW2k288VfpRq7961EitU3vDmraSONAtFblV\n rT9GyiqKA5nw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"235531077\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"235531077\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"393191220\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Shougang Wang <shougangx.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, jia.guo@intel.com,\n Shougang Wang <shougangx.wang@intel.com>, stable@dpdk.org", "Date": "Fri, 24 Jul 2020 02:47:12 +0000", "Message-Id": "<20200724024712.10727-1-shougangx.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200715063515.9262-1-shougangx.wang@intel.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The hash look up table (LUT) is managed by global register but it is not\ninitialized when RSS is disabled. Once user wants to enable RSS during\nruntime, the LUT will not be initialized.\nThis patch fixes the issue by initializing the LUT whether RSS enabled\nor not.\n\nFixes: feaae285b342 (\"net/i40e: support hash configuration in RSS flow\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shougang Wang <shougangx.wang@intel.com>\n---\nv4:\n-Updated code.\n---\n drivers/net/i40e/i40e_ethdev.c | 15 ++++-----------\n 1 file changed, 4 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 05d5f2861..0a3f5e3c1 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -8985,6 +8985,7 @@ static int\n i40e_pf_config_rss(struct i40e_pf *pf)\n {\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n+\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode;\n \tstruct rte_eth_rss_conf rss_conf;\n \tuint32_t i, lut = 0;\n \tuint16_t j, num;\n@@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n \t}\n \n \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n-\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) {\n+\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 ||\n+\t !(mq_mode & ETH_MQ_RX_RSS_FLAG)) {\n \t\ti40e_pf_disable_rss(pf);\n \t\treturn 0;\n \t}\n@@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev *dev,\n static int\n i40e_pf_config_mq_rx(struct i40e_pf *pf)\n {\n-\tint ret = 0;\n-\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode;\n-\n-\t/* RSS setup */\n-\tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n-\t\tret = i40e_pf_config_rss(pf);\n-\telse\n-\t\ti40e_pf_disable_rss(pf);\n-\n-\treturn ret;\n+\treturn i40e_pf_config_rss(pf);\n }\n \n /* Get the symmetric hash enable configurations per port */\n", "prefixes": [ "v4" ] }