Patch Comment List
List patch comments
GET /api/patches/74692/comments/?format=api&order=-id
[ { "id": 116605, "web_url": "https://patches.dpdk.org/comment/116605/", "msgid": "<CAJFAV8xOHPNbHCpgZ41HdUFLr7V0+4LpFXmceYs7NmuJCeQ=oA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8xOHPNbHCpgZ41HdUFLr7V0+4LpFXmceYs7NmuJCeQ=oA@mail.gmail.com", "date": "2020-07-24T13:27:35", "subject": "Re: [dpdk-dev] [PATCH v8 02/10] drivers: fix indent of directory\n\tlist", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Thu, Jul 23, 2020 at 10:10 PM Parav Pandit <parav@mellanox.com> wrote:\n>\n> From: Thomas Monjalon <thomas@monjalon.net>\n>\n> Define each sub-directory on its own line ended with a comma,\n> and use a simple indent.\n>\n> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> ---\n> drivers/meson.build | 24 +++++++++++++-----------\n> 1 file changed, 13 insertions(+), 11 deletions(-)\n>\n> diff --git a/drivers/meson.build b/drivers/meson.build\n> index e76ebddfa..e2aeba931 100644\n> --- a/drivers/meson.build\n> +++ b/drivers/meson.build\n> @@ -2,17 +2,19 @@\n> # Copyright(c) 2017-2019 Intel Corporation\n>\n> # Defines the order in which the drivers are buit.\n> -dpdk_driver_classes = ['common',\n> - 'bus',\n> - 'mempool', # depends on common and bus.\n> - 'net', # depends on common, bus, mempool\n> - 'raw', # depends on common, bus and net.\n> - 'crypto', # depends on common, bus and mempool (net in future).\n> - 'compress', # depends on common, bus, mempool.\n> - 'regex', # depends on common, bus, regexdev.\n> - 'vdpa', # depends on common, bus and mempool.\n> - 'event', # depends on common, bus, mempool and net.\n> - 'baseband'] # depends on common and bus.\n> +dpdk_driver_classes = [\n> + 'common',\n> + 'bus',\n> + 'mempool', # depends on common and bus.\n> + 'net', # depends on common, bus, mempool\n> + 'raw', # depends on common, bus and net.\n> + 'crypto', # depends on common, bus and mempool (net in future).\n> + 'compress', # depends on common, bus, mempool.\n> + 'regex', # depends on common, bus, regexdev.\n> + 'vdpa', # depends on common, bus and mempool.\n> + 'event', # depends on common, bus, mempool and net.\n> + 'baseband', # depends on common and bus.\n> +]\n>\n> disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),\n> ).stdout().split()\n> --\n> 2.25.4\n>\n\nReviewed-by: David Marchand <david.marchand@redhat.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35F9EA052A;\n\tFri, 24 Jul 2020 15:27:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F090D1C0C0;\n\tFri, 24 Jul 2020 15:27:50 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81])\n by dpdk.org (Postfix) with ESMTP id 92DEA1C0BD\n for <dev@dpdk.org>; Fri, 24 Jul 2020 15:27:49 +0200 (CEST)", "from mail-vk1-f198.google.com (mail-vk1-f198.google.com\n [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-13-XYq5tSmsNHCxNxQ5qMCzwg-1; Fri, 24 Jul 2020 09:27:47 -0400", "by mail-vk1-f198.google.com with SMTP id u203so2908122vkb.9\n for <dev@dpdk.org>; Fri, 24 Jul 2020 06:27:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1595597268;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=FRQlmN8tqI8tCm30mS6G/bZpn2jie5+VxE05EqiLqbQ=;\n b=ED0rp6NRFIJgSsvavfUCS+gxwo2hgiMBenj2j8Oa6Irrqogy7F0tQ0t5oTUlIYO+9wyV26\n s179frrXTswexCCp+2ve0Y4KpAQqdcKcUebKL9sbgZS+KcihTssEHp05s8VyFKkmWfz20s\n P52YDItUf12dxzrxrDMoe0WTafp/a4g=", "X-MC-Unique": "XYq5tSmsNHCxNxQ5qMCzwg-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=FRQlmN8tqI8tCm30mS6G/bZpn2jie5+VxE05EqiLqbQ=;\n b=Nupt4yhD1MbWAii+tf3TDSqFu94jZ5e4Mm9IW9vftHFWkFXhfzE5bVEwRhMyPJ4mf1\n kMz90J5qktI/MSjZC6xFtWGhWK+fzULyalD9+inRHwrKXcFC/l/OqsGNGyCXh5953jrt\n AjSb9UYNcS4MNFuCzLUm/82bbDUpCsYlcIukJWYc0blyq8jd8dTa0Sll5+rVidBlbMrC\n xoFW34xd0gno0R3/5yVJ7fDo+fXlFXYfum1vuGQidAYO+H8JPd3VMVGDk6VlqXQXOvi0\n 5Lhw6YYLZGK0DpC9c2+EaEknvJPD5bnxopnVJH1XDlD1OWpPSPxSFNyKeKvZMaWtlgYu\n NYiQ==", "X-Gm-Message-State": "AOAM530pihvcOkteRZ+xWS1Pn2Pw4yCNTDryaVhEZkdLrIl+my/MLFRy\n F1R+vPxptwERpCQYDkjSiSU9Zd1MAMBZGXPIVewT/W1aB1Hm/41wVysbT/Vv0JzEtVccov/GFLK\n VoJi25rcj/kcZMilch+g=", "X-Received": [ "by 2002:a1f:3ad3:: with SMTP id h202mr7882084vka.80.1595597266584;\n Fri, 24 Jul 2020 06:27:46 -0700 (PDT)", "by 2002:a1f:3ad3:: with SMTP id h202mr7882057vka.80.1595597266234;\n Fri, 24 Jul 2020 06:27:46 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJzJ0eCmbl+CjIXZFzF+Q3VZAmpy9Pz2wzL0aGyu8u4peqV464SMOKjBq2ik2e2mVvlJqctIk0vKKVcYo22rgyY=", "MIME-Version": "1.0", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>\n <20200723200910.376581-3-parav@mellanox.com>", "In-Reply-To": "<20200723200910.376581-3-parav@mellanox.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Fri, 24 Jul 2020 15:27:35 +0200", "Message-ID": "\n <CAJFAV8xOHPNbHCpgZ41HdUFLr7V0+4LpFXmceYs7NmuJCeQ=oA@mail.gmail.com>", "To": "Parav Pandit <parav@mellanox.com>", "Cc": "dev <dev@dpdk.org>, Gaetan Rivet <grive@u256.net>,\n \"Yigit, Ferruh\" <ferruh.yigit@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Raslan <rasland@mellanox.com>, Ori Kam <orika@mellanox.com>,\n Matan Azrad <matan@mellanox.com>, Joyce Kong <joyce.kong@arm.com>", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "Re: [dpdk-dev] [PATCH v8 02/10] drivers: fix indent of directory\n\tlist", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116595, "web_url": "https://patches.dpdk.org/comment/116595/", "msgid": "<20200724104422.GA2305@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724104422.GA2305@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-24T10:44:22", "subject": "Re: [dpdk-dev] [PATCH v8 02/10] drivers: fix indent of directory\n\tlist", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, Jul 23, 2020 at 11:09:02PM +0300, Parav Pandit wrote:\n> From: Thomas Monjalon <thomas@monjalon.net>\n> \n> Define each sub-directory on its own line ended with a comma,\n> and use a simple indent.\n> \n> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>\n> ---\n> drivers/meson.build | 24 +++++++++++++-----------\n> 1 file changed, 13 insertions(+), 11 deletions(-)\n> \nThanks. Although we normally don't like doing cleanups for whitespace, this\nis a small-enough change and worth doing, since the existing indentation\nwas just weird.\n\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E782A0518;\n\tFri, 24 Jul 2020 12:44:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 211FC1C01E;\n\tFri, 24 Jul 2020 12:44:31 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id C55951C012\n for <dev@dpdk.org>; Fri, 24 Jul 2020 12:44:28 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jul 2020 03:44:27 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.251.87.116])\n by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 24 Jul 2020 03:44:25 -0700" ], "IronPort-SDR": [ "\n uXyXfuxpNGRyduvZWbDGrpRFGp2qATfeWuY+jU6z53Zf36x0xw43yPsgHuOvYRCn0kg4pplN47\n pnmotFyyDlTg==", "\n RR8RZiWgmXc9uZ5OnE3s6ym5+gFQidNP7dXrr3oZikgGlYnij2PJEDTuQfkZqSs2Qu8zrMcAYa\n axwFkMH/mY2A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"148604420\"", "E=Sophos;i=\"5.75,390,1589266800\"; d=\"scan'208\";a=\"148604420\"", "E=Sophos;i=\"5.75,390,1589266800\"; d=\"scan'208\";a=\"433042892\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Fri, 24 Jul 2020 11:44:22 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Parav Pandit <parav@mellanox.com>", "Cc": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com,\n thomas@monjalon.net, rasland@mellanox.com, orika@mellanox.com,\n matan@mellanox.com, joyce.kong@arm.com", "Message-ID": "<20200724104422.GA2305@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>\n <20200723200910.376581-3-parav@mellanox.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200723200910.376581-3-parav@mellanox.com>", "Subject": "Re: [dpdk-dev] [PATCH v8 02/10] drivers: fix indent of directory\n\tlist", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]