diff mbox series

[v8,02/10] drivers: fix indent of directory list

Message ID 20200723200910.376581-3-parav@mellanox.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series Improve mlx5 PMD driver framework for multiple classes |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Parav Pandit July 23, 2020, 8:09 p.m. UTC 
  From: Thomas Monjalon <thomas@monjalon.net>

Define each sub-directory on its own line ended with a comma,
and use a simple indent.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/meson.build | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

Comments

Bruce Richardson July 24, 2020, 10:44 a.m. UTC | #1 
On Thu, Jul 23, 2020 at 11:09:02PM +0300, Parav Pandit wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
> 
> Define each sub-directory on its own line ended with a comma,
> and use a simple indent.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/meson.build | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
Thanks. Although we normally don't like doing cleanups for whitespace, this
is a small-enough change and worth doing, since the existing indentation
was just weird.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
David Marchand July 24, 2020, 1:27 p.m. UTC | #2 
On Thu, Jul 23, 2020 at 10:10 PM Parav Pandit <parav@mellanox.com> wrote:
>
> From: Thomas Monjalon <thomas@monjalon.net>
>
> Define each sub-directory on its own line ended with a comma,
> and use a simple indent.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/meson.build | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/meson.build b/drivers/meson.build
> index e76ebddfa..e2aeba931 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -2,17 +2,19 @@
>  # Copyright(c) 2017-2019 Intel Corporation
>
>  # Defines the order in which the drivers are buit.
> -dpdk_driver_classes = ['common',
> -              'bus',
> -              'mempool', # depends on common and bus.
> -              'net',     # depends on common, bus, mempool
> -              'raw',     # depends on common, bus and net.
> -              'crypto',  # depends on common, bus and mempool (net in future).
> -              'compress', # depends on common, bus, mempool.
> -              'regex', # depends on common, bus, regexdev.
> -              'vdpa',    # depends on common, bus and mempool.
> -              'event',   # depends on common, bus, mempool and net.
> -              'baseband'] # depends on common and bus.
> +dpdk_driver_classes = [
> +       'common',
> +       'bus',
> +       'mempool', # depends on common and bus.
> +       'net',     # depends on common, bus, mempool
> +       'raw',     # depends on common, bus and net.
> +       'crypto',  # depends on common, bus and mempool (net in future).
> +       'compress', # depends on common, bus, mempool.
> +       'regex', # depends on common, bus, regexdev.
> +       'vdpa',    # depends on common, bus and mempool.
> +       'event',   # depends on common, bus, mempool and net.
> +       'baseband', # depends on common and bus.
> +]
>
>  disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),
>                 ).stdout().split()
> --
> 2.25.4
>

Reviewed-by: David Marchand <david.marchand@redhat.com>
diff mbox series

Patch

diff --git a/drivers/meson.build b/drivers/meson.build
index e76ebddfa..e2aeba931 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -2,17 +2,19 @@ 
 # Copyright(c) 2017-2019 Intel Corporation
 
 # Defines the order in which the drivers are buit.
-dpdk_driver_classes = ['common',
-	       'bus',
-	       'mempool', # depends on common and bus.
-	       'net',     # depends on common, bus, mempool
-	       'raw',     # depends on common, bus and net.
-	       'crypto',  # depends on common, bus and mempool (net in future).
-	       'compress', # depends on common, bus, mempool.
-	       'regex', # depends on common, bus, regexdev.
-	       'vdpa',    # depends on common, bus and mempool.
-	       'event',   # depends on common, bus, mempool and net.
-	       'baseband'] # depends on common and bus.
+dpdk_driver_classes = [
+	'common',
+	'bus',
+	'mempool', # depends on common and bus.
+	'net',     # depends on common, bus, mempool
+	'raw',     # depends on common, bus and net.
+	'crypto',  # depends on common, bus and mempool (net in future).
+	'compress', # depends on common, bus, mempool.
+	'regex', # depends on common, bus, regexdev.
+	'vdpa',    # depends on common, bus and mempool.
+	'event',   # depends on common, bus, mempool and net.
+	'baseband', # depends on common and bus.
+]
 
 disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),
 		).stdout().split()