Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74632/?format=api
{ "id": 74632, "url": "https://patches.dpdk.org/api/patches/74632/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723070240.14749-1-sarosh.arif@emumba.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723070240.14749-1-sarosh.arif@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723070240.14749-1-sarosh.arif@emumba.com", "date": "2020-07-23T07:02:40", "name": "mbuf: replace c memcpy() code semantics with optimized rte_memcpy()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "30dc1a6bfef2c79d314706550e3d51710190cc86", "submitter": { "id": 1638, "url": "https://patches.dpdk.org/api/people/1638/?format=api", "name": "Sarosh Arif", "email": "sarosh.arif@emumba.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723070240.14749-1-sarosh.arif@emumba.com/mbox/", "series": [ { "id": 11247, "url": "https://patches.dpdk.org/api/series/11247/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11247", "date": "2020-07-23T07:02:40", "name": "mbuf: replace c memcpy() code semantics with optimized rte_memcpy()", "version": 1, "mbox": "https://patches.dpdk.org/series/11247/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74632/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74632/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 171C3A0527;\n\tThu, 23 Jul 2020 09:05:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B7DA51BF94;\n\tThu, 23 Jul 2020 09:05:54 +0200 (CEST)", "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id CBD5E1BF7B\n for <dev@dpdk.org>; Thu, 23 Jul 2020 09:05:52 +0200 (CEST)", "by mail-wm1-f67.google.com with SMTP id 184so4190886wmb.0\n for <dev@dpdk.org>; Thu, 23 Jul 2020 00:05:52 -0700 (PDT)", "from localhost.localdomain ([58.65.159.11])\n by smtp.gmail.com with ESMTPSA id w16sm2830261wrg.95.2020.07.23.00.05.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Jul 2020 00:05:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id;\n bh=lSoxi1adlzxDJAU85RjjWZLMnXKNsfdPBVXucNkCCA0=;\n b=UsL6JyMUDrFtwIwfAhy33GBPUBbuu1Zc5s93BZHCrFUiHZ5LNyE8pBTgCfpkvhfcfq\n Wq/bz3EA6D/Q/unEqrt8pA07vcYncV+lUL+pla0K5QbwNlBamlYUnH4RRLUkD/q19K+u\n JX1sE2LKMoQJuWEgcbAzAED/AA4Vo1c19MwsDoQ9BV1Wtg4qtfsX9OZBfqnRyakHNApJ\n G746U5/4lYbg4OB5DWjtEELz4PA9glwcXIlYsBZxd4usX8X/gOEaIjK/Y+WEdMd6e1d3\n TkSPTm4+n+qeD6Q6p76M4h5ur8tsnz+1OC5cy4apIXQNR4dCgBOnIhYas9K/OQ7HwibY\n dC7w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=lSoxi1adlzxDJAU85RjjWZLMnXKNsfdPBVXucNkCCA0=;\n b=f1cPO7zMLrBAcYOA1GFs90shXHQgQ77EzGv08HrizrZ4q7qEIdHRheooUKWNiorDqi\n pneNblbJgs8dvzecMEzmExbFKHIsLmdv/ageH2ke2LZwT6vhtVP/SlnB/vMs0npkXLvp\n Cfa3V98EoOjyRl6djPufXqxQfs+kixfgGPkxAAbb2OMFY960mjuoPf+6GWzVyFqoZluM\n I3M6Yo8rz535w8Gs9XfBS+VyMtrBR2ILoK+t5U5RgHVGGs03N4iyLIf/wfe+tw8rLxCC\n Wbt6rctHCaOYvuXDAcvdh9gN3DlLhxG12GO2d9P6gCH7oO9YSQihfUe4oafw+s2kAx8G\n 5hFA==", "X-Gm-Message-State": "AOAM531g+EFxmKWALRDv2//9UWmg5KWY6kIRkVw8Pv8A/jk+Z8+Y3H9F\n VpYdQ1eR/+7zJwW1BAs+NIUAPw==", "X-Google-Smtp-Source": "\n ABdhPJwCw2F9Y0pRuqkVh2hdoIXT5IIdi/FS1tifDqy8Z8/+Gi9eGCNviygI73Pff0Bk73YhUuca7g==", "X-Received": "by 2002:a1c:4343:: with SMTP id q64mr2845201wma.20.1595487952345;\n Thu, 23 Jul 2020 00:05:52 -0700 (PDT)", "From": "Sarosh Arif <sarosh.arif@emumba.com>", "To": "olivier.matz@6wind.com", "Cc": "dev@dpdk.org,\n\tSarosh Arif <sarosh.arif@emumba.com>", "Date": "Thu, 23 Jul 2020 12:02:40 +0500", "Message-Id": "<20200723070240.14749-1-sarosh.arif@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] mbuf: replace c memcpy() code semantics with\n\toptimized rte_memcpy()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since rte_memcpy is more optimized it should be used instead of memcpy\n\nSigned-off-by: Sarosh Arif <sarosh.arif@emumba.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 2 +-\n lib/librte_mbuf/rte_mbuf.h | 3 ++-\n lib/librte_mbuf/rte_mbuf_dyn.c | 8 +++++---\n 3 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 8a456e5e6..71b5998ce 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -66,7 +66,7 @@ rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg)\n \t\t ~RTE_PKTMBUF_POOL_F_PINNED_EXT_BUF) == 0);\n \n \tmbp_priv = rte_mempool_get_priv(mp);\n-\tmemcpy(mbp_priv, user_mbp_priv, sizeof(*mbp_priv));\n+\trte_memcpy(mbp_priv, user_mbp_priv, sizeof(*mbp_priv));\n }\n \n /*\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 7259575a7..b7f6bfaa2 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -42,6 +42,7 @@\n #include <rte_byteorder.h>\n #include <rte_mbuf_ptype.h>\n #include <rte_mbuf_core.h>\n+#include <rte_memcpy.h>\n \n #ifdef __cplusplus\n extern \"C\" {\n@@ -1109,7 +1110,7 @@ rte_pktmbuf_attach_extbuf(struct rte_mbuf *m, void *buf_addr,\n static inline void\n rte_mbuf_dynfield_copy(struct rte_mbuf *mdst, const struct rte_mbuf *msrc)\n {\n-\tmemcpy(&mdst->dynfield1, msrc->dynfield1, sizeof(mdst->dynfield1));\n+\trte_memcpy(&mdst->dynfield1, msrc->dynfield1, sizeof(mdst->dynfield1));\n }\n \n /* internal */\ndiff --git a/lib/librte_mbuf/rte_mbuf_dyn.c b/lib/librte_mbuf/rte_mbuf_dyn.c\nindex 538a43f69..0631a35a9 100644\n--- a/lib/librte_mbuf/rte_mbuf_dyn.c\n+++ b/lib/librte_mbuf/rte_mbuf_dyn.c\n@@ -15,6 +15,7 @@\n #include <rte_string_fns.h>\n #include <rte_mbuf.h>\n #include <rte_mbuf_dyn.h>\n+#include <rte_memcpy.h>\n \n #define RTE_MBUF_DYN_MZNAME \"rte_mbuf_dyn\"\n \n@@ -200,7 +201,7 @@ rte_mbuf_dynfield_lookup(const char *name, struct rte_mbuf_dynfield *params)\n \t}\n \n \tif (params != NULL)\n-\t\tmemcpy(params, &mbuf_dynfield->params, sizeof(*params));\n+\t\trte_memcpy(params, &mbuf_dynfield->params, sizeof(*params));\n \n \treturn mbuf_dynfield->offset;\n }\n@@ -303,7 +304,8 @@ __rte_mbuf_dynfield_register_offset(const struct rte_mbuf_dynfield *params,\n \t\trte_free(te);\n \t\treturn -1;\n \t}\n-\tmemcpy(&mbuf_dynfield->params, params, sizeof(mbuf_dynfield->params));\n+\trte_memcpy(&mbuf_dynfield->params, params,\n+\t\t\t\tsizeof(mbuf_dynfield->params));\n \tmbuf_dynfield->offset = offset;\n \tte->data = mbuf_dynfield;\n \n@@ -399,7 +401,7 @@ rte_mbuf_dynflag_lookup(const char *name,\n \t}\n \n \tif (params != NULL)\n-\t\tmemcpy(params, &mbuf_dynflag->params, sizeof(*params));\n+\t\trte_memcpy(params, &mbuf_dynflag->params, sizeof(*params));\n \n \treturn mbuf_dynflag->bitnum;\n }\n", "prefixes": [] }