Patch Comment List
List patch comments
GET /api/patches/74529/comments/?format=api
[ { "id": 116658, "web_url": "https://patches.dpdk.org/comment/116658/", "msgid": "<1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com", "date": "2020-07-27T04:24:54", "subject": "Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports\n\tcapability", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "hi, guinan\n\nOn 7/21/2020 3:39 PM, Guinan Sun wrote:\n> This patch adds support for \"Disable Unused Ports\" functionality.\n\n\n\"This patch adds support for disabling unused ports\" is enough for reader i think.\n\nAnd use 2 verb is not good in title, \"Support unused ports disabling\" or \nother you want.\n\n\n>\n> Signed-off-by: Damian Milosek <damian.milosek@intel.com>\n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n> drivers/net/i40e/base/i40e_adminq_cmd.h | 1 +\n> drivers/net/i40e/base/i40e_common.c | 6 ++++++\n> drivers/net/i40e/base/i40e_type.h | 1 +\n> 3 files changed, 8 insertions(+)\n>\n> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> index e1018ed49..c7686b0d3 100644\n> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> @@ -440,6 +440,7 @@ struct i40e_aqc_list_capabilities_element_resp {\n> #define I40E_AQ_CAP_ID_SDP\t\t0x0062\n> #define I40E_AQ_CAP_ID_MDIO\t\t0x0063\n> #define I40E_AQ_CAP_ID_WSR_PROT\t\t0x0064\n> +#define I40E_AQ_CAP_ID_DIS_UNUSED_PORTS\t0x0067\n\n\nPlease double check if it is \"0x0066\" or \"0x0067\", if it is conform, \nplease add my ACK for this patch at next version.\n\n\n> #define I40E_AQ_CAP_ID_NVM_MGMT\t\t0x0080\n> #define I40E_AQ_CAP_ID_FLEX10\t\t0x00F1\n> #define I40E_AQ_CAP_ID_CEM\t\t0x00F2\n> diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\n> index 85c22849e..65317f6c6 100644\n> --- a/drivers/net/i40e/base/i40e_common.c\n> +++ b/drivers/net/i40e/base/i40e_common.c\n> @@ -4021,6 +4021,12 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,\n> \t\t\t\t \"HW Capability: wr_csr_prot = 0x%llX\\n\\n\",\n> \t\t\t\t (p->wr_csr_prot & 0xffff));\n> \t\t\tbreak;\n> +\t\tcase I40E_AQ_CAP_ID_DIS_UNUSED_PORTS:\n> +\t\t\tp->dis_unused_ports = (bool)number;\n> +\t\t\ti40e_debug(hw, I40E_DEBUG_INIT,\n> +\t\t\t\t \"HW Capability: dis_unused_ports = %d\\n\\n\",\n> +\t\t\t\t p->dis_unused_ports);\n> +\t\t\tbreak;\n> \t\tcase I40E_AQ_CAP_ID_NVM_MGMT:\n> \t\t\tif (number & I40E_NVM_MGMT_SEC_REV_DISABLED)\n> \t\t\t\tp->sec_rev_disabled = true;\n> diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h\n> index 0eeb55975..cf4134583 100644\n> --- a/drivers/net/i40e/base/i40e_type.h\n> +++ b/drivers/net/i40e/base/i40e_type.h\n> @@ -425,6 +425,7 @@ struct i40e_hw_capabilities {\n> \tu32 enabled_tcmap;\n> \tu32 maxtc;\n> \tu64 wr_csr_prot;\n> +\tbool dis_unused_ports;\n> \tbool apm_wol_support;\n> \tenum i40e_acpi_programming_method acpi_prog_method;\n> \tbool proxy_support;", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5984EA0524;\n\tMon, 27 Jul 2020 06:25:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04F351BFC8;\n\tMon, 27 Jul 2020 06:25:00 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id C34332B8D\n for <dev@dpdk.org>; Mon, 27 Jul 2020 06:24:58 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 21:24:57 -0700", "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176])\n ([10.67.68.176])\n by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 21:24:55 -0700" ], "IronPort-SDR": [ "\n 7oaMvN9YSTJLPQmLwspfmthleCSKgjSdECPCqaOifMRAzj3L3f9Ml7lZTZjwlPp7I2A49kDrZN\n 1ORLc6XqhYSg==", "\n Vlij1nSwOBlz3kMKi7q+iBV3XHpOcmxyKQn7xc+ZtoYzgUI0DbWEsx3Z+Ly23z6neg+2GXr7Fc\n FTQs63dKx5cA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"212479113\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"212479113\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"327894790\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org", "Cc": "Beilei Xing <beilei.xing@intel.com>,\n Damian Milosek <damian.milosek@intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-7-guinanx.sun@intel.com>", "From": "Jeff Guo <jia.guo@intel.com>", "Message-ID": "<1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com>", "Date": "Mon, 27 Jul 2020 12:24:54 +0800", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200721074000.30449-7-guinanx.sun@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports\n\tcapability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116664, "web_url": "https://patches.dpdk.org/comment/116664/", "msgid": "<05758BDAD7FC8E4BAED63D0390A8A95587EED1@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/05758BDAD7FC8E4BAED63D0390A8A95587EED1@SHSMSX101.ccr.corp.intel.com", "date": "2020-07-27T05:01:00", "subject": "Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports\n\tcapability", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "content": "Hi Jeff\n\n> -----Original Message-----\n> From: Guo, Jia\n> Sent: Monday, July 27, 2020 12:25 PM\n> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Milosek, Damian\n> <damian.milosek@intel.com>\n> Subject: Re: [PATCH 6/8] net/i40e/base: add disable unused ports capability\n> \n> hi, guinan\n> \n> On 7/21/2020 3:39 PM, Guinan Sun wrote:\n> > This patch adds support for \"Disable Unused Ports\" functionality.\n> \n> \n> \"This patch adds support for disabling unused ports\" is enough for reader i think.\n> \n> And use 2 verb is not good in title, \"Support unused ports disabling\" or other\n> you want.\n> \n\nI think you are right.\nPatch V2 will modify it.\n\n> \n> >\n> > Signed-off-by: Damian Milosek <damian.milosek@intel.com>\n> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> > ---\n> > drivers/net/i40e/base/i40e_adminq_cmd.h | 1 +\n> > drivers/net/i40e/base/i40e_common.c | 6 ++++++\n> > drivers/net/i40e/base/i40e_type.h | 1 +\n> > 3 files changed, 8 insertions(+)\n> >\n> > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > index e1018ed49..c7686b0d3 100644\n> > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > @@ -440,6 +440,7 @@ struct i40e_aqc_list_capabilities_element_resp {\n> > #define I40E_AQ_CAP_ID_SDP\t\t0x0062\n> > #define I40E_AQ_CAP_ID_MDIO\t\t0x0063\n> > #define I40E_AQ_CAP_ID_WSR_PROT\t\t0x0064\n> > +#define I40E_AQ_CAP_ID_DIS_UNUSED_PORTS\t0x0067\n> \n> \n> Please double check if it is \"0x0066\" or \"0x0067\", if it is conform,\n> please add my ACK for this patch at next version.\n> \n> \n> > #define I40E_AQ_CAP_ID_NVM_MGMT\t\t0x0080\n> > #define I40E_AQ_CAP_ID_FLEX10\t\t0x00F1\n> > #define I40E_AQ_CAP_ID_CEM\t\t0x00F2\n> > diff --git a/drivers/net/i40e/base/i40e_common.c\n> b/drivers/net/i40e/base/i40e_common.c\n> > index 85c22849e..65317f6c6 100644\n> > --- a/drivers/net/i40e/base/i40e_common.c\n> > +++ b/drivers/net/i40e/base/i40e_common.c\n> > @@ -4021,6 +4021,12 @@ STATIC void\n> i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,\n> > \t\t\t\t \"HW Capability: wr_csr_prot = 0x%llX\\n\\n\",\n> > \t\t\t\t (p->wr_csr_prot & 0xffff));\n> > \t\t\tbreak;\n> > +\t\tcase I40E_AQ_CAP_ID_DIS_UNUSED_PORTS:\n> > +\t\t\tp->dis_unused_ports = (bool)number;\n> > +\t\t\ti40e_debug(hw, I40E_DEBUG_INIT,\n> > +\t\t\t\t \"HW Capability: dis_unused_ports = %d\\n\\n\",\n> > +\t\t\t\t p->dis_unused_ports);\n> > +\t\t\tbreak;\n> > \t\tcase I40E_AQ_CAP_ID_NVM_MGMT:\n> > \t\t\tif (number & I40E_NVM_MGMT_SEC_REV_DISABLED)\n> > \t\t\t\tp->sec_rev_disabled = true;\n> > diff --git a/drivers/net/i40e/base/i40e_type.h\n> b/drivers/net/i40e/base/i40e_type.h\n> > index 0eeb55975..cf4134583 100644\n> > --- a/drivers/net/i40e/base/i40e_type.h\n> > +++ b/drivers/net/i40e/base/i40e_type.h\n> > @@ -425,6 +425,7 @@ struct i40e_hw_capabilities {\n> > \tu32 enabled_tcmap;\n> > \tu32 maxtc;\n> > \tu64 wr_csr_prot;\n> > +\tbool dis_unused_ports;\n> > \tbool apm_wol_support;\n> > \tenum i40e_acpi_programming_method acpi_prog_method;\n> > \tbool proxy_support;", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A69EFA0524;\n\tMon, 27 Jul 2020 07:01:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C35571BFE8;\n\tMon, 27 Jul 2020 07:01:08 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 1E20A1BE8A\n for <dev@dpdk.org>; Mon, 27 Jul 2020 07:01:06 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 22:01:05 -0700", "from fmsmsx601.amr.corp.intel.com ([10.18.126.81])\n by orsmga003.jf.intel.com with ESMTP; 26 Jul 2020 22:01:05 -0700", "from fmsmsx601.amr.corp.intel.com (10.18.126.81) by\n fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Sun, 26 Jul 2020 22:01:04 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Sun, 26 Jul 2020 22:01:04 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000;\n Mon, 27 Jul 2020 13:01:01 +0800" ], "IronPort-SDR": [ "\n AD9YYwNyd3Yk+HjFG+UlgEE0MqHMjvc8gDG4xOdJDfNy3HNi3fMcfHNS4H5Qvor1o3UXpHXuWO\n TkxqiC6IBgdg==", "\n dKaizIrOCMLzVBfuUOTsEU0uDOot0NuCSQIcnjYKBJ/L8CyOH8lXICPZAcp5AsVAj+FMIhIDFy\n Jk7yMFb2uHXw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"152213677\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"152213677\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"285571755\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Sun, GuinanX\" <guinanx.sun@intel.com>", "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Milosek, Damian\"\n <damian.milosek@intel.com>", "Thread-Topic": "[PATCH 6/8] net/i40e/base: add disable unused ports capability", "Thread-Index": "AQHWXzWlQYDgxtR3DEKF8MtwCAIj7akaVzkAgACPb/A=", "Date": "Mon, 27 Jul 2020 05:01:00 +0000", "Message-ID": "\n <05758BDAD7FC8E4BAED63D0390A8A95587EED1@SHSMSX101.ccr.corp.intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-7-guinanx.sun@intel.com>\n <1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com>", "In-Reply-To": "<1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports\n\tcapability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]