Patch Comment List
List patch comments
GET /api/patches/74528/comments/?format=api
[ { "id": 116657, "web_url": "https://patches.dpdk.org/comment/116657/", "msgid": "<91ae8060-d020-734b-d50d-0e688b0564bb@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/91ae8060-d020-734b-d50d-0e688b0564bb@intel.com", "date": "2020-07-27T04:07:52", "subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "hi, guinan\n\nOn 7/21/2020 3:39 PM, Guinan Sun wrote:\n> Check return value of running DNL admin command.\n\n\nWhat is \"DNL\", I am not sure i know the reason it appear here, could you \ndouble check it?\n\n\n>\n> Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>\n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n> drivers/net/i40e/base/i40e_common.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\n> index 46a0b7881..85c22849e 100644\n> --- a/drivers/net/i40e/base/i40e_common.c\n> +++ b/drivers/net/i40e/base/i40e_common.c\n> @@ -7097,7 +7097,7 @@ enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,\n> \t\t\t\tI40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,\n> \t\t\t\t&cmd_status, tx_counter, rx_counter, NULL);\n> \n> -\t\tif (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> +\t\tif (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> \t\t\tretval = I40E_ERR_ADMIN_QUEUE_ERROR;\n> \n> \t\treturn retval;", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC815A0524;\n\tMon, 27 Jul 2020 06:08:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09BBF1C025;\n\tMon, 27 Jul 2020 06:07:59 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 447171C023\n for <dev@dpdk.org>; Mon, 27 Jul 2020 06:07:56 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 21:07:55 -0700", "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176])\n ([10.67.68.176])\n by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 21:07:53 -0700" ], "IronPort-SDR": [ "\n AptMjiOVRQw3lvQusTE5r9/4AwRDocKQGMW7R0yDYfBO5T6ZXqKzIP3EfEVkd0jHgGfqX2AzPf\n 4bh7RQfh+1CA==", "\n FwB2GyLNilWrMORjE9uTQEXAxaEZuPptDXQ/1TKlPW/LuJbzOkNXDXJIDOeOdoYSijTe3CFYaS\n JxWczU1LWz/A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"150932617\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"150932617\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"327892120\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org", "Cc": "Beilei Xing <beilei.xing@intel.com>,\n Adam Ludkiewicz <adam.ludkiewicz@intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-6-guinanx.sun@intel.com>", "From": "Jeff Guo <jia.guo@intel.com>", "Message-ID": "<91ae8060-d020-734b-d50d-0e688b0564bb@intel.com>", "Date": "Mon, 27 Jul 2020 12:07:52 +0800", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200721074000.30449-6-guinanx.sun@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116662, "web_url": "https://patches.dpdk.org/comment/116662/", "msgid": "<05758BDAD7FC8E4BAED63D0390A8A95587EEA7@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/05758BDAD7FC8E4BAED63D0390A8A95587EEA7@SHSMSX101.ccr.corp.intel.com", "date": "2020-07-27T04:53:39", "subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "content": "Hi Jeff\n\n> -----Original Message-----\n> From: Guo, Jia\n> Sent: Monday, July 27, 2020 12:08 PM\n> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam\n> <adam.ludkiewicz@intel.com>\n> Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL admin\n> command\n> \n> hi, guinan\n> \n> On 7/21/2020 3:39 PM, Guinan Sun wrote:\n> > Check return value of running DNL admin command.\n> \n> \n> What is \"DNL\", I am not sure i know the reason it appear here, could you\n> double check it?\n> \n\nRegarding what DNL stands for, I haven't found it in the code and datasheet.\nIt can be seen from the code change that the return value check operation of i40e_aq_run_phy_activity has been added.\nThe description of this function is RUN DNL admin command.\nSo tile and commit log have made such changes.\n\n> \n> >\n> > Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>\n> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> > ---\n> > drivers/net/i40e/base/i40e_common.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/drivers/net/i40e/base/i40e_common.c\n> b/drivers/net/i40e/base/i40e_common.c\n> > index 46a0b7881..85c22849e 100644\n> > --- a/drivers/net/i40e/base/i40e_common.c\n> > +++ b/drivers/net/i40e/base/i40e_common.c\n> > @@ -7097,7 +7097,7 @@ enum i40e_status_code\n> i40e_get_lpi_counters(struct i40e_hw *hw,\n> >\n> \tI40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,\n> > \t\t\t\t&cmd_status, tx_counter, rx_counter, NULL);\n> >\n> > -\t\tif (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> > +\t\tif (!retval && cmd_status !=\n> I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> > \t\t\tretval = I40E_ERR_ADMIN_QUEUE_ERROR;\n> >\n> > \t\treturn retval;", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CFC01A0524;\n\tMon, 27 Jul 2020 06:53:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E765B1BFCF;\n\tMon, 27 Jul 2020 06:53:47 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id F271C1BE8A\n for <dev@dpdk.org>; Mon, 27 Jul 2020 06:53:45 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 21:53:44 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n by fmsmga002.fm.intel.com with ESMTP; 26 Jul 2020 21:53:44 -0700", "from fmsmsx101.amr.corp.intel.com (10.18.124.199) by\n fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 21:53:44 -0700", "from shsmsx107.ccr.corp.intel.com (10.239.4.96) by\n fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 21:53:44 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n SHSMSX107.ccr.corp.intel.com ([169.254.9.32]) with mapi id 14.03.0439.000;\n Mon, 27 Jul 2020 12:53:40 +0800" ], "IronPort-SDR": [ "\n MisrEB3BN28CXGtyo+w4cW+jU2RjBxIMF03bP5hnFSD0OA/wrmPlvlcf4Kz43uieq0iEpkwOHv\n ms6yAjf20CzQ==", "\n yZt/Us3SvM4ZX2OS6JqruCNQQ10s1bDvVjLEUE9sFRHPiYc8wTso8kzqD47wlqWQDoS42xfkhx\n J4Fa2bs9eQkg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"150935405\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"150935405\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"321674160\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Sun, GuinanX\" <guinanx.sun@intel.com>", "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Ludkiewicz, Adam\"\n <adam.ludkiewicz@intel.com>", "Thread-Topic": "[PATCH 5/8] net/i40e/base: check return value of DNL admin\n command", "Thread-Index": "AQHWXzWb7Za0xRC65Um7Asg9FXCMCqkaUncAgACRAfA=", "Date": "Mon, 27 Jul 2020 04:53:39 +0000", "Message-ID": "\n <05758BDAD7FC8E4BAED63D0390A8A95587EEA7@SHSMSX101.ccr.corp.intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-6-guinanx.sun@intel.com>\n <91ae8060-d020-734b-d50d-0e688b0564bb@intel.com>", "In-Reply-To": "<91ae8060-d020-734b-d50d-0e688b0564bb@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116668, "web_url": "https://patches.dpdk.org/comment/116668/", "msgid": "<05758BDAD7FC8E4BAED63D0390A8A95587EEFB@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/05758BDAD7FC8E4BAED63D0390A8A95587EEFB@SHSMSX101.ccr.corp.intel.com", "date": "2020-07-27T05:19:46", "subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "content": "Hi, Jeff\n\n> -----Original Message-----\n> From: Sun, GuinanX\n> Sent: Monday, July 27, 2020 12:54 PM\n> To: Guo, Jia <jia.guo@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam\n> <adam.ludkiewicz@intel.com>\n> Subject: RE: [PATCH 5/8] net/i40e/base: check return value of DNL admin\n> command\n> \n> Hi Jeff\n> \n> > -----Original Message-----\n> > From: Guo, Jia\n> > Sent: Monday, July 27, 2020 12:08 PM\n> > To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org\n> > Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam\n> > <adam.ludkiewicz@intel.com>\n> > Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL\n> > admin command\n> >\n> > hi, guinan\n> >\n> > On 7/21/2020 3:39 PM, Guinan Sun wrote:\n> > > Check return value of running DNL admin command.\n> >\n> >\n> > What is \"DNL\", I am not sure i know the reason it appear here, could\n> > you double check it?\n> >\n> \n> Regarding what DNL stands for, I haven't found it in the code and datasheet.\n> It can be seen from the code change that the return value check operation of\n> i40e_aq_run_phy_activity has been added.\n> The description of this function is RUN DNL admin command.\n> So tile and commit log have made such changes.\n\nSorry, I might have misunderstood it just now.\nI will double check for it and patch V2 will modify it.\n\n> \n> >\n> > >\n> > > Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>\n> > > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> > > ---\n> > > drivers/net/i40e/base/i40e_common.c | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/drivers/net/i40e/base/i40e_common.c\n> > b/drivers/net/i40e/base/i40e_common.c\n> > > index 46a0b7881..85c22849e 100644\n> > > --- a/drivers/net/i40e/base/i40e_common.c\n> > > +++ b/drivers/net/i40e/base/i40e_common.c\n> > > @@ -7097,7 +7097,7 @@ enum i40e_status_code\n> > i40e_get_lpi_counters(struct i40e_hw *hw,\n> > >\n> > \tI40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,\n> > > \t\t\t\t&cmd_status, tx_counter, rx_counter, NULL);\n> > >\n> > > -\t\tif (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> > > +\t\tif (!retval && cmd_status !=\n> > I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n> > > \t\t\tretval = I40E_ERR_ADMIN_QUEUE_ERROR;\n> > >\n> > > \t\treturn retval;", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DEE70A0524;\n\tMon, 27 Jul 2020 07:19:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 255D31BFE8;\n\tMon, 27 Jul 2020 07:19:55 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 170861BFE2\n for <dev@dpdk.org>; Mon, 27 Jul 2020 07:19:52 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 22:19:51 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by orsmga001.jf.intel.com with ESMTP; 26 Jul 2020 22:19:51 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 22:19:51 -0700", "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 22:19:51 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n SHSMSX152.ccr.corp.intel.com ([169.254.6.250]) with mapi id 14.03.0439.000;\n Mon, 27 Jul 2020 13:19:47 +0800" ], "IronPort-SDR": [ "\n ut5IfJ/YU55P6JxqY6Ysk0WNHTHq6f0cLyhETHc4WeVEXPRvATYhEm0yWbTT9vGDMakNa9+Tr6\n BY5rowgyidwg==", "\n evn4Sg41S5U0V6syycVE9+qfTi1ZRWvS4DreeUN2F5/xvNxbImaooFWAFQNbAL6Bwc01awM8/E\n 5h+xghBpzC4Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"138467904\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"138467904\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"364010606\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Sun, GuinanX\" <guinanx.sun@intel.com>", "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Ludkiewicz, Adam\"\n <adam.ludkiewicz@intel.com>", "Thread-Topic": "[PATCH 5/8] net/i40e/base: check return value of DNL admin\n command", "Thread-Index": "AQHWXzWb7Za0xRC65Um7Asg9FXCMCqkaUncAgACRAfCAAAdOcA==", "Date": "Mon, 27 Jul 2020 05:19:46 +0000", "Message-ID": "\n <05758BDAD7FC8E4BAED63D0390A8A95587EEFB@SHSMSX101.ccr.corp.intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-6-guinanx.sun@intel.com>\n <91ae8060-d020-734b-d50d-0e688b0564bb@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL\n admin command", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]