Patch Comment List
List patch comments
GET /api/patches/74521/comments/?format=api
[ { "id": 116378, "web_url": "https://patches.dpdk.org/comment/116378/", "msgid": "<E22AF82976AEF646B9B29E4604B9BED504CC155F@CDSMSX102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/E22AF82976AEF646B9B29E4604B9BED504CC155F@CDSMSX102.ccr.corp.intel.com", "date": "2020-07-21T07:09:32", "subject": "Re: [dts] [PATCH V1] framework: get apps name of current build type\n in virt_dut", "submitter": { "id": 1728, "url": "https://patches.dpdk.org/api/people/1728/?format=api", "name": "Zhang, XiX", "email": "xix.zhang@intel.com" }, "content": "Tested-by: Zhang, XiX <xix.zhang@intel.com>\n\n-----Original Message-----\nFrom: Ma, LihongX \nSent: Tuesday, July 21, 2020 7:28 AM\nTo: dts@dpdk.org; Zhang, XiX <xix.zhang@intel.com>\nCc: Ma, LihongX <lihongx.ma@intel.com>\nSubject: [dts][PATCH V1] framework: get apps name of current build type in virt_dut\n\nfix dts issue of d8f3830696b54d48e78463, in virt_dut also need get apps_name from config file\n\nSigned-off-by: lihong <lihongx.ma@intel.com>\n---\n framework/virt_base.py | 1 +\n framework/virt_dut.py | 20 ++++++++++++++++++--\n 2 files changed, 19 insertions(+), 2 deletions(-)\n\ndiff --git a/framework/virt_base.py b/framework/virt_base.py index c959ca0..b582f85 100644\n--- a/framework/virt_base.py\n+++ b/framework/virt_base.py\n@@ -460,6 +460,7 @@ class VirtBase(object):\n \n try:\n # setting up dpdk in vm, must call at last\n+ vm_dut.target = self.host_dut.target\n vm_dut.prerequisites(self.host_dut.package, self.host_dut.patches, autodetect_topo)\n if set_target:\n target = self.host_dut.target diff --git a/framework/virt_dut.py b/framework/virt_dut.py index adf486b..03569ba 100644\n--- a/framework/virt_dut.py\n+++ b/framework/virt_dut.py\n@@ -34,8 +34,8 @@ import re\n import time\n import settings\n from utils import RED, parallel_lock\n-from config import PortConf\n-from settings import NICS, LOG_NAME_SEP, get_netdev\n+from config import PortConf, AppNameConf from settings import NICS, \n+LOG_NAME_SEP, get_netdev, load_global_setting, HOST_BUILD_TYPE_SETTING\n from project_dpdk import DPDKdut\n from dut import Dut\n from net_device import GetNicObj\n@@ -76,6 +76,8 @@ class VirtDut(DPDKdut):\n self.virttype = virttype\n self.prefix_subfix = str(os.getpid()) + '_' + time.strftime(\"%Y%m%d%H%M%S\", time.localtime())\n self.prefix_list = []\n+ self.apps_name_conf = {}\n+ self.apps_name = {}\n \n def init_log(self):\n if hasattr(self.host_dut, \"test_classname\"):\n@@ -216,6 +218,20 @@ class VirtDut(DPDKdut):\n for port_info in self.ports_info:\n self.logger.info(port_info)\n \n+ # load app name conf\n+ name_cfg = AppNameConf()\n+ self.apps_name_conf = name_cfg.load_app_name_conf()\n+\n+ # get apps name of current build type\n+ build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)\n+ if build_type not in self.apps_name_conf:\n+ raise Exception('please config the apps name in app_name.cfg of build type:%s' % build_type)\n+ self.apps_name = self.apps_name_conf[build_type]\n+ # use the dut target directory instead of 'target' string in app name\n+ for app in self.apps_name:\n+ cur_app_path = self.apps_name[app].replace('target', self.target)\n+ self.apps_name[app] = cur_app_path + ' '\n+\n def init_core_list(self):\n self.cores = []\n cpuinfo = self.send_expect(\"grep --color=never \\\"processor\\\"\"\n--\n2.7.4", "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A877A0526;\n\tTue, 21 Jul 2020 09:09:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4BC981C02E;\n\tTue, 21 Jul 2020 09:09:48 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id BB0751C02E\n for <dts@dpdk.org>; Tue, 21 Jul 2020 09:09:43 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 00:09:41 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n by fmsmga007.fm.intel.com with ESMTP; 21 Jul 2020 00:09:39 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 00:09:39 -0700", "from cdsmsx103.ccr.corp.intel.com (172.17.3.37) by\n FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 00:09:38 -0700", "from cdsmsx102.ccr.corp.intel.com ([169.254.2.201]) by\n CDSMSX103.ccr.corp.intel.com ([169.254.5.225]) with mapi id 14.03.0439.000;\n Tue, 21 Jul 2020 15:09:33 +0800" ], "IronPort-SDR": [ "\n RTS7LnFnQMorYpB5XtKSes954mB5e33ZbunCd+QNqvAxn8bOtp241Fm/b6ALi4ZQNHGrGgBRX7\n cusmnQiA8DNw==", "\n 7o2OscaVGPIgY42BoxHVZxi9vwg5Y+r1xWkJcATMsjeHZIIxxv4x4Oppuy9MMKur9iLyswJpKV\n cAw76IKidKMQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"150061629\"", "E=Sophos;i=\"5.75,377,1589266800\";\n d=\"log'?scan'208\";a=\"150061629\"", "E=Sophos;i=\"5.75,377,1589266800\";\n d=\"log'?scan'208\";a=\"270355859\"" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Zhang, XiX\" <xix.zhang@intel.com>", "To": "\"Ma, LihongX\" <lihongx.ma@intel.com>, \"dts@dpdk.org\" <dts@dpdk.org>", "Thread-Topic": "[dts][PATCH V1] framework: get apps name of current build type\n in virt_dut", "Thread-Index": "AQHWXyyCy7AW4XxZBUW1r8GLxQF79qkRnGng", "Date": "Tue, 21 Jul 2020 07:09:32 +0000", "Message-ID": "\n <E22AF82976AEF646B9B29E4604B9BED504CC155F@CDSMSX102.ccr.corp.intel.com>", "References": "<1595287665-21936-1-git-send-email-lihongx.ma@intel.com>", "In-Reply-To": "<1595287665-21936-1-git-send-email-lihongx.ma@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "yes", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[172.17.6.105]", "Content-Type": "multipart/mixed;\n boundary=\"_003_E22AF82976AEF646B9B29E4604B9BED504CC155FCDSMSX102ccrcor_\"", "MIME-Version": "1.0", "Subject": "Re: [dts] [PATCH V1] framework: get apps name of current build type\n in virt_dut", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "addressed": null }, { "id": 116569, "web_url": "https://patches.dpdk.org/comment/116569/", "msgid": "<8CE3E05A3F976642AAB0F4675D0AD20E0BC84119@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/8CE3E05A3F976642AAB0F4675D0AD20E0BC84119@SHSMSX101.ccr.corp.intel.com", "date": "2020-07-24T02:40:48", "subject": "Re: [dts] [PATCH V1] framework: get apps name of current build type\n in\tvirt_dut", "submitter": { "id": 1098, "url": "https://patches.dpdk.org/api/people/1098/?format=api", "name": "Tu, Lijuan", "email": "lijuan.tu@intel.com" }, "content": "Applied, thanks\n\n> -----Original Message-----\n> From: dts <dts-bounces@dpdk.org> On Behalf Of lihong\n> Sent: 2020年7月21日 7:28\n> To: dts@dpdk.org; Zhang, XiX <xix.zhang@intel.com>\n> Cc: Ma, LihongX <lihongx.ma@intel.com>\n> Subject: [dts] [PATCH V1] framework: get apps name of current build type in\n> virt_dut\n> \n> fix dts issue of d8f3830696b54d48e78463, in virt_dut also need get apps_name\n> from config file\n> \n> Signed-off-by: lihong <lihongx.ma@intel.com>\n> ---\n> framework/virt_base.py | 1 +\n> framework/virt_dut.py | 20 ++++++++++++++++++--\n> 2 files changed, 19 insertions(+), 2 deletions(-)\n> \n> diff --git a/framework/virt_base.py b/framework/virt_base.py index\n> c959ca0..b582f85 100644\n> --- a/framework/virt_base.py\n> +++ b/framework/virt_base.py\n> @@ -460,6 +460,7 @@ class VirtBase(object):\n> \n> try:\n> # setting up dpdk in vm, must call at last\n> + vm_dut.target = self.host_dut.target\n> vm_dut.prerequisites(self.host_dut.package, self.host_dut.patches,\n> autodetect_topo)\n> if set_target:\n> target = self.host_dut.target diff --git a/framework/virt_dut.py\n> b/framework/virt_dut.py index adf486b..03569ba 100644\n> --- a/framework/virt_dut.py\n> +++ b/framework/virt_dut.py\n> @@ -34,8 +34,8 @@ import re\n> import time\n> import settings\n> from utils import RED, parallel_lock\n> -from config import PortConf\n> -from settings import NICS, LOG_NAME_SEP, get_netdev\n> +from config import PortConf, AppNameConf from settings import NICS,\n> +LOG_NAME_SEP, get_netdev, load_global_setting,\n> HOST_BUILD_TYPE_SETTING\n> from project_dpdk import DPDKdut\n> from dut import Dut\n> from net_device import GetNicObj\n> @@ -76,6 +76,8 @@ class VirtDut(DPDKdut):\n> self.virttype = virttype\n> self.prefix_subfix = str(os.getpid()) + '_' +\n> time.strftime(\"%Y%m%d%H%M%S\", time.localtime())\n> self.prefix_list = []\n> + self.apps_name_conf = {}\n> + self.apps_name = {}\n> \n> def init_log(self):\n> if hasattr(self.host_dut, \"test_classname\"):\n> @@ -216,6 +218,20 @@ class VirtDut(DPDKdut):\n> for port_info in self.ports_info:\n> self.logger.info(port_info)\n> \n> + # load app name conf\n> + name_cfg = AppNameConf()\n> + self.apps_name_conf = name_cfg.load_app_name_conf()\n> +\n> + # get apps name of current build type\n> + build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)\n> + if build_type not in self.apps_name_conf:\n> + raise Exception('please config the apps name in app_name.cfg of build\n> type:%s' % build_type)\n> + self.apps_name = self.apps_name_conf[build_type]\n> + # use the dut target directory instead of 'target' string in app name\n> + for app in self.apps_name:\n> + cur_app_path = self.apps_name[app].replace('target', self.target)\n> + self.apps_name[app] = cur_app_path + ' '\n> +\n> def init_core_list(self):\n> self.cores = []\n> cpuinfo = self.send_expect(\"grep --color=never \\\"processor\\\"\"\n> --\n> 2.7.4", "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0461BA0518;\n\tFri, 24 Jul 2020 04:40:56 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F0FF11D5F7;\n\tFri, 24 Jul 2020 04:40:55 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 4F9901C211\n for <dts@dpdk.org>; Fri, 24 Jul 2020 04:40:54 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 19:40:53 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n by fmsmga001.fm.intel.com with ESMTP; 23 Jul 2020 19:40:53 -0700", "from fmsmsx115.amr.corp.intel.com (10.18.116.19) by\n fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 19:40:53 -0700", "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 19:40:52 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n SHSMSX103.ccr.corp.intel.com ([169.254.4.22]) with mapi id 14.03.0439.000;\n Fri, 24 Jul 2020 10:40:49 +0800" ], "IronPort-SDR": [ "\n rSlAFun/9IDHgyzl7gFbS7Gow4KMV/Bi1HAklQe6FHxopBLky3dtA1RPnTNlyQ11VMZGNwhqPP\n N0d9lckB5ndg==", "\n dhOccUS7X5v4d9V+kGHoUtUouu2jOuZ7yCmJWZtwOSUyJDiYxKPoaTu3yJgdx7gokKvJQC/+FX\n eyjc0krcCqwQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"235529034\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"235529034\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"393186888\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Tu, Lijuan\" <lijuan.tu@intel.com>", "To": "\"Ma, LihongX\" <lihongx.ma@intel.com>, \"dts@dpdk.org\" <dts@dpdk.org>,\n \"Zhang, XiX\" <xix.zhang@intel.com>", "CC": "\"Ma, LihongX\" <lihongx.ma@intel.com>", "Thread-Topic": "[dts] [PATCH V1] framework: get apps name of current build\n type in\tvirt_dut", "Thread-Index": "AQHWXyyK3QZrN81eVUyFHE+yk83uvakWCU7w", "Date": "Fri, 24 Jul 2020 02:40:48 +0000", "Message-ID": "\n <8CE3E05A3F976642AAB0F4675D0AD20E0BC84119@SHSMSX101.ccr.corp.intel.com>", "References": "<1595287665-21936-1-git-send-email-lihongx.ma@intel.com>", "In-Reply-To": "<1595287665-21936-1-git-send-email-lihongx.ma@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.2.0.6", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"iso-2022-jp\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dts] [PATCH V1] framework: get apps name of current build type\n in\tvirt_dut", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "addressed": null } ]