Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/72460/?format=api
{ "id": 72460, "url": "https://patches.dpdk.org/api/patches/72460/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200630141433.818517-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200630141433.818517-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200630141433.818517-5-bruce.richardson@intel.com", "date": "2020-06-30T14:14:30", "name": "[v3,4/7] build: move pkg-config creation to separate file", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d959df694cd5cec5e0188682a49a90cf3d94e9f2", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200630141433.818517-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 10690, "url": "https://patches.dpdk.org/api/series/10690/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10690", "date": "2020-06-30T14:14:26", "name": "improve DPDK static builds with meson", "version": 3, "mbox": "https://patches.dpdk.org/series/10690/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/72460/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/72460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B0D2A0350;\n\tTue, 30 Jun 2020 16:16:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A85BC1BFE6;\n\tTue, 30 Jun 2020 16:15:20 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id CCA571BF8D\n for <dev@dpdk.org>; Tue, 30 Jun 2020 16:15:18 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jun 2020 07:15:17 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.84])\n by fmsmga004.fm.intel.com with ESMTP; 30 Jun 2020 07:15:15 -0700" ], "IronPort-SDR": [ "\n 7YNjTL2LgtxW6KLPN3KvPsMNW5LeMQ11cDRLhm4yEbRjmAuhxfAZprm6fLMz18IktfcntoO6to\n Ze6opZqHvOVw==", "\n UOs225pdoTFzrPrZvjw2ms+WkYETibOJXOdIhSdgi6feFAMwQXrgRH/iexLM+VmFHj0Igvu7eB\n jEALbJl+dc9A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9666\"; a=\"147784748\"", "E=Sophos;i=\"5.75,297,1589266800\"; d=\"scan'208\";a=\"147784748\"", "E=Sophos;i=\"5.75,297,1589266800\"; d=\"scan'208\";a=\"303471536\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com, ktraynor@redhat.com,\n bluca@debian.org, sunil.pai.g@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 30 Jun 2020 15:14:30 +0100", "Message-Id": "<20200630141433.818517-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200630141433.818517-1-bruce.richardson@intel.com>", "References": "<20200429100831.398-1-bruce.richardson@intel.com>\n <20200630141433.818517-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/7] build: move pkg-config creation to\n\tseparate file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ahead of changes to rework the file, move the pkg-config file generation to\na new directory under buildtools. This allows the meson code to be\nseparated out from the main meson.build for simplicity, and also allows any\nadditional scripts for working with the pkg-config files to be placed there\ntoo.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\nAcked-by: Sunil Pai G <sunil.pai.g@intel.com>\n---\n buildtools/pkg-config/meson.build | 26 ++++++++++++++++++++++++++\n meson.build | 25 ++-----------------------\n 2 files changed, 28 insertions(+), 23 deletions(-)\n create mode 100644 buildtools/pkg-config/meson.build", "diff": "diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build\nnew file mode 100644\nindex 000000000..85d59972d\n--- /dev/null\n+++ b/buildtools/pkg-config/meson.build\n@@ -0,0 +1,26 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2020 Intel Corporation\n+\n+# for static builds, include the drivers as libs and we need to \"whole-archive\"\n+# them.\n+dpdk_drivers = ['-Wl,--whole-archive'] + dpdk_drivers + ['-Wl,--no-whole-archive']\n+\n+pkg = import('pkgconfig')\n+pkg_extra_cflags = ['-include', 'rte_config.h'] + machine_args\n+if is_freebsd\n+\tpkg_extra_cflags += ['-D__BSD_VISIBLE']\n+endif\n+pkg.generate(name: meson.project_name(),\n+\tfilebase: 'lib' + meson.project_name().to_lower(),\n+\tversion: meson.project_version(),\n+\tlibraries: dpdk_libraries,\n+\tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n+\t\t\t['-Wl,-Bdynamic'] + dpdk_extra_ldflags,\n+\trequires: libbsd, # apps using rte_string_fns.h may need this if enabled\n+\t # if libbsd is not enabled, then this is blank\n+\tdescription: '''The Data Plane Development Kit (DPDK).\n+Note that CFLAGS might contain an -march flag higher than typical baseline.\n+This is required for a number of static inline functions in the public headers.''',\n+\tsubdirs: [get_option('include_subdir_arch'), '.'],\n+\textra_cflags: pkg_extra_cflags\n+)\ndiff --git a/meson.build b/meson.build\nindex d6ca58b85..d21adfd30 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -70,29 +70,8 @@ configure_file(output: build_cfg,\n \t\tinstall_dir: join_paths(get_option('includedir'),\n \t\t\t\tget_option('include_subdir_arch')))\n \n-# for static builds, include the drivers as libs and we need to \"whole-archive\"\n-# them.\n-dpdk_drivers = ['-Wl,--whole-archive'] + dpdk_drivers + ['-Wl,--no-whole-archive']\n-\n-pkg = import('pkgconfig')\n-pkg_extra_cflags = ['-include', 'rte_config.h'] + machine_args\n-if is_freebsd\n-\tpkg_extra_cflags += ['-D__BSD_VISIBLE']\n-endif\n-pkg.generate(name: meson.project_name(),\n-\tfilebase: 'lib' + meson.project_name().to_lower(),\n-\tversion: meson.project_version(),\n-\tlibraries: dpdk_libraries,\n-\tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n-\t\t\t['-Wl,-Bdynamic'] + dpdk_extra_ldflags,\n-\trequires: libbsd, # apps using rte_string_fns.h may need this if enabled\n-\t # if libbsd is not enabled, then this is blank\n-\tdescription: '''The Data Plane Development Kit (DPDK).\n-Note that CFLAGS might contain an -march flag higher than typical baseline.\n-This is required for a number of static inline functions in the public headers.''',\n-\tsubdirs: [get_option('include_subdir_arch'), '.'],\n-\textra_cflags: pkg_extra_cflags\n-)\n+# build pkg-config files for dpdk\n+subdir('buildtools/pkg-config')\n \n # final output, list all the libs and drivers to be built\n # this does not affect any part of the build, for information only.\n", "prefixes": [ "v3", "4/7" ] }