Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/71757/?format=api
{ "id": 71757, "url": "https://patches.dpdk.org/api/patches/71757/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1592507300-442031-1-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1592507300-442031-1-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1592507300-442031-1-git-send-email-matan@mellanox.com", "date": "2020-06-18T19:08:20", "name": "vhost: fix features definition location", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "44dc45a8677d147cf7dcd672d7e1cf3a9e23b26d", "submitter": { "id": 796, "url": "https://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1592507300-442031-1-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 10510, "url": "https://patches.dpdk.org/api/series/10510/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=10510", "date": "2020-06-18T19:08:20", "name": "vhost: fix features definition location", "version": 1, "mbox": "https://patches.dpdk.org/series/10510/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/71757/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/71757/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BDA4BA04F1;\n\tThu, 18 Jun 2020 21:08:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 151E31BFFF;\n\tThu, 18 Jun 2020 21:08:27 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 47EDE1BFD1\n for <dev@dpdk.org>; Thu, 18 Jun 2020 21:08:25 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@mellanox.com) with SMTP; 18 Jun 2020 22:08:24 +0300", "from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx\n [10.210.16.10])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 05IJ8OZY004278;\n Thu, 18 Jun 2020 22:08:24 +0300" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "dev@dpdk.org, stable@dpdk.org", "Date": "Thu, 18 Jun 2020 19:08:20 +0000", "Message-Id": "<1592507300-442031-1-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1591113208-79169-2-git-send-email-matan@mellanox.com>", "References": "<1591113208-79169-2-git-send-email-matan@mellanox.com>", "Subject": "[dpdk-dev] [PATCH] vhost: fix features definition location", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vhost library provide an infrastructure in order to help the DPDK\nusers to manage vhost devices.\n\nOne of the infrastructure parts is the features enablement APIs.\n\nSome features bits may be defined only in the internal file vhost.h in\ncase the kernel version doesn't include them.\n\nHence, user running on old kernel may not be able to manage thus\nfeatures.\n\nMove all the feature bits definitions to the API file rte_vhost.h.\n\nFixes: db69be54b6ff (\"vhost: hide internal code\")\nFixes: 8d286dbeb8d7 (\"vhost: fix multiple queue not enabled for old kernels\")\nFixes: 3d3c6590b58c (\"vhost: enable virtio MTU feature\")\nFixes: 704098fc478c (\"vhost: fix build with old kernels\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n lib/librte_vhost/rte_vhost.h | 17 +++++++++++++++++\n lib/librte_vhost/vhost.h | 17 -----------------\n 2 files changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h\nindex d43669f..329ed8a 100644\n--- a/lib/librte_vhost/rte_vhost.h\n+++ b/lib/librte_vhost/rte_vhost.h\n@@ -36,6 +36,23 @@\n /* support only linear buffers (no chained mbufs) */\n #define RTE_VHOST_USER_LINEARBUF_SUPPORT\t(1ULL << 6)\n \n+/* Features. */\n+#ifndef VIRTIO_NET_F_GUEST_ANNOUNCE\n+ #define VIRTIO_NET_F_GUEST_ANNOUNCE 21\n+#endif\n+\n+#ifndef VIRTIO_NET_F_MQ\n+ #define VIRTIO_NET_F_MQ\t\t22\n+#endif\n+\n+#ifndef VIRTIO_NET_F_MTU\n+ #define VIRTIO_NET_F_MTU 3\n+#endif\n+\n+#ifndef VIRTIO_F_ANY_LAYOUT\n+ #define VIRTIO_F_ANY_LAYOUT\t\t27\n+#endif\n+\n /** Protocol features. */\n #ifndef VHOST_USER_PROTOCOL_F_MQ\n #define VHOST_USER_PROTOCOL_F_MQ\t0\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex df98d15..17f1e9a 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -202,26 +202,9 @@ struct vhost_virtqueue {\n \tTAILQ_HEAD(, vhost_iotlb_entry) iotlb_pending_list;\n } __rte_cache_aligned;\n \n-/* Old kernels have no such macros defined */\n-#ifndef VIRTIO_NET_F_GUEST_ANNOUNCE\n- #define VIRTIO_NET_F_GUEST_ANNOUNCE 21\n-#endif\n-\n-#ifndef VIRTIO_NET_F_MQ\n- #define VIRTIO_NET_F_MQ\t\t22\n-#endif\n-\n #define VHOST_MAX_VRING\t\t\t0x100\n #define VHOST_MAX_QUEUE_PAIRS\t\t0x80\n \n-#ifndef VIRTIO_NET_F_MTU\n- #define VIRTIO_NET_F_MTU 3\n-#endif\n-\n-#ifndef VIRTIO_F_ANY_LAYOUT\n- #define VIRTIO_F_ANY_LAYOUT\t\t27\n-#endif\n-\n /* Declare IOMMU related bits for older kernels */\n #ifndef VIRTIO_F_IOMMU_PLATFORM\n \n", "prefixes": [] }