Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6995/?format=api
{ "id": 6995, "url": "https://patches.dpdk.org/api/patches/6995/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1441859917-26475-18-git-send-email-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441859917-26475-18-git-send-email-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1441859917-26475-18-git-send-email-xiao.w.wang@intel.com", "date": "2015-09-10T04:38:26", "name": "[dpdk-dev,17/28] fm10k: store actual count of DWORDS pulled/pushed from mbmem", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c9fc01e1d769c14b4a10d487ebee666f79115e6c", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1441859917-26475-18-git-send-email-xiao.w.wang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6995/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C8BCC91C0;\n\tThu, 10 Sep 2015 06:39:26 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 8F6808E85\n\tfor <dev@dpdk.org>; Thu, 10 Sep 2015 06:39:25 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 09 Sep 2015 21:39:24 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 09 Sep 2015 21:39:23 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t8A4dL6I007413;\n\tThu, 10 Sep 2015 12:39:21 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t8A4dH6X026630; Thu, 10 Sep 2015 12:39:19 +0800", "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t8A4dHtl026626; \n\tThu, 10 Sep 2015 12:39:17 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,501,1437462000\"; d=\"scan'208\";a=\"801367789\"", "From": "Wang Xiao W <xiao.w.wang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 10 Sep 2015 12:38:26 +0800", "Message-Id": "<1441859917-26475-18-git-send-email-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1441859917-26475-1-git-send-email-xiao.w.wang@intel.com>", "References": "<1441859917-26475-1-git-send-email-xiao.w.wang@intel.com>", "Cc": "Wang Xiao W <xiao.w.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH 17/28] fm10k: store actual count of DWORDS\n\tpulled/pushed from mbmem", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A previous bug was uncovered by addition of a debug stat to indicate the\nactual number of DWORDS we pulled from the mbmem. It turned out this was\nnot the same as the tx_dwords counter. While the previous bug fix should\nhave corrected this in all cases, add some debug stats that count the\nnumber of DWORDs pushed or pulled from the mbmem. Base drivers can use\nthis in debug builds to help detect this problem in the future.\n\nSigned-off-by: Wang Xiao W <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_mbx.c | 4 ++++\n drivers/net/fm10k/base/fm10k_mbx.h | 2 ++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c\nindex ad9d81a..c6d34eb 100644\n--- a/drivers/net/fm10k/base/fm10k_mbx.c\n+++ b/drivers/net/fm10k/base/fm10k_mbx.c\n@@ -394,6 +394,8 @@ STATIC void fm10k_mbx_write_copy(struct fm10k_hw *hw,\n \t\t\tif (!tail)\n \t\t\t\ttail++;\n \n+\t\t\tmbx->tx_mbmem_pulled++;\n+\n \t\t\t/* write message to hardware FIFO */\n \t\t\tFM10K_WRITE_MBX(hw, mbmem + tail++, *(head++));\n \t\t} while (--len && --end);\n@@ -480,6 +482,8 @@ STATIC void fm10k_mbx_read_copy(struct fm10k_hw *hw,\n \t\t\tif (!head)\n \t\t\t\thead++;\n \n+\t\t\tmbx->rx_mbmem_pushed++;\n+\n \t\t\t/* read message from hardware FIFO */\n \t\t\t*(tail++) = FM10K_READ_MBX(hw, mbmem + head++);\n \t\t} while (--len && --end);\ndiff --git a/drivers/net/fm10k/base/fm10k_mbx.h b/drivers/net/fm10k/base/fm10k_mbx.h\nindex 6332584..4b22f0e 100644\n--- a/drivers/net/fm10k/base/fm10k_mbx.h\n+++ b/drivers/net/fm10k/base/fm10k_mbx.h\n@@ -313,8 +313,10 @@ struct fm10k_mbx_info {\n \tu64 tx_dropped;\n \tu64 tx_messages;\n \tu64 tx_dwords;\n+\tu64 tx_mbmem_pulled;\n \tu64 rx_messages;\n \tu64 rx_dwords;\n+\tu64 rx_mbmem_pushed;\n \tu64 rx_parse_err;\n \n \t/* Buffer to store messages */\n", "prefixes": [ "dpdk-dev", "17/28" ] }