Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69546/?format=api
{ "id": 69546, "url": "https://patches.dpdk.org/api/patches/69546/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200429111328.64952-5-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200429111328.64952-5-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200429111328.64952-5-huwei013@chinasoftinc.com", "date": "2020-04-29T11:13:26", "name": "[4/6] net/hns3: fix VLAN pvid when configuring device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ee39d9db124fd33adb567e7a90712a8b760b6ae7", "submitter": { "id": 1537, "url": "https://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200429111328.64952-5-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 9733, "url": "https://patches.dpdk.org/api/series/9733/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9733", "date": "2020-04-29T11:13:22", "name": "misc updates and bugfixes for hns3 PMD driver", "version": 1, "mbox": "https://patches.dpdk.org/series/9733/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/69546/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/69546/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B672BA00BE;\n\tWed, 29 Apr 2020 13:14:24 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E729A1DA59;\n\tWed, 29 Apr 2020 13:14:03 +0200 (CEST)", "from mail.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id B17121DA4A\n for <dev@dpdk.org>; Wed, 29 Apr 2020 13:13:56 +0200 (CEST)", "from localhost.localdomain (114.119.4.74) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Wed, 29 Apr 2020\n 19:13:39 +0800" ], "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Wed, 29 Apr 2020 19:13:26 +0800", "Message-ID": "<20200429111328.64952-5-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200429111328.64952-1-huwei013@chinasoftinc.com>", "References": "<20200429111328.64952-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[114.119.4.74]", "Subject": "[dpdk-dev] [PATCH 4/6] net/hns3: fix VLAN pvid when configuring\n\tdevice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Min Hu (Connor)\" <humin29@huawei.com>\n\nIn current version, when upper level application calls the\nrte_eth_dev_configure API function, if pvid config is not set of the\ninput parameter which struct type is rte_eth_conf, hns3 pmd driver also\nsets the VLAN pvid related configuration to hardware, and this is not\nreasonable. For example, As pvid is set to 100 by\nrte_eth_dev_set_vlan_pvid, when pvid config is not set in rte_eth_conf,\nrte_eth_dev_configure will tell driver to delete pvid 0, and that is\nmeaningless.\n\nThis patch fixes it to ensure that driver does not set VLAN pvid related\nconfiguration to hardware when pvid config is not set in rte_eth_conf.\n\nFixes: 411d23b9eafb (\"net/hns3: support VLAN\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex ae87aa0dd..1fac4f366 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -1059,6 +1059,13 @@ hns3_dev_configure_vlan(struct rte_eth_dev *dev)\n \t\treturn ret;\n \t}\n \n+\t/*\n+\t * If pvid config is not set in rte_eth_conf, driver needn't to set\n+\t * VLAN pvid related configuration to hardware.\n+\t */\n+\tif (txmode->pvid == 0 && txmode->hw_vlan_insert_pvid == 0)\n+\t\treturn 0;\n+\n \t/* Apply pvid setting */\n \tret = hns3_vlan_pvid_set(dev, txmode->pvid,\n \t\t\t\t txmode->hw_vlan_insert_pvid);\n", "prefixes": [ "4/6" ] }