Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 68737,
    "url": "https://patches.dpdk.org/api/patches/68737/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1587108644-456343-1-git-send-email-bingz@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1587108644-456343-1-git-send-email-bingz@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1587108644-456343-1-git-send-email-bingz@mellanox.com",
    "date": "2020-04-17T07:30:44",
    "name": "net/mlx5: fix the empty flow error structure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5cbfefbf854885b70d1e4109093ffc94ca6758e7",
    "submitter": {
        "id": 1357,
        "url": "https://patches.dpdk.org/api/people/1357/?format=api",
        "name": "Bing Zhao",
        "email": "bingz@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "https://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1587108644-456343-1-git-send-email-bingz@mellanox.com/mbox/",
    "series": [
        {
            "id": 9453,
            "url": "https://patches.dpdk.org/api/series/9453/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9453",
            "date": "2020-04-17T07:30:44",
            "name": "net/mlx5: fix the empty flow error structure",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/9453/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/68737/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/68737/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE0E5A058A;\n\tFri, 17 Apr 2020 09:30:50 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C3CD01DCFC;\n\tFri, 17 Apr 2020 09:30:49 +0200 (CEST)",
            "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 387691DCF8\n for <dev@dpdk.org>; Fri, 17 Apr 2020 09:30:48 +0200 (CEST)"
        ],
        "From": "Bing Zhao <bingz@mellanox.com>",
        "To": "orika@mellanox.com,\n\tviacheslavo@mellanox.com,\n\trasland@mellanox.com",
        "Cc": "matan@mellanox.com,\n\tdev@dpdk.org",
        "Date": "Fri, 17 Apr 2020 15:30:44 +0800",
        "Message-Id": "<1587108644-456343-1-git-send-email-bingz@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix the empty flow error structure",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The output flow error parameter is used to indicate the detailed\nreason of the failure when calling a rte_flow_* interface. Even\nthough sometimes the application will not check it or use it, the PMD\nmust fill it in the failure branch before returning. Or else, some\ndirty value in the stack, heap will be accessed as a pointer and then\ncause a crash.\nIn this case, when a port is stopped, it is not allowed to insert a\nflow from application. The detailed error information should be\nfilled. If the application needs to check the detailed error reason,\nit will get the information but not result in any crash.\n\nFixes: 6ec024870715 (\"net/mlx5: check device stat before creating flow\")\n\nSigned-off-by: Bing Zhao <bingz@mellanox.com>\nAcked-by: Ori Kam <orika@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex c529aa3..6a5522c 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -4490,9 +4490,12 @@ struct rte_flow *\n \t * are not affected.\n \t */\n \tif (unlikely(!dev->data->dev_started)) {\n-\t\trte_errno = ENODEV;\n \t\tDRV_LOG(DEBUG, \"port %u is not started when \"\n \t\t\t\"inserting a flow\", dev->data->port_id);\n+\t\trte_flow_error_set(error, ENODEV,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t   NULL,\n+\t\t\t\t   \"port not started\");\n \t\treturn NULL;\n \t}\n \treturn (void *)(uintptr_t)flow_list_create(dev, &priv->flows,\n",
    "prefixes": []
}