Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68193/?format=api
{ "id": 68193, "url": "https://patches.dpdk.org/api/patches/68193/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200411141428.1987768-4-jerinj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200411141428.1987768-4-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200411141428.1987768-4-jerinj@marvell.com", "date": "2020-04-11T14:14:02", "name": "[v5,03/29] graph: implement node operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "43c52b4c5e61d717ff7049e9ed2d89395883d2be", "submitter": { "id": 1188, "url": "https://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200411141428.1987768-4-jerinj@marvell.com/mbox/", "series": [ { "id": 9314, "url": "https://patches.dpdk.org/api/series/9314/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9314", "date": "2020-04-11T14:13:59", "name": "graph: introduce graph subsystem", "version": 5, "mbox": "https://patches.dpdk.org/series/9314/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/68193/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/68193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 052D8A059F;\n\tSat, 11 Apr 2020 16:15:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F6221C1D0;\n\tSat, 11 Apr 2020 16:14:37 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 234171C1D0\n for <dev@dpdk.org>; Sat, 11 Apr 2020 16:14:35 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03BEAD37016867; Sat, 11 Apr 2020 07:14:34 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 30bb8q8n31-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2020 07:14:34 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sat, 11 Apr 2020 07:14:32 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 11 Apr 2020 07:14:32 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id A8F713F7041;\n Sat, 11 Apr 2020 07:14:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=SejXCAfbd48RN7DR8gzzLgrVuScfxCQQpWZug239V9s=;\n b=vhBH48EbHjDwFffO+Oo4JTCl2dc0wLbOTl2UeAZxH34NMBiVeWh52isYdJdYpUplRXl2\n mI13167VbNF3C48dL4yLzlrqTO2V/rp4nDaHE8Fn4V7aresg2cAdasACuH9GcUsQlGIE\n V3s7ENI7gJqzxxGnRMhlh/nQ7sIT8DD/tHKD5bq6HQIAma37gznmveb2ct8MlzK7y2YI\n Aeh45AQ9shWaoQwOPu7fvhsY6bmD3Ifs/uURstAJxIDE+/vrH7HQRvfq2K/WLfjmzbL+\n Ig7aJaVwHuSIvKoUe4lnTFsYa3g12GGS0ewospVu0Hnvoaqyq7pmht/2NZ2A/QWJhwG1 BA==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <mdr@ashroe.eu>, <mattias.ronnblom@ericsson.com>,\n <pbhagavatula@marvell.com>, <ndabilpuram@marvell.com>,\n <xiao.w.wang@intel.com>, <amo@semihalf.com>", "Date": "Sat, 11 Apr 2020 19:44:02 +0530", "Message-ID": "<20200411141428.1987768-4-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200411141428.1987768-1-jerinj@marvell.com>", "References": "<20200405085613.1336841-1-jerinj@marvell.com>\n <20200411141428.1987768-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-11_04:2020-04-09,\n 2020-04-11 signatures=0", "Subject": "[dpdk-dev] [PATCH v5 03/29] graph: implement node operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdding node-specific API implementation like cloning node, updating\nedges for the node, shrinking edges of a node, retrieving edges of a\nnode.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n lib/librte_graph/graph_private.h | 10 +\n lib/librte_graph/node.c | 271 +++++++++++++++++++++++++\n lib/librte_graph/rte_graph_version.map | 10 +\n 3 files changed, 291 insertions(+)", "diff": "diff --git a/lib/librte_graph/graph_private.h b/lib/librte_graph/graph_private.h\nindex 8b9ff5292..7ed6d01b6 100644\n--- a/lib/librte_graph/graph_private.h\n+++ b/lib/librte_graph/graph_private.h\n@@ -13,6 +13,16 @@\n \n #include \"rte_graph.h\"\n \n+\n+#define ID_CHECK(id, id_max) \\\n+\tdo { \\\n+\t\tif ((id) >= (id_max)) { \\\n+\t\t\trte_errno = EINVAL; \\\n+\t\t\tgoto fail; \\\n+\t\t} \\\n+\t} while (0)\n+\n+\n /**\n * @internal\n *\ndiff --git a/lib/librte_graph/node.c b/lib/librte_graph/node.c\nindex 336cd1c94..392e534a9 100644\n--- a/lib/librte_graph/node.c\n+++ b/lib/librte_graph/node.c\n@@ -17,6 +17,8 @@\n static struct node_head node_list = STAILQ_HEAD_INITIALIZER(node_list);\n static rte_node_t node_id;\n \n+#define NODE_ID_CHECK(id) ID_CHECK(id, node_id)\n+\n /* Private functions */\n struct node_head *\n node_list_head_get(void)\n@@ -111,3 +113,272 @@ __rte_node_register(const struct rte_node_register *reg)\n \treturn RTE_NODE_ID_INVALID;\n }\n \n+static int\n+clone_name(struct rte_node_register *reg, struct node *node, const char *name)\n+{\n+\tssize_t sz, rc;\n+\n+#define SZ RTE_NODE_NAMESIZE\n+\trc = rte_strscpy(reg->name, node->name, SZ);\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz = rc;\n+\trc = rte_strscpy(reg->name + sz, \"-\", RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz += rc;\n+\tsz = rte_strscpy(reg->name + sz, name, RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (sz < 0)\n+\t\tgoto fail;\n+\n+\treturn 0;\n+fail:\n+\trte_errno = E2BIG;\n+\treturn -rte_errno;\n+}\n+\n+static rte_node_t\n+node_clone(struct node *node, const char *name)\n+{\n+\trte_node_t rc = RTE_NODE_ID_INVALID;\n+\tstruct rte_node_register *reg;\n+\trte_edge_t i;\n+\n+\t/* Don't allow to clone a node from a cloned node */\n+\tif (node->parent_id != RTE_NODE_ID_INVALID) {\n+\t\trte_errno = EEXIST;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Check for duplicate name */\n+\tif (node_has_duplicate_entry(name))\n+\t\tgoto fail;\n+\n+\treg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));\n+\tif (reg == NULL) {\n+\t\trte_errno = ENOMEM;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Clone the source node */\n+\treg->flags = node->flags;\n+\treg->process = node->process;\n+\treg->init = node->init;\n+\treg->fini = node->fini;\n+\treg->nb_edges = node->nb_edges;\n+\treg->parent_id = node->id;\n+\n+\tfor (i = 0; i < node->nb_edges; i++)\n+\t\treg->next_nodes[i] = node->next_nodes[i];\n+\n+\t/* Naming ceremony of the new node. name is node->name + \"-\" + name */\n+\tif (clone_name(reg, node, name))\n+\t\tgoto free;\n+\n+\trc = __rte_node_register(reg);\n+free:\n+\tfree(reg);\n+fail:\n+\treturn rc;\n+}\n+\n+rte_node_t\n+rte_node_clone(rte_node_t id, const char *name)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node_clone(node, name);\n+\n+fail:\n+\treturn RTE_NODE_ID_INVALID;\n+}\n+\n+rte_node_t\n+rte_node_from_name(const char *name)\n+{\n+\tstruct node *node;\n+\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (strncmp(node->name, name, RTE_NODE_NAMESIZE) == 0)\n+\t\t\treturn node->id;\n+\n+\treturn RTE_NODE_ID_INVALID;\n+}\n+\n+char *\n+rte_node_id_to_name(rte_node_t id)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node->name;\n+\n+fail:\n+\treturn NULL;\n+}\n+\n+rte_edge_t\n+rte_node_edge_count(rte_node_t id)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node->nb_edges;\n+fail:\n+\treturn RTE_EDGE_ID_INVALID;\n+}\n+\n+static rte_edge_t\n+edge_update(struct node *node, struct node *prev, rte_edge_t from,\n+\t const char **next_nodes, rte_edge_t nb_edges)\n+{\n+\trte_edge_t i, max_edges, count = 0;\n+\tstruct node *new_node;\n+\tbool need_realloc;\n+\tsize_t sz;\n+\n+\tif (from == RTE_EDGE_ID_INVALID)\n+\t\tfrom = node->nb_edges;\n+\n+\t/* Don't create hole in next_nodes[] list */\n+\tif (from > node->nb_edges) {\n+\t\trte_errno = ENOMEM;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Remove me from list */\n+\tSTAILQ_REMOVE(&node_list, node, node, next);\n+\n+\t/* Allocate the storage space for new node if required */\n+\tmax_edges = from + nb_edges;\n+\tneed_realloc = max_edges > node->nb_edges;\n+\tif (need_realloc) {\n+\t\tsz = sizeof(struct node) + (max_edges * RTE_NODE_NAMESIZE);\n+\t\tnew_node = realloc(node, sz);\n+\t\tif (new_node == NULL) {\n+\t\t\trte_errno = ENOMEM;\n+\t\t\tgoto restore;\n+\t\t} else {\n+\t\t\tnode = new_node;\n+\t\t}\n+\t}\n+\n+\t/* Update the new nodes name */\n+\tfor (i = from; i < max_edges; i++, count++) {\n+\t\tif (rte_strscpy(node->next_nodes[i], next_nodes[count],\n+\t\t\t\tRTE_NODE_NAMESIZE) < 0) {\n+\t\t\trte_errno = E2BIG;\n+\t\t\tgoto restore;\n+\t\t}\n+\t}\n+restore:\n+\t/* Update the linked list to point new node address in prev node */\n+\tif (prev)\n+\t\tSTAILQ_INSERT_AFTER(&node_list, prev, node, next);\n+\telse\n+\t\tSTAILQ_INSERT_HEAD(&node_list, node, next);\n+\n+\tif (need_realloc)\n+\t\tnode->nb_edges = max_edges;\n+\n+fail:\n+\treturn count;\n+}\n+\n+rte_edge_t\n+rte_node_edge_shrink(rte_node_t id, rte_edge_t size)\n+{\n+\trte_edge_t rc = RTE_EDGE_ID_INVALID;\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tSTAILQ_FOREACH(node, &node_list, next) {\n+\t\tif (node->id == id) {\n+\t\t\tif (node->nb_edges < size) {\n+\t\t\t\trte_errno = E2BIG;\n+\t\t\t\tgoto fail;\n+\t\t\t}\n+\t\t\tnode->nb_edges = size;\n+\t\t\trc = size;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+fail:\n+\tgraph_spinlock_unlock();\n+\treturn rc;\n+}\n+\n+rte_edge_t\n+rte_node_edge_update(rte_node_t id, rte_edge_t from, const char **next_nodes,\n+\t\t uint16_t nb_edges)\n+{\n+\trte_edge_t rc = RTE_EDGE_ID_INVALID;\n+\tstruct node *n, *prev;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tprev = NULL;\n+\tSTAILQ_FOREACH(n, &node_list, next) {\n+\t\tif (n->id == id) {\n+\t\t\trc = edge_update(n, prev, from, next_nodes, nb_edges);\n+\t\t\tbreak;\n+\t\t}\n+\t\tprev = n;\n+\t}\n+\n+\tgraph_spinlock_unlock();\n+fail:\n+\treturn rc;\n+}\n+\n+static rte_node_t\n+node_copy_edges(struct node *node, char *next_nodes[])\n+{\n+\trte_edge_t i;\n+\n+\tfor (i = 0; i < node->nb_edges; i++)\n+\t\tnext_nodes[i] = node->next_nodes[i];\n+\n+\treturn i;\n+}\n+\n+rte_node_t\n+rte_node_edge_get(rte_node_t id, char *next_nodes[])\n+{\n+\trte_node_t rc = RTE_NODE_ID_INVALID;\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tSTAILQ_FOREACH(node, &node_list, next) {\n+\t\tif (node->id == id) {\n+\t\t\tif (next_nodes == NULL)\n+\t\t\t\trc = sizeof(char *) * node->nb_edges;\n+\t\t\telse\n+\t\t\t\trc = node_copy_edges(node, next_nodes);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tgraph_spinlock_unlock();\n+fail:\n+\treturn rc;\n+}\n+\n+rte_node_t\n+rte_node_max_count(void)\n+{\n+\treturn node_id;\n+}\ndiff --git a/lib/librte_graph/rte_graph_version.map b/lib/librte_graph/rte_graph_version.map\nindex 0884c09f1..412386356 100644\n--- a/lib/librte_graph/rte_graph_version.map\n+++ b/lib/librte_graph/rte_graph_version.map\n@@ -3,5 +3,15 @@ EXPERIMENTAL {\n \n \t__rte_node_register;\n \n+\trte_node_clone;\n+\trte_node_edge_count;\n+\trte_node_edge_get;\n+\trte_node_edge_shrink;\n+\trte_node_edge_update;\n+\trte_node_from_name;\n+\trte_node_id_to_name;\n+\trte_node_list_dump;\n+\trte_node_max_count;\n+\n \tlocal: *;\n };\n", "prefixes": [ "v5", "03/29" ] }