Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67947/?format=api
{ "id": 67947, "url": "https://patches.dpdk.org/api/patches/67947/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-12-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200408031351.4288-12-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200408031351.4288-12-l.wojciechow@partner.samsung.com", "date": "2020-04-08T03:13:49", "name": "[v2,11/13] app/test: add rte security get userdata tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1cc690192094d031a3613b53d30fde064b9f9b71", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200408031351.4288-12-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9242, "url": "https://patches.dpdk.org/api/series/9242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=9242", "date": "2020-04-08T03:13:38", "name": "Fixes and unit tests for librte_security", "version": 2, "mbox": "https://patches.dpdk.org/series/9242/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/67947/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/67947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CDE53A0597;\n\tWed, 8 Apr 2020 05:16:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 160171C0C2;\n\tWed, 8 Apr 2020 05:15:06 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 7B4691BFEF\n for <dev@dpdk.org>; Wed, 8 Apr 2020 05:14:54 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200408031454euoutp02461fba4d8a6a38a53e20a9e7013ec59c~DubgmGGs_2216822168euoutp02H\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200408031454eucas1p25b550bef399e438bee71be4aef454d99~Dubgg7stK3007630076eucas1p2r\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:54 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 3A.47.60679.EA14D8E5; Wed, 8\n Apr 2020 04:14:54 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b~Dubf9_6wl2413824138eucas1p1X\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200408031453eusmtrp24602df414e9119f843ccb3b218dcbda1~Dubf9hL3M2369123691eusmtrp2C\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id A2.DA.08375.DA14D8E5; Wed, 8\n Apr 2020 04:14:53 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200408031453eusmtip1bba9834aca0dff7b7e1224ec30ce467c~Dubfno23-2835528355eusmtip1h\n for <dev@dpdk.org>; Wed, 8 Apr 2020 03:14:53 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200408031454euoutp02461fba4d8a6a38a53e20a9e7013ec59c~DubgmGGs_2216822168euoutp02H", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586315694;\n bh=8VegCETjPiT4EPKmJx9B77YVijkzsbz01Ic1CnoLdUI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=M+eoWrMVA2Yk7d1/mpCgYGtQCGOqslhP+N/MGsUEc1F+hZh+X+81VIclSKFeC4ZiI\n vWrHw5vt0vSQitmZtJGRG4+Wx8EWH6VeePiTI+OFa0fXUdFNR2X5uN/YnwJz6dbRe7\n e3PLtP+8zcPQMyxyCuYvXHrK38wtV599Zpy6d6Dc=", "X-AuditID": "cbfec7f4-0e5ff7000001ed07-61-5e8d41ae6c64", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Wed, 8 Apr 2020 05:13:49 +0200", "Message-Id": "<20200408031351.4288-12-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsWy7djPc7rrHHvjDKafY7d492k7kwOjx68F\n S1kDGKO4bFJSczLLUov07RK4Mlbvb2Mq2GhdMXnbc+YGxmuGXYycHBICJhKnn31l7GLk4hAS\n WMEoMfP+RRYIp51JYt/l2+wgVUICbUwS7Rs8YToOT9nIClG0nFFiy4ReZggHqOj5nV9sIFVs\n ArYSR2Z+ZQWxRQRYJFZ+/84CYjMLCEg8vvcMLC4s4C5xY+NFMJtFQFVix+susBpeAVeJ61/e\n MENsk5dYveEAkM3BwQkU332WC2SXhMAKNokFF+eyQdS4SGz7cR+qXlji1fEt7BC2jMT/nfOZ\n IBq2MUpc/f2TEcLZzyhxvXcFVJW1xOF/v9lANjALaEqs36UPEXaU+HtmEVhYQoBP4sZbQYj7\n +SQmbZvODBHmlehoE4Ko1pN42jOVEWbtn7VPWCBsD4l993dBQ/Qyo8SxmdvYJjDKz0JYtoCR\n cRWjeGppcW56arFRXmq5XnFibnFpXrpecn7uJkZgDJ/+d/zLDsZdf5IOMQpwMCrx8D5I7IkT\n Yk0sK67MPcQowcGsJMIr1dsZJ8SbklhZlVqUH19UmpNafIhRmoNFSZzXeNHLWCGB9MSS1OzU\n 1ILUIpgsEwenVAPjcn7D/WeWzNnKnJMX6HfrzJSoVb9rtF9I39755s8h7TX5+8z5Wx7xLn0U\n uLKmIeLCw7MvL+mydTi41pxie7xjF+tSxsPLtSJvL2n4rPrh26LCPWHGdo7GiW2JBb9ZTrH8\n M80K2N3J6DlxYu/Jp7Ev+k0F5Xn7utoTOOrf+bo3F0xib3RjVfuqxFKckWioxVxUnAgALmtf\n H90CAAA=", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7prHXvjDPadVbJ492k7kwOjx68F\n S1kDGKP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0\n Mlbvb2Mq2GhdMXnbc+YGxmuGXYycHBICJhKHp2xk7WLk4hASWMoocX3Va+YuRg6ghIzEh0sC\n EDXCEn+udbFB1LQwSdy7uZEJJMEmYCtxZOZXVhBbRIBFYuX37ywgNrOAgMTje8/A4sIC7hI3\n Nl4Es1kEVCV2vO4Cq+EVcJW4/uUNM8QCeYnVGw6A7eUEiu8+ywUSFhKolzh89zLbBEa+BYwM\n qxhFUkuLc9Nziw31ihNzi0vz0vWS83M3MQLDaduxn5t3MF7aGHyIUYCDUYmH90FiT5wQa2JZ\n cWXuIUYJDmYlEV6p3s44Id6UxMqq1KL8+KLSnNTiQ4ymQDdNZJYSTc4HhnpeSbyhqaG5haWh\n ubG5sZmFkjhvh8DBGCGB9MSS1OzU1ILUIpg+Jg5OqQZGzoYj9WclypRNVvmZWHLrGjH/Xxy/\n fu0vvplaDw6oCrsXdUys//487ccOixPuE7qFOQO8zqsFNGz7FX5vbjvn6ZuVJ8/J3Zr/Oncb\n 6/KiRZqd2U/M0ic8nL9O/b1B4Mzvp0+Kn07aI5J38+8cXhmrix+bdtU+1q1I2rFoR0G4ZCWj\n m5+TdbWHEktxRqKhFnNRcSIA4aT0Sz0CAAA=" ], "X-CMS-MailID": "20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b", "References": "<20200312151654.7218-1-l.wojciechow@partner.samsung.com>\n <20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <CGME20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v2 11/13] app/test: add rte security get userdata\n\ttests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_get_userdata function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 191 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 191 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex a1f0e7879..230b53891 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -76,6 +76,19 @@\n #define MOCK_TEST_ASSERT_EQUAL(fail_counter, a, b, msg, ...)\t\\\n \tMOCK_TEST_ASSERT(fail_counter, (a) == (b), msg, ##__VA_ARGS__)\n \n+/**\n+ * Verify not null condition inside mocked up function.\n+ * Mockup function cannot return a test error, so the failure\n+ * of assertion increases counter and print logs.\n+ * The counter can be verified later to check if test case should fail.\n+ *\n+ * @param fail_counter\tfail counter\n+ * @param val\tvalue expected not to be NULL\n+ * @param msg\tprintf style formatting string for custom message\n+ */\n+#define MOCK_TEST_ASSERT_NOT_NULL(fail_counter, val, msg, ...)\t\\\n+\tMOCK_TEST_ASSERT(fail_counter, (val) != NULL, msg, ##__VA_ARGS__)\n+\n \n /**\n * Verify if parameter of the mocked up function matches expected value.\n@@ -101,6 +114,15 @@\n #define MOCK_TEST_ASSERT_POINTER_PARAMETER(data, parameter)\t\\\n \tMOCK_TEST_ASSERT_PARAMETER(data, parameter, \"%p\")\n \n+/**\n+ * Wrap for MOCK_TEST_ASSERT_PARAMETER macro for uint64_t type parameters.\n+ *\n+ * @param data\tstructure with expected values\n+ * @param parameter\tname of the parameter (both field and parameter name)\n+ */\n+#define MOCK_TEST_ASSERT_U64_PARAMETER(data, parameter)\t\\\n+\tMOCK_TEST_ASSERT_PARAMETER(data, parameter, \"%\" PRIu64)\n+\n /**\n * Verify number of calls of the mocked up function\n * and check if there were any fails during execution.\n@@ -381,6 +403,43 @@ mock_set_pkt_metadata(void *device,\n \treturn mock_set_pkt_metadata_exp.ret;\n }\n \n+/**\n+ * get_userdata mockup\n+ *\n+ * Verified parameters: device, md.\n+ * The userdata parameter works as an output parameter, so a passed address\n+ * is verified not to be NULL and filled with userdata stored in structure.\n+ */\n+static struct mock_get_userdata_data {\n+\tvoid *device;\n+\tuint64_t md;\n+\tvoid *userdata;\n+\n+\tint ret;\n+\n+\tint called;\n+\tint failed;\n+} mock_get_userdata_exp = {NULL, 0UL, NULL, 0, 0, 0};\n+\n+static int\n+mock_get_userdata(void *device,\n+\t\tuint64_t md,\n+\t\tvoid **userdata)\n+{\n+\tmock_get_userdata_exp.called++;\n+\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_get_userdata_exp, device);\n+\tMOCK_TEST_ASSERT_U64_PARAMETER(mock_get_userdata_exp, md);\n+\n+\tMOCK_TEST_ASSERT_NOT_NULL(mock_get_userdata_exp.failed,\n+\t\t\tuserdata,\n+\t\t\t\"Expecting parameter userdata not to be NULL but it's %p\",\n+\t\t\tuserdata);\n+\t*userdata = mock_get_userdata_exp.userdata;\n+\n+\treturn mock_get_userdata_exp.ret;\n+}\n+\n /**\n * empty_ops\n *\n@@ -400,6 +459,7 @@ struct rte_security_ops mock_ops = {\n \t.session_stats_get = mock_session_stats_get,\n \t.session_destroy = mock_session_destroy,\n \t.set_pkt_metadata = mock_set_pkt_metadata,\n+\t.get_userdata = mock_get_userdata,\n };\n \n \n@@ -495,6 +555,7 @@ ut_setup(void)\n \tmock_session_stats_get_exp.called = 0;\n \tmock_session_destroy_exp.called = 0;\n \tmock_set_pkt_metadata_exp.called = 0;\n+\tmock_get_userdata_exp.called = 0;\n \n \tmock_session_create_exp.failed = 0;\n \tmock_session_update_exp.failed = 0;\n@@ -502,6 +563,7 @@ ut_setup(void)\n \tmock_session_stats_get_exp.failed = 0;\n \tmock_session_destroy_exp.failed = 0;\n \tmock_set_pkt_metadata_exp.failed = 0;\n+\tmock_get_userdata_exp.failed = 0;\n \n \treturn TEST_SUCCESS;\n }\n@@ -1478,6 +1540,124 @@ test_set_pkt_metadata_success(void)\n }\n \n \n+/**\n+ * rte_security_get_userdata tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_get_userdata with NULL instance\n+ */\n+static int\n+test_get_userdata_inv_context(void)\n+{\n+#ifdef RTE_LIBRTE_SECURITY_DEBUG\n+\tuint64_t md = 0xDEADBEEF;\n+\n+\tvoid *ret = rte_security_get_userdata(NULL, md);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+#else\n+\treturn TEST_SKIPPED;\n+#endif\n+}\n+\n+/**\n+ * Test execution of rte_security_get_userdata with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_get_userdata_inv_context_ops(void)\n+{\n+#ifdef RTE_LIBRTE_SECURITY_DEBUG\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tuint64_t md = 0xDEADBEEF;\n+\tut_params->ctx.ops = NULL;\n+\n+\tvoid *ret = rte_security_get_userdata(&ut_params->ctx, md);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+#else\n+\treturn TEST_SKIPPED;\n+#endif\n+}\n+\n+/**\n+ * Test execution of rte_security_get_userdata with empty\n+ * security operations\n+ */\n+static int\n+test_get_userdata_inv_context_ops_fun(void)\n+{\n+#ifdef RTE_LIBRTE_SECURITY_DEBUG\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tuint64_t md = 0xDEADBEEF;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tvoid *ret = rte_security_get_userdata(&ut_params->ctx, md);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+#else\n+\treturn TEST_SKIPPED;\n+#endif\n+}\n+\n+/**\n+ * Test execution of rte_security_get_userdata when get_userdata\n+ * security operation fails\n+ */\n+static int\n+test_get_userdata_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tuint64_t md = 0xDEADBEEF;\n+\tvoid *userdata = (void *)0x7E577E57;\n+\n+\tmock_get_userdata_exp.device = NULL;\n+\tmock_get_userdata_exp.md = md;\n+\tmock_get_userdata_exp.userdata = userdata;\n+\tmock_get_userdata_exp.ret = -1;\n+\n+\tvoid *ret = rte_security_get_userdata(&ut_params->ctx, md);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_get_userdata in successful execution path\n+ */\n+static int\n+test_get_userdata_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tuint64_t md = 0xDEADBEEF;\n+\tvoid *userdata = (void *)0x7E577E57;\n+\n+\tmock_get_userdata_exp.device = NULL;\n+\tmock_get_userdata_exp.md = md;\n+\tmock_get_userdata_exp.userdata = userdata;\n+\tmock_get_userdata_exp.ret = 0;\n+\n+\tvoid *ret = rte_security_get_userdata(&ut_params->ctx, md);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata,\n+\t\t\tret, userdata, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1568,6 +1748,17 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_set_pkt_metadata_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_get_userdata_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_get_userdata_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_get_userdata_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_get_userdata_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_get_userdata_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v2", "11/13" ] }