Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6609/?format=api
{ "id": 6609, "url": "https://patches.dpdk.org/api/patches/6609/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1437986559-31016-7-git-send-email-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1437986559-31016-7-git-send-email-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1437986559-31016-7-git-send-email-xiao.w.wang@intel.com", "date": "2015-07-27T08:42:30", "name": "[dpdk-dev,07/16] fm10k: mbx_update_max_size does not drop all", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba7f0d59defbffd3cc9a5acc7b735b605a58f29e", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1437986559-31016-7-git-send-email-xiao.w.wang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/6609/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/6609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CA4DEC530;\n\tMon, 27 Jul 2015 10:43:08 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 81CDEC44C\n\tfor <dev@dpdk.org>; Mon, 27 Jul 2015 10:43:05 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 27 Jul 2015 01:43:04 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 27 Jul 2015 01:43:03 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t6R8h0nr023326;\n\tMon, 27 Jul 2015 16:43:00 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t6R8gupD031094; Mon, 27 Jul 2015 16:42:58 +0800", "(from xiaowan1@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t6R8guHv031090; \n\tMon, 27 Jul 2015 16:42:56 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,552,1432623600\"; d=\"scan'208\";a=\"755437802\"", "From": "Wang Xiao W <xiao.w.wang@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 27 Jul 2015 16:42:30 +0800", "Message-Id": "<1437986559-31016-7-git-send-email-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>", "References": "<1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>", "Cc": "Wang Xiao W <xiao.w.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH 07/16] fm10k: mbx_update_max_size does not drop\n\tall", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we call update_max_size, it does not drop all oversized messages.\nThis is due to the difficulty in performing this operation, since it is\na FIFO which makes updating anything other than head or tail very\ndifficult. To fix this, modify validate_msg_size to ensure that we error\nout later when trying to transmit the message that could be oversized.\nThis will generally be a rare condition, as it requires the FIFO to\ninclude a message larger than the max_size negotiated during mailbox\nconnect. Note that max_size is always smaller than rx.size, so it should\nbe safe to use here.\n\nAlso, update the update_max_size function header comment to clearly\nindicate that it does not drop all oversized messages, but only those at\nthe head of the FIFO.\n\nSigned-off-by: Wang Xiao W <xiao.w.wang@intel.com>\n---\n drivers/net/fm10k/base/fm10k_mbx.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c\nindex 12f10f8..0cdd24d 100644\n--- a/drivers/net/fm10k/base/fm10k_mbx.c\n+++ b/drivers/net/fm10k/base/fm10k_mbx.c\n@@ -344,7 +344,7 @@ STATIC u16 fm10k_mbx_validate_msg_size(struct fm10k_mbx_info *mbx, u16 len)\n \t} while (total_len < len);\n \n \t/* message extends out of pushed section, but fits in FIFO */\n-\tif ((len < total_len) && (msg_len <= mbx->rx.size))\n+\tif ((len < total_len) && (msg_len <= mbx->max_size))\n \t\treturn 0;\n \n \t/* return length of invalid section */\n@@ -1088,12 +1088,15 @@ STATIC void fm10k_mbx_reset_work(struct fm10k_mbx_info *mbx)\n }\n \n /**\n- * fm10k_mbx_update_max_size - Update the max_size and drop any large messages\n+ * fm10k_mbx_update_max_size - Update the max_size and drop large messages\n * @mbx: pointer to mailbox\n * @size: new value for max_size\n *\n- * This function will update the max_size value and drop any outgoing messages\n- * from the head of the Tx FIFO that are larger than max_size.\n+ * This function updates the max_size value and drops any outgoing messages\n+ * at the head of the Tx FIFO if they are larger than max_size. It does not\n+ * drop all messages, as this is too difficult to parse and remove them from\n+ * the FIFO. Instead, rely on the checking to ensure that messages larger\n+ * than max_size aren't pushed into the memory buffer.\n **/\n STATIC void fm10k_mbx_update_max_size(struct fm10k_mbx_info *mbx, u16 size)\n {\n", "prefixes": [ "dpdk-dev", "07/16" ] }