Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64185/?format=api
{ "id": 64185, "url": "https://patches.dpdk.org/api/patches/64185/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200103113157.7928-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200103113157.7928-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200103113157.7928-1-mattias.ronnblom@ericsson.com", "date": "2020-01-03T11:31:57", "name": "event/dsw: avoid credit leak on oversized enqueue bursts", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "94fa474b0813cf8b554ac8d697dd263b30f45fff", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200103113157.7928-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 7976, "url": "https://patches.dpdk.org/api/series/7976/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7976", "date": "2020-01-03T11:31:57", "name": "event/dsw: avoid credit leak on oversized enqueue bursts", "version": 1, "mbox": "https://patches.dpdk.org/series/7976/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/64185/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/64185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E69FA04F3;\n\tFri, 3 Jan 2020 12:32:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A99D21D165;\n\tFri, 3 Jan 2020 12:32:21 +0100 (CET)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81])\n by dpdk.org (Postfix) with ESMTP id 77BC91C2A3;\n Fri, 3 Jan 2020 12:32:20 +0100 (CET)", "from HE1PR07CA0019.eurprd07.prod.outlook.com (2603:10a6:7:67::29) by\n AM0PR07MB4562.eurprd07.prod.outlook.com (2603:10a6:208:77::31) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.2602.9; Fri, 3 Jan 2020 11:32:19 +0000", "from VE1EUR02FT040.eop-EUR02.prod.protection.outlook.com\n (2a01:111:f400:7e06::200) by HE1PR07CA0019.outlook.office365.com\n (2603:10a6:7:67::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.4 via Frontend\n Transport; Fri, 3 Jan 2020 11:32:19 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n VE1EUR02FT040.mail.protection.outlook.com (10.152.13.217) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.2602.11 via Frontend Transport; Fri, 3 Jan 2020 11:32:18 +0000", "from ESESBMB505.ericsson.se (153.88.183.172) by\n ESESSMR506.ericsson.se (153.88.183.128) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.1713.5; Fri, 3 Jan 2020 12:32:07 +0100", "from selio1a020.lmera.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.188) with Microsoft SMTP Server id\n 15.1.1713.5 via Frontend Transport; Fri, 3 Jan 2020 12:32:07 +0100", "from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se\n [150.132.109.241])\n by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id\n 003BW81x001841; Fri, 3 Jan 2020 12:32:08 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BQwPVYqky7LSeOLUcL+hVC6uFVO3KZTCpfDSZfAPxj6gkiVC+Ky3m5r5w0p7qGgSgUg8D84sSK7ZYHtEaat/3iylmIK7Wk5+FXvN70qmpnNkK5a/E4xUAPniDZAy5hOA0bidUjr+v4rBmChDIXVWYR+OEZGcYygD5hF3FM5pmMO7rjyALuKPmvVSpUavqcTHpJeEzTlv1xfd0yue9i7feR0ogXfbDrE0hiE5uIo2OLI/NEMnHryg+gN5xgwMGKlNpsTs18WeqaAGGw3Iq1OKUE/nrZkQ3s0JJI2K68PSJeuYYlb7fxlVjtsJ7pbkym8EyJF3sH3wzIBPOlOfbZMmTQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kJXfHTo7WjXQGLkV3IO7U5rpX5OLUi9HNabfSI2rNJ0=;\n b=m0X95DCgz7DQZVYap9CuoQ4rTmicJSZqTshgt6G1woQcwoViganeW/Oj/0vrmBmr6zaPilh+l/GcIRo/OwYkPC9biiF+OiT39G1Sw6nXTap6jSvSGLqcsmeYVduaIkYe2+EBzRSWKL9y8z05CbVWMEHauGo0hL0H4zNfD1hWaKH+DRety7nugeNqO0UzR7vzhvwNGR7W7bq3bJ6GlhQPVozY6UG6PrRqN/O/UNWLrc0LQCBXbqy/y4jZhBTkjzh1OHxgpNUsZ2fwK/t/TCwBAuhtcC7vP3ekkL7ThMY5Mx/6Pmlaoxd15loDsk+q9Eut7ev27xTSJF2/ni/ZMjxY/g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=none pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kJXfHTo7WjXQGLkV3IO7U5rpX5OLUi9HNabfSI2rNJ0=;\n b=pqI/NVoHnr9RhYUrz4PJl+CglNveTNCDxw4YTgOOj0aiT3imGo+BHOp5UyCuN8rEcN8MCPbhZz4xpJ8Cd+5PAEaVY0ylJl9PSQozRYiPfseV3U+4PdkCcnv8o+OD7MvR5M+fJnEYW/XEa2JjorHW592sn4uPh+qDA6uryHMg7q8=", "Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com;", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n <stable@dpdk.org>", "Date": "Fri, 3 Jan 2020 12:31:57 +0100", "Message-ID": "<20200103113157.7928-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; IPV:; CTRY:SE; EFV:NLI;\n SFV:NSPM;\n SFS:(10009020)(4636009)(376002)(346002)(396003)(39860400002)(136003)(189003)(199004)(36756003)(356004)(478600001)(336012)(8936002)(1076003)(2616005)(86362001)(6666004)(956004)(8676002)(70206006)(186003)(6916009)(246002)(70586007)(26005)(7636002)(5660300002)(2906002)(54906003)(4326008)(316002);\n DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR07MB4562; H:oa.msg.ericsson.com; FPR:;\n SPF:Pass; LANG:en; PTR:office365.se.ericsson.net; MX:1; A:1;", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6a1e1f21-b29e-4848-a719-08d79040977e", "X-MS-TrafficTypeDiagnostic": "AM0PR07MB4562:", "X-Microsoft-Antispam-PRVS": "\n <AM0PR07MB45627DDD1F11530F637B6790E1230@AM0PR07MB4562.eurprd07.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4714;", "X-Forefront-PRVS": "0271483E06", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n sBZncLvSfi/dsBnzYp/dL34otkUxnxEUINsf/I+JR/4JtJg0oYsyGTqtfLuSlPcoS5R0ygPmEylTnrtBCUAy2R84AWevC8TsHXyujE4TdM16QjP/aNfoaPLKlxXM3z03+gB8vVlsw03NYVZDzSqWlqpwCcxJNUPEmEj4szgxfdpexGKosAFLqZwoMjWrobrNUkbjKAaI9nbxd0mmKrZavof7tI7IrCwjxVJlYCd+ltHhE8nFnBWBeTOtIo0RDfyrHo6nUdg9LaQZ4hTiZakxJZTy11R0uvRsubaARkIyJJznhAh2DNcmyzYE1xwmQAMH6pg0HNGTtokrl8ZPRr3H/b2PYcpTYxs0UdcDEgy6n9hVK6vHl1SZntBpaMY41vkqKI2qY4X84f66lGbss0hThP7YP3rK01aK4Hpypg/SrinQAvhBNAYjd7lYjIzkxSFd", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Jan 2020 11:32:18.9370 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6a1e1f21-b29e-4848-a719-08d79040977e", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR07MB4562", "Subject": "[dpdk-dev] [PATCH] event/dsw: avoid credit leak on oversized\n\tenqueue bursts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If an application issues rte_event_enqueue_new_burst() or\nrte_event_enqueue_forward_burst() call with a burst of events longer\nthan the configured max enqueue burst size, DSW allocates credits not\nonly for events actually enqueued, but for the complete burst. If this\nprocess is repeated, enough credits will have leaked to cause the\nevent device to backpressure (i.e. disallow) any new enqueue\noperations.\n\nIn addition, the port-level enqueue xstats will log the wrong number\nof events enqueued for oversized enqueues.\n\nThis patch makes DSW gracefully handle oversized enqueue bursts.\n\nFixes: 1c8e3caa3bfb (\"event/dsw: add event scheduling and device start/stop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n drivers/event/dsw/dsw_event.c | 36 ++++++++++++++++++++++++-----------\n 1 file changed, 25 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c\nindex 61a66fabf..b919244c6 100644\n--- a/drivers/event/dsw/dsw_event.c\n+++ b/drivers/event/dsw/dsw_event.c\n@@ -1018,12 +1018,12 @@ dsw_event_enqueue(void *port, const struct rte_event *ev)\n }\n \n static __rte_always_inline uint16_t\n-dsw_event_enqueue_burst_generic(void *port, const struct rte_event events[],\n+dsw_event_enqueue_burst_generic(struct dsw_port *source_port,\n+\t\t\t\tconst struct rte_event events[],\n \t\t\t\tuint16_t events_len, bool op_types_known,\n \t\t\t\tuint16_t num_new, uint16_t num_release,\n \t\t\t\tuint16_t num_non_release)\n {\n-\tstruct dsw_port *source_port = port;\n \tstruct dsw_evdev *dsw = source_port->dsw;\n \tbool enough_credits;\n \tuint16_t i;\n@@ -1050,9 +1050,6 @@ dsw_event_enqueue_burst_generic(void *port, const struct rte_event events[],\n \t\treturn 0;\n \t}\n \n-\tif (unlikely(events_len > source_port->enqueue_depth))\n-\t\tevents_len = source_port->enqueue_depth;\n-\n \tdsw_port_note_op(source_port, events_len);\n \n \tif (!op_types_known)\n@@ -1108,24 +1105,41 @@ uint16_t\n dsw_event_enqueue_burst(void *port, const struct rte_event events[],\n \t\t\tuint16_t events_len)\n {\n-\treturn dsw_event_enqueue_burst_generic(port, events, events_len, false,\n-\t\t\t\t\t 0, 0, 0);\n+\tstruct dsw_port *source_port = port;\n+\n+\tif (unlikely(events_len > source_port->enqueue_depth))\n+\t\tevents_len = source_port->enqueue_depth;\n+\n+\treturn dsw_event_enqueue_burst_generic(source_port, events,\n+\t\t\t\t\t events_len, false, 0, 0, 0);\n }\n \n uint16_t\n dsw_event_enqueue_new_burst(void *port, const struct rte_event events[],\n \t\t\t uint16_t events_len)\n {\n-\treturn dsw_event_enqueue_burst_generic(port, events, events_len, true,\n-\t\t\t\t\t events_len, 0, events_len);\n+\tstruct dsw_port *source_port = port;\n+\n+\tif (unlikely(events_len > source_port->enqueue_depth))\n+\t\tevents_len = source_port->enqueue_depth;\n+\n+\treturn dsw_event_enqueue_burst_generic(source_port, events,\n+\t\t\t\t\t events_len, true, events_len,\n+\t\t\t\t\t 0, events_len);\n }\n \n uint16_t\n dsw_event_enqueue_forward_burst(void *port, const struct rte_event events[],\n \t\t\t\tuint16_t events_len)\n {\n-\treturn dsw_event_enqueue_burst_generic(port, events, events_len, true,\n-\t\t\t\t\t 0, 0, events_len);\n+\tstruct dsw_port *source_port = port;\n+\n+\tif (unlikely(events_len > source_port->enqueue_depth))\n+\t\tevents_len = source_port->enqueue_depth;\n+\n+\treturn dsw_event_enqueue_burst_generic(source_port, events,\n+\t\t\t\t\t events_len, true, 0, 0,\n+\t\t\t\t\t events_len);\n }\n \n uint16_t\n", "prefixes": [] }