Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63267/?format=api
{ "id": 63267, "url": "https://patches.dpdk.org/api/patches/63267/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191125090053.974-1-xavier.huwei@tom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191125090053.974-1-xavier.huwei@tom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191125090053.974-1-xavier.huwei@tom.com", "date": "2019-11-25T09:00:53", "name": "net/hns3: fix checking enough Tx BDs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6c2b897752fb80effb03aa1320ea0679af0dc8f1", "submitter": { "id": 1459, "url": "https://patches.dpdk.org/api/people/1459/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@tom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191125090053.974-1-xavier.huwei@tom.com/mbox/", "series": [ { "id": 7602, "url": "https://patches.dpdk.org/api/series/7602/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7602", "date": "2019-11-25T09:00:53", "name": "net/hns3: fix checking enough Tx BDs", "version": 1, "mbox": "https://patches.dpdk.org/series/7602/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/63267/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/63267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 759D5A04C2;\n\tMon, 25 Nov 2019 10:01:09 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E3D562952;\n\tMon, 25 Nov 2019 10:01:08 +0100 (CET)", "from smtp.tom.com (smtprz15.163.net [106.3.154.248])\n by dpdk.org (Postfix) with ESMTP id 3C225235\n for <dev@dpdk.org>; Mon, 25 Nov 2019 10:01:07 +0100 (CET)", "from my-app01.tom.com (my-app01.tom.com [127.0.0.1])\n by freemail01.tom.com (Postfix) with ESMTP id A05FC1C816C6\n for <dev@dpdk.org>; Mon, 25 Nov 2019 17:01:15 +0800 (CST)", "from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1])\n by my-app01 (TOM SMTP Server) with SMTP ID 1863435607\n for <dev@dpdk.org>; Mon, 25 Nov 2019 17:01:15 +0800 (CST)", "from antispam1.tom.com (unknown [172.25.16.55])\n by freemail01.tom.com (Postfix) with ESMTP id 8DB9D1C8162D\n for <dev@dpdk.org>; Mon, 25 Nov 2019 17:01:15 +0800 (CST)", "from antispam1.tom.com (antispam1.tom.com [127.0.0.1])\n by antispam1.tom.com (Postfix) with ESMTP id 444FA10014C6\n for <dev@dpdk.org>; Mon, 25 Nov 2019 17:00:35 +0800 (CST)", "from antispam1.tom.com ([127.0.0.1])\n by antispam1.tom.com (antispam1.tom.com [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id GfZQbiq4T2Jy for <dev@dpdk.org>;\n Mon, 25 Nov 2019 17:00:31 +0800 (CST)", "from localhost.localdomain (unknown [203.160.91.226])\n by antispam1.tom.com (Postfix) with ESMTPA id E20411001640;\n Mon, 25 Nov 2019 17:00:29 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807;\n t=1574672475; bh=P8PvFnWS8NW334NVDKuRy1zVGXfil/0l0NsmlICE6Lg=;\n h=From:To:Cc:Subject:Date:From;\n b=cQSbVsxa9QOnWsBJIHyG85LjVY/i0ju5/iPJJ2vWbHxbL+BE5PBIGnaBBk9WwUoYo\n PsnNdsBxi+0WINYC/v3kFy8O3Lz1yF6cgw/EysbGWJeM4ixR6JAZme2FecdfDMLqcT\n zDv7Av+QiueugcBhBR+hrX6fb3fcmYUSTqKVJ5oo=", "X-Virus-Scanned": "Debian amavisd-new at antispam1.tom.com", "From": "\"Wei Hu (Xavier)\" <xavier.huwei@tom.com>", "To": "dev@dpdk.org,\n\tstable@dpdk.org", "Cc": "huwei87@hisilicon.com", "Date": "Mon, 25 Nov 2019 17:00:53 +0800", "Message-Id": "<20191125090053.974-1-xavier.huwei@tom.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/hns3: fix checking enough Tx BDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nIn .tx_pkt_burst ops implementation function of hns3 PMD driver,\nthere is one check whether there are enough BDs in the TX queue.\nIf not, driver will stop sending the packets.\n\nCurrently in the 'for' process loop, the next_to_use member of\nTX queue is not updated in time after processing BDs of one packet,\nwhich results in the invalid action of checking whether there are\nenough BDs and failure in sending packets.\n\nThis patch fixes it by moving the assignment statment of the\nnext_to_use member of TX queue to the place after porcessing TX BDs\nin the 'for' loop.\n\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 34cb7faf9..816644713 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1649,6 +1649,7 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t} while (m_seg != NULL);\n \n \t\tnb_hold += i;\n+\t\ttxq->next_to_use = tx_next_use;\n \t}\n \n end_of_tx:\n@@ -1656,7 +1657,6 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \tif (likely(nb_tx)) {\n \t\thns3_queue_xmit(txq, nb_hold);\n \t\ttxq->next_to_clean = tx_next_clean;\n-\t\ttxq->next_to_use = tx_next_use;\n \t\ttxq->tx_bd_ready = tx_bd_ready - nb_hold;\n \t}\n \n", "prefixes": [] }