Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62805/?format=api
{ "id": 62805, "url": "https://patches.dpdk.org/api/patches/62805/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191108180035.7991-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191108180035.7991-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191108180035.7991-1-stephen@networkplumber.org", "date": "2019-11-08T18:00:35", "name": "cmdline: remove unnecessary #ifdef", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "277d93c1db9ba9f1b61f0346250eae9f8c10d4ba", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191108180035.7991-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 7369, "url": "https://patches.dpdk.org/api/series/7369/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7369", "date": "2019-11-08T18:00:35", "name": "cmdline: remove unnecessary #ifdef", "version": 1, "mbox": "https://patches.dpdk.org/series/7369/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62805/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62805/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 63D77A04B4;\n\tFri, 8 Nov 2019 19:00:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C5301D169;\n\tFri, 8 Nov 2019 19:00:45 +0100 (CET)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 1D4B61D166\n for <dev@dpdk.org>; Fri, 8 Nov 2019 19:00:44 +0100 (CET)", "by mail-pf1-f196.google.com with SMTP id c13so5121167pfp.5\n for <dev@dpdk.org>; Fri, 08 Nov 2019 10:00:44 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id c12sm7186550pfp.178.2019.11.08.10.00.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 Nov 2019 10:00:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=lJOcmL4ddPJ7cNibVKmtzqqf9WKxBI2vf+UZCkiXLVQ=;\n b=rhRUv5tWt/St9lmCMmiAY0uyb64FrwGBRgdcPqon01Ar9f5cnMCcPtX0vAVEw9G7Bu\n vDS3GU1nIHiPhqbXM/7IjruFBU4PzHsYynV0VLy5eB77JadF6wtVhK4rE2JFjX4R70cW\n OtKDaty9JL61DuOl9z3uBZG3Ne3YWyC2EnE2zsaOi8as1qrQCY9lOyoNz15zSRWw9W3I\n XZYuCo5p+VCRfZf7m/fmgZW0oGKuT+5EtAay2L5dGqxiW6oyobbOf+KRsIrvgjS+o7QT\n WVLWimKz5x5s81qj4aLV6U7S5EcgnCI5UXt4/B9zersSosv6nDNtfgDKcC8ghNcOg4t5\n fbdQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=lJOcmL4ddPJ7cNibVKmtzqqf9WKxBI2vf+UZCkiXLVQ=;\n b=n53QUK6BLyDbcS3Zll8tQpS2gqxHesdYAQiadttSkbLO+2oisJY+G0TgaxegevnCa7\n L/f0aCO8k3cjCbAd+57g8liUi3s5T3dJ2cpuN/zc2wgJ1mhJ2avAOKpc5hYGy44NqTU4\n q1BFnsHAi2QkU4L62QO+o6cwwo3HriWpLJw/VYQ/YIRR8XqQvGnJtCchgXbngG9opEI8\n g/vKpVHLNLxVB3SxaxZBw8gljBIsT4d1MnaO5Lxz+ne1x6wnc+y4HoZQCdcbarzDIudF\n 3zf8Zu/COofqJalTGpwz3p01baGE8L3i5FCHDOLTAa2xwftIRXvP2qKdmoUQceh2tMBx\n 1AHw==", "X-Gm-Message-State": "APjAAAXEfuwnvUHL8bFkSTNbmFwDYf4fd+oQHAJ+BMSGkm/99itvaWNd\n DKIUX+oRzqJf917wkzlEfTIkZEFsuA2GTg==", "X-Google-Smtp-Source": "\n APXvYqzvJ4xU80f8vpVElA0ZZastDQp6uUg5CXX08pOWwkVUeJopBvUYcYhapoTB572Rjn6OfXCREQ==", "X-Received": "by 2002:a63:e801:: with SMTP id s1mr5790091pgh.213.1573236042980;\n Fri, 08 Nov 2019 10:00:42 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 8 Nov 2019 10:00:35 -0800", "Message-Id": "<20191108180035.7991-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191106120943.15967-1-thomas@monjalon.net>", "References": "<20191106120943.15967-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The #ifdef to conditionally include <sys/socket.h> on BSD\nis unnecessary. It is harmless to include the header on other\nOS's. An extra include is better than an #ifdef.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/cmdline.c | 2 --\n app/test/test_cmdline_ipaddr.c | 2 --\n lib/librte_cmdline/cmdline_parse_ipaddr.c | 2 --\n 3 files changed, 6 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 74e02d68130f..4e5b3afd0916 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -11,9 +11,7 @@\n #include <termios.h>\n #include <unistd.h>\n #include <inttypes.h>\n-#ifdef RTE_EXEC_ENV_FREEBSD\n #include <sys/socket.h>\n-#endif\n #include <netinet/in.h>\n \n #include <sys/queue.h>\ndiff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c\nindex 315ac3a9f8af..088cd5afc3ad 100644\n--- a/app/test/test_cmdline_ipaddr.c\n+++ b/app/test/test_cmdline_ipaddr.c\n@@ -6,9 +6,7 @@\n #include <string.h>\n #include <inttypes.h>\n #include <netinet/in.h>\n-#ifdef RTE_EXEC_ENV_FREEBSD\n #include <sys/socket.h>\n-#endif\n \n #include <rte_string_fns.h>\n \ndiff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c\nindex 4de5ba35aecc..f8dbdf204c29 100644\n--- a/lib/librte_cmdline/cmdline_parse_ipaddr.c\n+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c\n@@ -13,9 +13,7 @@\n #include <errno.h>\n #include <arpa/inet.h>\n #include <netinet/in.h>\n-#ifdef RTE_EXEC_ENV_FREEBSD\n #include <sys/socket.h>\n-#endif\n \n #include <rte_string_fns.h>\n \n", "prefixes": [] }