Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62334/?format=api
{ "id": 62334, "url": "https://patches.dpdk.org/api/patches/62334/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191101175141.4663-6-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191101175141.4663-6-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191101175141.4663-6-hemant.agrawal@nxp.com", "date": "2019-11-01T17:51:34", "name": "[v2,06/13] crypto/dpaa2_sec: add AES-GCM support for lookaside case", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "39994fa6e1c94eb85cbd0456fea7f2542caeb8d4", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191101175141.4663-6-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 7200, "url": "https://patches.dpdk.org/api/series/7200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7200", "date": "2019-11-01T17:51:29", "name": "[v2,01/13] crypto/dpaa_sec: fix to set PDCP capability flags", "version": 2, "mbox": "https://patches.dpdk.org/series/7200/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62334/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62334/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F1EDA00BE;\n\tFri, 1 Nov 2019 18:55:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 61E5A1E88F;\n\tFri, 1 Nov 2019 18:54:56 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 6C87A1E868\n for <dev@dpdk.org>; Fri, 1 Nov 2019 18:54:49 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 117A92002FF;\n Fri, 1 Nov 2019 18:54:49 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 7221B200133;\n Fri, 1 Nov 2019 18:54:47 +0100 (CET)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 4309A4031F;\n Sat, 2 Nov 2019 01:54:45 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Date": "Fri, 1 Nov 2019 23:21:34 +0530", "Message-Id": "<20191101175141.4663-6-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191101175141.4663-1-hemant.agrawal@nxp.com>", "References": "<20191025083336.24212-1-hemant.agrawal@nxp.com>\n <20191101175141.4663-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 06/13] crypto/dpaa2_sec: add AES-GCM support\n\tfor lookaside case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 96 ++++++++++++++++++++-\n 1 file changed, 92 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 6c2faa69a..c6b6444aa 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -2550,12 +2550,40 @@ dpaa2_sec_ipsec_aead_init(struct rte_crypto_aead_xform *aead_xform,\n \n \tswitch (aead_xform->algo) {\n \tcase RTE_CRYPTO_AEAD_AES_GCM:\n-\t\taeaddata->algtype = OP_ALG_ALGSEL_AES;\n+\t\tswitch (session->digest_length) {\n+\t\tcase 8:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_GCM8;\n+\t\t\tbreak;\n+\t\tcase 12:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_GCM12;\n+\t\t\tbreak;\n+\t\tcase 16:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_GCM16;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tDPAA2_SEC_ERR(\"Crypto: Undefined GCM digest %d\",\n+\t\t\t\t session->digest_length);\n+\t\t\treturn -1;\n+\t\t}\n \t\taeaddata->algmode = OP_ALG_AAI_GCM;\n \t\tsession->aead_alg = RTE_CRYPTO_AEAD_AES_GCM;\n \t\tbreak;\n \tcase RTE_CRYPTO_AEAD_AES_CCM:\n-\t\taeaddata->algtype = OP_ALG_ALGSEL_AES;\n+\t\tswitch (session->digest_length) {\n+\t\tcase 8:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_CCM8;\n+\t\t\tbreak;\n+\t\tcase 12:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_CCM12;\n+\t\t\tbreak;\n+\t\tcase 16:\n+\t\t\taeaddata->algtype = OP_PCL_IPSEC_AES_CCM16;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tDPAA2_SEC_ERR(\"Crypto: Undefined CCM digest %d\",\n+\t\t\t\t session->digest_length);\n+\t\t\treturn -1;\n+\t\t}\n \t\taeaddata->algmode = OP_ALG_AAI_CCM;\n \t\tsession->aead_alg = RTE_CRYPTO_AEAD_AES_CCM;\n \t\tbreak;\n@@ -2723,8 +2751,6 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev,\n \tstruct rte_crypto_aead_xform *aead_xform = NULL;\n \tdpaa2_sec_session *session = (dpaa2_sec_session *)sess;\n \tstruct ctxt_priv *priv;\n-\tstruct ipsec_encap_pdb encap_pdb;\n-\tstruct ipsec_decap_pdb decap_pdb;\n \tstruct alginfo authdata, cipherdata;\n \tint bufsize;\n \tstruct sec_flow_context *flc;\n@@ -2764,6 +2790,8 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev,\n \t\taead_xform = &conf->crypto_xform->aead;\n \t\tret = dpaa2_sec_ipsec_aead_init(aead_xform,\n \t\t\t\t\tsession, &cipherdata);\n+\t\tauthdata.keylen = 0;\n+\t\tauthdata.algtype = 0;\n \t} else {\n \t\tDPAA2_SEC_ERR(\"XFORM not specified\");\n \t\tret = -EINVAL;\n@@ -2779,10 +2807,37 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev,\n \t\tuint8_t *hdr = NULL;\n \t\tstruct ip ip4_hdr;\n \t\tstruct rte_ipv6_hdr ip6_hdr;\n+\t\tstruct ipsec_encap_pdb encap_pdb;\n \n \t\tflc->dhr = SEC_FLC_DHR_OUTBOUND;\n \t\t/* For Sec Proto only one descriptor is required. */\n \t\tmemset(&encap_pdb, 0, sizeof(struct ipsec_encap_pdb));\n+\n+\t\t/* copy algo specific data to PDB */\n+\t\tswitch (cipherdata.algtype) {\n+\t\tcase OP_PCL_IPSEC_AES_GCM8:\n+\t\tcase OP_PCL_IPSEC_AES_GCM12:\n+\t\tcase OP_PCL_IPSEC_AES_GCM16:\n+\t\t\tmemcpy(encap_pdb.gcm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM8:\n+\t\t\tencap_pdb.ccm.ccm_opt = 0x5B;\n+\t\t\tmemcpy(encap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM12:\n+\t\t\tencap_pdb.ccm.ccm_opt = 0x6B;\n+\t\t\tmemcpy(encap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM16:\n+\t\t\tencap_pdb.ccm.ccm_opt = 0x7B;\n+\t\t\tmemcpy(encap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tencap_pdb.options = (IPVERSION << PDBNH_ESP_ENCAP_SHIFT) |\n \t\t\tPDBOPTS_ESP_OIHI_PDB_INL |\n \t\t\tPDBOPTS_ESP_IVSRC |\n@@ -2839,8 +2894,41 @@ dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev,\n \t\t\t\thdr, &cipherdata, &authdata);\n \t} else if (ipsec_xform->direction ==\n \t\t\tRTE_SECURITY_IPSEC_SA_DIR_INGRESS) {\n+\t\tstruct ipsec_decap_pdb decap_pdb;\n+\n \t\tflc->dhr = SEC_FLC_DHR_INBOUND;\n \t\tmemset(&decap_pdb, 0, sizeof(struct ipsec_decap_pdb));\n+\t\t/* copy algo specific data to PDB */\n+\t\tswitch (cipherdata.algtype) {\n+\t\tcase OP_PCL_IPSEC_AES_GCM8:\n+\t\tcase OP_PCL_IPSEC_AES_GCM12:\n+\t\tcase OP_PCL_IPSEC_AES_GCM16:\n+\t\t\tmemcpy(decap_pdb.gcm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM8:\n+\t\t\tdecap_pdb.ccm.ccm_opt = 0x5B;\n+\t\t\t/* CCM salt length is 3 bytes, left shift 8 bits */\n+\t\t\tipsec_xform->salt >>= 8;\n+\t\t\tmemcpy(decap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM12:\n+\t\t\tdecap_pdb.ccm.ccm_opt = 0x6B;\n+\t\t\t/* CCM salt length is 3 bytes, left shift 8 bits */\n+\t\t\tipsec_xform->salt >>= 8;\n+\t\t\tmemcpy(decap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\tcase OP_PCL_IPSEC_AES_CCM16:\n+\t\t\tdecap_pdb.ccm.ccm_opt = 0x7B;\n+\t\t\t/* CCM salt length is 3 bytes, left shift 8 bits */\n+\t\t\tipsec_xform->salt >>= 8;\n+\t\t\tmemcpy(decap_pdb.ccm.salt,\n+\t\t\t\t(uint8_t *)&(ipsec_xform->salt), 4);\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tdecap_pdb.options = (ipsec_xform->tunnel.type ==\n \t\t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV4) ?\n \t\t\t\tsizeof(struct ip) << 16 :\n", "prefixes": [ "v2", "06/13" ] }