Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62331/?format=api
{ "id": 62331, "url": "https://patches.dpdk.org/api/patches/62331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191101175141.4663-4-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191101175141.4663-4-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191101175141.4663-4-hemant.agrawal@nxp.com", "date": "2019-11-01T17:51:32", "name": "[v2,04/13] crypto/dpaa2_sec: adding NULL cipher or NULL auth", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f9a701890eefd91fbf586f326b735c69fbef719", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191101175141.4663-4-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 7200, "url": "https://patches.dpdk.org/api/series/7200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=7200", "date": "2019-11-01T17:51:29", "name": "[v2,01/13] crypto/dpaa_sec: fix to set PDCP capability flags", "version": 2, "mbox": "https://patches.dpdk.org/series/7200/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/62331/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/62331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A77C6A00BE;\n\tFri, 1 Nov 2019 18:55:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9606A1E86E;\n\tFri, 1 Nov 2019 18:54:51 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 3101F1E56E\n for <dev@dpdk.org>; Fri, 1 Nov 2019 18:54:48 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 076C72002FF;\n Fri, 1 Nov 2019 18:54:48 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 6797F200149;\n Fri, 1 Nov 2019 18:54:46 +0100 (CET)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3A41640309;\n Sat, 2 Nov 2019 01:54:44 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Date": "Fri, 1 Nov 2019 23:21:32 +0530", "Message-Id": "<20191101175141.4663-4-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191101175141.4663-1-hemant.agrawal@nxp.com>", "References": "<20191025083336.24212-1-hemant.agrawal@nxp.com>\n <20191101175141.4663-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 04/13] crypto/dpaa2_sec: adding NULL cipher or\n\tNULL auth", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These are supported when using protocol offload mode or in chain mode.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 22 +++++++----\n drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 41 +++++++++++++++++++++\n 2 files changed, 56 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 70207818b..6c2faa69a 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016-2018 NXP\n+ * Copyright 2016-2019 NXP\n *\n */\n \n@@ -1837,6 +1837,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,\n \n \tflc = &priv->flc_desc[0].flc;\n \n+\tsession->ctxt_type = DPAA2_SEC_CIPHER;\n \tsession->cipher_key.data = rte_zmalloc(NULL, xform->cipher.key.length,\n \t\t\tRTE_CACHE_LINE_SIZE);\n \tif (session->cipher_key.data == NULL) {\n@@ -1973,6 +1974,7 @@ dpaa2_sec_auth_init(struct rte_cryptodev *dev,\n \tpriv->fle_pool = dev_priv->fle_pool;\n \tflc = &priv->flc_desc[DESC_INITFINAL].flc;\n \n+\tsession->ctxt_type = DPAA2_SEC_AUTH;\n \tsession->auth_key.data = rte_zmalloc(NULL, xform->auth.key.length,\n \t\t\tRTE_CACHE_LINE_SIZE);\n \tif (session->auth_key.data == NULL) {\n@@ -2481,27 +2483,33 @@ dpaa2_sec_set_session_parameters(struct rte_cryptodev *dev,\n \n \t/* Cipher Only */\n \tif (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER && xform->next == NULL) {\n-\t\tsession->ctxt_type = DPAA2_SEC_CIPHER;\n \t\tret = dpaa2_sec_cipher_init(dev, xform, session);\n \n \t/* Authentication Only */\n \t} else if (xform->type == RTE_CRYPTO_SYM_XFORM_AUTH &&\n \t\t xform->next == NULL) {\n-\t\tsession->ctxt_type = DPAA2_SEC_AUTH;\n \t\tret = dpaa2_sec_auth_init(dev, xform, session);\n \n \t/* Cipher then Authenticate */\n \t} else if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER &&\n \t\t xform->next->type == RTE_CRYPTO_SYM_XFORM_AUTH) {\n \t\tsession->ext_params.aead_ctxt.auth_cipher_text = true;\n-\t\tret = dpaa2_sec_aead_chain_init(dev, xform, session);\n-\n+\t\tif (xform->cipher.algo == RTE_CRYPTO_CIPHER_NULL)\n+\t\t\tret = dpaa2_sec_auth_init(dev, xform, session);\n+\t\telse if (xform->next->auth.algo == RTE_CRYPTO_AUTH_NULL)\n+\t\t\tret = dpaa2_sec_cipher_init(dev, xform, session);\n+\t\telse\n+\t\t\tret = dpaa2_sec_aead_chain_init(dev, xform, session);\n \t/* Authenticate then Cipher */\n \t} else if (xform->type == RTE_CRYPTO_SYM_XFORM_AUTH &&\n \t\t xform->next->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {\n \t\tsession->ext_params.aead_ctxt.auth_cipher_text = false;\n-\t\tret = dpaa2_sec_aead_chain_init(dev, xform, session);\n-\n+\t\tif (xform->auth.algo == RTE_CRYPTO_AUTH_NULL)\n+\t\t\tret = dpaa2_sec_cipher_init(dev, xform, session);\n+\t\telse if (xform->next->cipher.algo == RTE_CRYPTO_CIPHER_NULL)\n+\t\t\tret = dpaa2_sec_auth_init(dev, xform, session);\n+\t\telse\n+\t\t\tret = dpaa2_sec_aead_chain_init(dev, xform, session);\n \t/* AEAD operation for AES-GCM kind of Algorithms */\n \t} else if (xform->type == RTE_CRYPTO_SYM_XFORM_AEAD &&\n \t\t xform->next == NULL) {\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\nindex b97dacbcb..528b64ef8 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h\n@@ -200,6 +200,27 @@ typedef struct dpaa2_sec_session_entry {\n } dpaa2_sec_session;\n \n static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {\n+\t{\t/* NULL (AUTH) */\n+\t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n+\t\t{.sym = {\n+\t\t\t.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,\n+\t\t\t{.auth = {\n+\t\t\t\t.algo = RTE_CRYPTO_AUTH_NULL,\n+\t\t\t\t.block_size = 1,\n+\t\t\t\t.key_size = {\n+\t\t\t\t\t.min = 0,\n+\t\t\t\t\t.max = 0,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t},\n+\t\t\t\t.digest_size = {\n+\t\t\t\t\t.min = 0,\n+\t\t\t\t\t.max = 0,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t},\n+\t\t\t\t.iv_size = { 0 }\n+\t\t\t}, },\n+\t\t}, },\n+\t},\n \t{\t/* MD5 HMAC */\n \t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n \t\t{.sym = {\n@@ -356,6 +377,26 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {\n \t\t\t}, }\n \t\t}, }\n \t},\n+\t{\t/* NULL (CIPHER) */\n+\t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n+\t\t{.sym = {\n+\t\t\t.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,\n+\t\t\t{.cipher = {\n+\t\t\t\t.algo = RTE_CRYPTO_CIPHER_NULL,\n+\t\t\t\t.block_size = 1,\n+\t\t\t\t.key_size = {\n+\t\t\t\t\t.min = 0,\n+\t\t\t\t\t.max = 0,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t},\n+\t\t\t\t.iv_size = {\n+\t\t\t\t\t.min = 0,\n+\t\t\t\t\t.max = 0,\n+\t\t\t\t\t.increment = 0\n+\t\t\t\t}\n+\t\t\t}, },\n+\t\t}, }\n+\t},\n \t{\t/* AES CBC */\n \t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n \t\t{.sym = {\n", "prefixes": [ "v2", "04/13" ] }