Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62020/?format=api
{ "id": 62020, "url": "https://patches.dpdk.org/api/patches/62020/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/cover.1571928488.git.Pavel.Belous@aquantia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cover.1571928488.git.Pavel.Belous@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cover.1571928488.git.Pavel.Belous@aquantia.com", "date": "2019-10-25T17:53:49", "name": "[RFC,v2,0/7] RFC: Support MACSEC offload in the RTE_SECURITY infrastructure.", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 1426, "url": "https://patches.dpdk.org/api/people/1426/?format=api", "name": "Pavel Belous", "email": "Pavel.Belous@aquantia.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/cover.1571928488.git.Pavel.Belous@aquantia.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/62020/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/62020/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EE891D425;\n\tFri, 25 Oct 2019 19:53:55 +0200 (CEST)", "from NAM05-DM3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr730073.outbound.protection.outlook.com [40.107.73.73])\n\tby dpdk.org (Postfix) with ESMTP id D3E771D421\n\tfor <dev@dpdk.org>; Fri, 25 Oct 2019 19:53:53 +0200 (CEST)", "from CY4PR1101MB2183.namprd11.prod.outlook.com (10.172.76.20) by\n\tCY4PR1101MB2311.namprd11.prod.outlook.com (10.174.53.140) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.2387.22; Fri, 25 Oct 2019 17:53:50 +0000", "from CY4PR1101MB2183.namprd11.prod.outlook.com\n\t([fe80::55e:4921:90d1:670a]) by\n\tCY4PR1101MB2183.namprd11.prod.outlook.com\n\t([fe80::55e:4921:90d1:670a%12]) with mapi id 15.20.2387.023;\n\tFri, 25 Oct 2019 17:53:49 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=Pq5FRLE02lzdAgFiejwp0+AYYiU8KTVVFSI+zP/iDAkBsW9QeIT1UMHKP3VlFJFjqSybbBDE9op6O+WePyOR3QvjgsjdOhXwHEk6GO2+7pG9+QNy5AO8dsj6EShttEin9prLJoPe7QApvo5Db06PkYkJZVbOUaeMv9K0iPnn3CEmN57cUvUqdQnD1uvdlv5Tk+Yx3IjZYYTv1o/G3G0UL/AaaLBCrBm0l/3RxS87ytHJmxItduAJ5hqWFJSR7rZuuyXXL8uTIALHC8Q/4qojBDuk4iJeomKDdbh5Vn5u0KBIwH1oICOTDv/q+wMF3PvPbADgGZb/TWP5eO3fOANyfw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=pfcHmmQGOY2K6xYjIicsW3StPkW2/DXrp9lAxIyRhws=;\n\tb=SWMopm/jCpWZ5235sJ4IfhBfoDv1yPIoVXvUb2/5tgJyISFSUd0LlEhVkmGnstV+Bg1vrstVzGQsTIbgN+GzuKESJtGoWNarMo1B8vet+mg1cSvVXu6V0HZfu//FQJf7zyIT7zHPeLcPx0o88gscrgscTaLS5mebjN5miMWVXwnP9ULLl1ww+IpdnKax6F5RcUmR0mdGDoHfBTGSY8rLdTIZ89n7bRACdHTlImPUF+ToVFsbzTyisl6ColhGZKmyuI5gU0XznNFEIXCLeGz5v7/TZfSQ0P6aIJSwY8ezQYY+SCmenaN8lquky3XBQ2Fz0IUxOTLWEqFQIMK4VG2tBQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=aquantia.com;\n\tdmarc=pass action=none header.from=aquantia.com; \n\tdkim=pass header.d=aquantia.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com;\n\ts=selector2-AQUANTIA1COM-onmicrosoft-com; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=pfcHmmQGOY2K6xYjIicsW3StPkW2/DXrp9lAxIyRhws=;\n\tb=i4e3utwZ02pplTqz6n2PUV4ht7ZSNXoYlsnKz9KcQ79wL/7QOytl7JvyfrCssYCchcmUpCDnSInSe/oafBginkalbWsgBbNQgfGXKaj7yuqL4nbPhsOYZdlBZ7iDHuqCsnHctoP7an3MWxbCY57gLkW7y8fbR4zY8CdGwYEin6k=", "From": "Pavel Belous <Pavel.Belous@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Ferruh Yigit <ferruh.yigit@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n\tJohn McNamara <john.mcnamara@intel.com>, Declan Doherty\n\t<declan.doherty@intel.com>, Konstantin Ananyev\n\t<konstantin.ananyev@intel.com>, Thomas Monjalon <thomas@monjalon.net>,\n\tIgor Russkikh <Igor.Russkikh@aquantia.com>,\n\tFenilkumar Patel <fenpatel@cisco.com>, \n\tHitesh K Maisheri <hmaisher@cisco.com>, Pavel Belous\n\t<Pavel.Belous@aquantia.com>", "Thread-Topic": "[RFC v2 0/7] RFC: Support MACSEC offload in the RTE_SECURITY\n\tinfrastructure.", "Thread-Index": "AQHVi10nBXEPDIlV80SgF8Z6g0SzcQ==", "Date": "Fri, 25 Oct 2019 17:53:49 +0000", "Message-ID": "<cover.1571928488.git.Pavel.Belous@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "PR1PR01CA0020.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:102::33) To CY4PR1101MB2183.namprd11.prod.outlook.com\n\t(2603:10b6:910:18::20)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Pavel.Belous@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.7.4", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "bb78c616-8b9e-42fa-93cd-08d759744a17", "x-ms-traffictypediagnostic": "CY4PR1101MB2311:", "x-ms-exchange-purlcount": "1", "x-ld-processed": "83e2e134-991c-4ede-8ced-34d47e38e6b1,ExtFwd", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "<CY4PR1101MB23112E1669FE1F7E6EFCB286E1650@CY4PR1101MB2311.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:10000;", "x-forefront-prvs": "02015246A9", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(39850400004)(366004)(396003)(376002)(136003)(346002)(199004)(189003)(66476007)(66556008)(486006)(66446008)(64756008)(7736002)(476003)(36756003)(86362001)(2616005)(6486002)(71200400001)(6512007)(5640700003)(71190400001)(44832011)(2906002)(6436002)(2351001)(305945005)(66946007)(14454004)(5660300002)(966005)(508600001)(25786009)(4326008)(50226002)(66066001)(6116002)(2501003)(107886003)(3846002)(256004)(14444005)(6306002)(54906003)(99286004)(6916009)(26005)(186003)(102836004)(52116002)(386003)(6506007)(316002)(8676002)(1730700003)(81156014)(81166006)(8936002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1101MB2311;\n\tH:CY4PR1101MB2183.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "/tEKgJv1+9/Mu1H8HPeWbbP2h8bhun4D8Mdst2RrGM6e9jxeIC7w77H952IxE8iqvOqFMiWqjrv8cIo3CTi4me7hfBEW4+21xf5RvrLBxss+gJfTolktCCZux15KY5sFPiy75ZK53wx8asFy15I1ixOFK9pqODNaMvDK42Tti64oAbZijYsX1vdsu1gmpnzTqUH1N7Xk2d23j6Ie5MufyO08mTeUE8sTAVOcFK8yD+pMXaOZxcebmecTApV+Z8feNKL7snB6mKOFMlN5NWlc6N/8hVZ8CX4DmMXA7+um3WOZes/39dDrtoLVDomFq4TwwFlczkSVT3Mm+mUUKG5Ijrjs89TlbJtu6qCtJS2LPFapQiQecPisl2U7a4iiCZAO/HKzaMeD+wwbKOaUI4Pjx/0GMtXfYiUiJ6bzV5bGSFcFnF3bH8PkifaVRg62ypntnehoB++N4/4r+s6f8Mc1kVIMytjcGmLSD0AbmjTbs1E=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "bb78c616-8b9e-42fa-93cd-08d759744a17", "X-MS-Exchange-CrossTenant-originalarrivaltime": "25 Oct 2019 17:53:49.3630\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "EK6ewOlG3l8Q/MlO7XXrbz/7Vfwjr2G/mT8hmiB0NaNs1gg/6Pp3MW4WYRoV9tYHhO6+m+4Ot3czM3w3EbpV7g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR1101MB2311", "Subject": "[dpdk-dev] [RFC v2 0/7] RFC: Support MACSEC offload in the\n\tRTE_SECURITY infrastructure.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <Pavel.Belous@aquantia.com>\n\nThis RFC suggest possible API to implement generic MACSEC HW\noffload in DPDK infrastructure.\n\nRight now two PMDs implementing MACSEC hw offload via private\nAPI: ixgbe (Intel) and atlantic (Aquantia).\n\nDuring that private API discussion it was decided to go further\nwith well defined public API, based most probably on rte_security\ninfrastructure.\n\nHere is that previous discussion:\n\nhttp://inbox.dpdk.org/dev/20190416101145.nVecHKp3w14Ptd_hne-DqHhKyzbre88PwNI-OAowXJM@z/\n\nDeclaring macsec API via rte_security gives a good data-centric view on parameters\nand operations macsec supports. Old, pure functional API (basically ixbe only API)\npresented function calls with big argument lists which is hard to extend and analyse.\n\nHowever, I'd like to note rte_security has to be used via explicitly created\nmempools - this hardens abit the usage.\nIt also may be hard to extend the structures in the ABI compatible way.\n\nOne of the problems with MACSEC is that internally implementation and hardware\nsupport could be either very simple, doing only endpoint encryption with a single\nTX SC (Secure Connection), or quite complex, capable to do flexible filtering\nand SC matching based on mac, vlan, ethertype and other.\n\nDifferent macsec hardware supports some custom features and from our experience\nusers would like to configure these as well. Therefore there will probably be\nneeded a number of PMD specific macsec operators support.\n\nExamples include: custom in-the-clear tag (matched by vlan id or mask),\nconfigurable internal logic to allow both secure and unsecure traffic,\nbypass filters on specific ethertypes.\nTo support such extensions, suggest use rte_security_macsec_op enum with\nvendor specific operation codes.\n\nIn context of rte_security, MACSEC operations should normally be based on\nsecurity session create and update calls.\n\nSession create is used to setup overall session. Thats equivalent of old\n`macsec enable` operation.\n\nSession update is used to update security connections and associations.\nHere xform->op contains the required operation: rx/tx session/association\nadd/update/removal.\n\nThis RFC contains:\n- patch 1-2 is rte_security data structures declaration and documentation\n- patches 3-5 MACSEC implementation for atlantic (Aquantia) driver, using\n new rte_security interface.\n- patches 6-7 is a draft on how testpmd based invocations of rte_security\n API will look like\n\nTo be done/decide:\n- add missing documentation and comments to all the structures\n- full testpmd macsec API adoption\n- ixgbe api adoptation\n- decide on how to declare SA (Security Associations) auto rollover and\n some other important features.\n- interrupt event callback detalization of possible macsec events.\n Notice that it is not a part of rte_security, but a part of rte_ethdev.\n- add ability to retrieve MACSEC statistics per individual SC/SA.\n\nPavel Belous (7):\n security: MACSEC infrastructure data declarations\n security: Update rte_security documentation\n net/atlantic: Add helper functions for PHY access\n net/atlantic: add MACSEC internal HW data declaration and functions\n net/atlantic: implementation of the MACSEC using rte_security\n interface\n app/testpmd: macsec on/off commands using rte_security interface\n app/testpmd: macsec adding RX/TX SC using rte_security interface\n\n app/test-pmd/Makefile | 1 +\n app/test-pmd/cmdline.c | 20 +-\n app/test-pmd/macsec.c | 138 ++\n app/test-pmd/macsec.h | 14 +\n app/test-pmd/meson.build | 3 +-\n doc/guides/prog_guide/rte_security.rst | 4 -\n drivers/net/atlantic/Makefile | 5 +-\n drivers/net/atlantic/atl_ethdev.c | 316 +---\n drivers/net/atlantic/atl_sec.c | 615 ++++++++\n drivers/net/atlantic/atl_sec.h | 124 ++\n drivers/net/atlantic/hw_atl/hw_atl_utils.h | 116 +-\n drivers/net/atlantic/macsec/MSS_Egress_registers.h | 1498 ++++++++++++++++++\n .../net/atlantic/macsec/MSS_Ingress_registers.h | 1135 ++++++++++++++\n drivers/net/atlantic/macsec/macsec_api.c | 1612 ++++++++++++++++++++\n drivers/net/atlantic/macsec/macsec_api.h | 111 ++\n drivers/net/atlantic/macsec/macsec_struct.h | 269 ++++\n drivers/net/atlantic/macsec/mdio.c | 328 ++++\n drivers/net/atlantic/macsec/mdio.h | 19 +\n drivers/net/atlantic/meson.build | 6 +-\n drivers/net/atlantic/rte_pmd_atlantic.c | 102 --\n drivers/net/atlantic/rte_pmd_atlantic.h | 144 --\n drivers/net/atlantic/rte_pmd_atlantic_version.map | 16 -\n lib/librte_security/rte_security.h | 143 +-\n 23 files changed, 6080 insertions(+), 659 deletions(-)\n create mode 100644 app/test-pmd/macsec.c\n create mode 100644 app/test-pmd/macsec.h\n create mode 100644 drivers/net/atlantic/atl_sec.c\n create mode 100644 drivers/net/atlantic/atl_sec.h\n create mode 100644 drivers/net/atlantic/macsec/MSS_Egress_registers.h\n create mode 100644 drivers/net/atlantic/macsec/MSS_Ingress_registers.h\n create mode 100644 drivers/net/atlantic/macsec/macsec_api.c\n create mode 100644 drivers/net/atlantic/macsec/macsec_api.h\n create mode 100644 drivers/net/atlantic/macsec/macsec_struct.h\n create mode 100644 drivers/net/atlantic/macsec/mdio.c\n create mode 100644 drivers/net/atlantic/macsec/mdio.h\n delete mode 100644 drivers/net/atlantic/rte_pmd_atlantic.c\n delete mode 100644 drivers/net/atlantic/rte_pmd_atlantic.h\n delete mode 100644 drivers/net/atlantic/rte_pmd_atlantic_version.map", "diff": null, "prefixes": [ "RFC", "v2", "0/7" ] }