Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 61313,
    "url": "https://patches.dpdk.org/api/patches/61313/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20191016143107.10424-1-i.maximets@ovn.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191016143107.10424-1-i.maximets@ovn.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191016143107.10424-1-i.maximets@ovn.org",
    "date": "2019-10-16T14:31:07",
    "name": "vhost: return error message for mbuf allocation failure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f86eb43b2b833ac7baad898540c91e39581d3bbe",
    "submitter": {
        "id": 1455,
        "url": "https://patches.dpdk.org/api/people/1455/?format=api",
        "name": "Ilya Maximets",
        "email": "i.maximets@ovn.org"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20191016143107.10424-1-i.maximets@ovn.org/mbox/",
    "series": [
        {
            "id": 6886,
            "url": "https://patches.dpdk.org/api/series/6886/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6886",
            "date": "2019-10-16T14:31:07",
            "name": "vhost: return error message for mbuf allocation failure",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/6886/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/61313/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/61313/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9236D1E8CE;\n\tWed, 16 Oct 2019 16:31:17 +0200 (CEST)",
            "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194]) by dpdk.org (Postfix) with ESMTP id B90FB1D42A\n\tfor <dev@dpdk.org>; Wed, 16 Oct 2019 16:31:16 +0200 (CEST)",
            "from localhost.localdomain (238.210.broadband10.iol.cz\n\t[90.177.210.238]) (Authenticated sender: i.maximets@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1BFC04001C;\n\tWed, 16 Oct 2019 14:31:14 +0000 (UTC)"
        ],
        "X-Originating-IP": "90.177.210.238",
        "From": "Ilya Maximets <i.maximets@ovn.org>",
        "To": "dev@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>",
        "Cc": "Flavio Leitner <fbl@sysclose.org>,\n\tDavid Marchand <david.marchand@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Ilya Maximets <i.maximets@ovn.org>",
        "Date": "Wed, 16 Oct 2019 16:31:07 +0200",
        "Message-Id": "<20191016143107.10424-1-i.maximets@ovn.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] vhost: return error message for mbuf allocation\n\tfailure",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "mbuf allocation failure is a hard failure that highlights some\nsignificant issues with memory pool size or a mbuf leak.\n\nWe still have the message for subsequent chained mbufs, but not\nfor the first one.  It was removed while introducing extbuf\nsupport for large buffers.  But it was useful for catching\nmempool issues and needs to be returned back.\n\nCc: Flavio Leitner <fbl@sysclose.org>\n\nFixes: 5005bcda7123 (\"vhost: add support for large buffers\")\nSigned-off-by: Ilya Maximets <i.maximets@ovn.org>\n---\n lib/librte_vhost/virtio_net.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 66f0c7206..f8af4e0b3 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1354,8 +1354,11 @@ virtio_dev_pktmbuf_alloc(struct virtio_net *dev, struct rte_mempool *mp,\n {\n \tstruct rte_mbuf *pkt = rte_pktmbuf_alloc(mp);\n \n-\tif (unlikely(pkt == NULL))\n+\tif (unlikely(pkt == NULL)) {\n+\t\tRTE_LOG(ERR, VHOST_DATA,\n+\t\t\t\"Failed to allocate memory for mbuf.\\n\");\n \t\treturn NULL;\n+\t}\n \n \tif (rte_pktmbuf_tailroom(pkt) >= data_len)\n \t\treturn pkt;\n",
    "prefixes": []
}