Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/605/?format=api
{ "id": 605, "url": "https://patches.dpdk.org/api/patches/605/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1411741159-6671-2-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411741159-6671-2-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411741159-6671-2-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2014-09-26T14:19:18", "name": "[dpdk-dev,1/2] pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd5906298203c021ead834f15921da15d58c14f4", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1411741159-6671-2-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/605/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1C4D67E44;\n\tFri, 26 Sep 2014 16:13:21 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 671AF7DFF\n\tfor <dev@dpdk.org>; Fri, 26 Sep 2014 16:13:17 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 26 Sep 2014 07:10:07 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 26 Sep 2014 07:13:17 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8QEJJ70017942 for <dev@dpdk.org>; Fri, 26 Sep 2014 15:19:19 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8QEJJcV006720\n\tfor <dev@dpdk.org>; Fri, 26 Sep 2014 15:19:19 +0100", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id s8QEJJo6006716\n\tfor dev@dpdk.org; Fri, 26 Sep 2014 15:19:19 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"392033905\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 26 Sep 2014 15:19:18 +0100", "Message-Id": "<1411741159-6671-2-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com>", "References": "<1411741159-6671-1-git-send-email-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/2] pmd: Added rte_eth_rxconf_defaults and\n\trte_eth_txconf defaults functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Many sample apps use duplicated code to set rte_eth_txconf and rte_eth_rxconf\nstructures. This patch allows the user to get a default optimal RX/TX configuration\nthrough these two functions, and still any parameters may be tweaked as wished,\nbefore setting up queues.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n lib/librte_ether/rte_ethdev.c | 68 +++++++++++++++++++++++++++++++++++\n lib/librte_ether/rte_ethdev.h | 29 +++++++++++++++\n lib/librte_pmd_e1000/igb_ethdev.c | 56 ++++++++++++++++++++++++++++-\n lib/librte_pmd_i40e/i40e_ethdev.c | 56 ++++++++++++++++++++++++++++\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 59 ++++++++++++++++++++++++++++++\n 5 files changed, 267 insertions(+), 1 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex fd1010a..3c24040 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -928,6 +928,7 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t rx_queue_id,\n \tstruct rte_eth_dev *dev;\n \tstruct rte_pktmbuf_pool_private *mbp_priv;\n \tstruct rte_eth_dev_info dev_info;\n+\tconst struct rte_eth_rxconf *conf;\n \n \t/* This function is only safe when called from the primary process\n \t * in a multi-process setup*/\n@@ -937,6 +938,16 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t rx_queue_id,\n \t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n \t\treturn (-EINVAL);\n \t}\n+\n+\tconf = rx_conf;\n+\tif (conf == NULL) {\n+\t\tconf = rte_eth_rxconf_defaults(port_id, NULL);\n+\t\tif (conf == NULL) {\n+\t\t\tPMD_DEBUG_TRACE(\"Invalid RX port configuration\\n\");\n+\t\t\treturn (-EINVAL);\n+\t\t}\n+\t}\n+\n \tdev = &rte_eth_devices[port_id];\n \tif (rx_queue_id >= dev->data->nb_rx_queues) {\n \t\tPMD_DEBUG_TRACE(\"Invalid RX queue_id=%d\\n\", rx_queue_id);\n@@ -997,6 +1008,7 @@ rte_eth_tx_queue_setup(uint8_t port_id, uint16_t tx_queue_id,\n \t\t const struct rte_eth_txconf *tx_conf)\n {\n \tstruct rte_eth_dev *dev;\n+\tconst struct rte_eth_txconf *conf;\n \n \t/* This function is only safe when called from the primary process\n \t * in a multi-process setup*/\n@@ -1006,6 +1018,16 @@ rte_eth_tx_queue_setup(uint8_t port_id, uint16_t tx_queue_id,\n \t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n \t\treturn (-EINVAL);\n \t}\n+\n+\tconf = tx_conf;\n+\tif (conf == NULL) {\n+\t\tconf = rte_eth_txconf_defaults(port_id, NULL);\n+\t\tif (conf == NULL) {\n+\t\t\tPMD_DEBUG_TRACE(\"Invalid TX port configuration\\n\");\n+\t\t\treturn (-EINVAL);\n+\t\t}\n+\t}\n+\n \tdev = &rte_eth_devices[port_id];\n \tif (tx_queue_id >= dev->data->nb_tx_queues) {\n \t\tPMD_DEBUG_TRACE(\"Invalid TX queue_id=%d\\n\", tx_queue_id);\n@@ -3002,3 +3024,49 @@ rte_eth_dev_get_flex_filter(uint8_t port_id, uint16_t index,\n \treturn (*dev->dev_ops->get_flex_filter)(dev, index, filter,\n \t\t\t\t\t\trx_queue);\n }\n+\n+const struct rte_eth_rxconf *\n+rte_eth_rxconf_defaults(uint8_t port_id, struct rte_eth_rxconf *conf)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tstatic const struct rte_eth_rxconf defaults;\n+\n+\tif (port_id >= nb_ports) {\n+\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n+\t\treturn NULL;\n+\t}\n+\n+\tdev = &rte_eth_devices[port_id];\n+\n+\tif (dev->dev_ops->rxconf_defaults) {\n+\t\treturn (*dev->dev_ops->rxconf_defaults)(conf);\n+\t} else {\n+\t\tif (conf == NULL)\n+\t\t\treturn &defaults;\n+\t\t*conf = defaults;\n+\t}\n+\treturn conf;\n+}\n+\n+const struct rte_eth_txconf *\n+rte_eth_txconf_defaults(uint8_t port_id, struct rte_eth_txconf *conf)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tstatic const struct rte_eth_txconf defaults;\n+\n+\tif (port_id >= nb_ports) {\n+\t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n+\t\treturn NULL;\n+\t}\n+\n+\tdev = &rte_eth_devices[port_id];\n+\n+\tif (dev->dev_ops->txconf_defaults) {\n+\t\treturn (*dev->dev_ops->txconf_defaults)(conf);\n+\t} else {\n+\t\tif (conf == NULL)\n+\t\t\treturn &defaults;\n+\t\t*conf = defaults;\n+\t}\n+\treturn conf;\n+}\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 50df654..70026fd 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1361,6 +1361,12 @@ typedef int (*eth_get_flex_filter_t)(struct rte_eth_dev *dev,\n \t\t\tuint16_t *rx_queue);\n /**< @internal Get a flex filter rule on an Ethernet device */\n \n+typedef const struct rte_eth_rxconf * (*eth_rxconf_defaults_t) (struct rte_eth_rxconf *conf);\n+/**< @internal Get the default RX port configuration on an Ethernet device */\n+\n+typedef const struct rte_eth_txconf * (*eth_txconf_defaults_t) (struct rte_eth_txconf *conf);\n+/**< @internal Get the default TX port configuration on an Ethernet device */\n+\n /**\n * @internal A structure containing the functions exported by an Ethernet driver.\n */\n@@ -1467,6 +1473,8 @@ struct eth_dev_ops {\n \teth_add_flex_filter_t add_flex_filter; /**< add flex filter. */\n \teth_remove_flex_filter_t remove_flex_filter; /**< remove flex filter. */\n \teth_get_flex_filter_t get_flex_filter; /**< get flex filter. */\n+\teth_rxconf_defaults_t rxconf_defaults; /**< get default RX configuration. */\n+\teth_txconf_defaults_t txconf_defaults; /**< get default TX configuration. */\n };\n \n /**\n@@ -3557,6 +3565,27 @@ int rte_eth_dev_remove_flex_filter(uint8_t port_id, uint16_t index);\n int rte_eth_dev_get_flex_filter(uint8_t port_id, uint16_t index,\n \t\t\tstruct rte_flex_filter *filter, uint16_t *rx_queue);\n \n+/**\n+ * Get default port configuration.\n+ * @param port_id\n+ * The port identifier of the Ethernet device.\n+ * @param port_conf_default\n+ * Pointer to get the struct rte_eth_conf\n+ * @param rx_conf_default\n+ * Pointer to get the struct rte_eth_rxconf\n+ * @param tx_conf_default:\n+ * Pointer to get the struct rte_eth_txconf\n+ * @param burst_size\n+ * Pointer to get the default burst size\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENODEV) if *port_id* invalid.\n+ */\n+const struct rte_eth_rxconf *rte_eth_rxconf_defaults(uint8_t port_id,\n+\t\t\tstruct rte_eth_rxconf *conf);\n+\n+const struct rte_eth_txconf *rte_eth_txconf_defaults(uint8_t port_id,\n+\t\t\tstruct rte_eth_txconf *conf);\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c\nindex 3187d92..30f1ee3 100644\n--- a/lib/librte_pmd_e1000/igb_ethdev.c\n+++ b/lib/librte_pmd_e1000/igb_ethdev.c\n@@ -57,6 +57,18 @@\n #include \"e1000/e1000_api.h\"\n #include \"e1000_ethdev.h\"\n \n+/**\n+ * Default values for port configuration\n+ */\n+#define IGB_DEFAULT_RX_FREE_THRESH 32\n+#define IGB_DEFAULT_RX_PTHRESH 8\n+#define IGB_DEFAULT_RX_HTHRESH 8\n+#define IGB_DEFAULT_RX_WTHRESH 0\n+\n+#define IGB_DEFAULT_TX_PTHRESH 32\n+#define IGB_DEFAULT_TX_HTHRESH 0\n+#define IGB_DEFAULT_TX_WTHRESH 0\n+\n static int eth_igb_configure(struct rte_eth_dev *dev);\n static int eth_igb_start(struct rte_eth_dev *dev);\n static void eth_igb_stop(struct rte_eth_dev *dev);\n@@ -165,7 +177,8 @@ static int eth_igb_remove_5tuple_filter(struct rte_eth_dev *dev,\n static int eth_igb_get_5tuple_filter(struct rte_eth_dev *dev,\n \t\t\tuint16_t index,\n \t\t\tstruct rte_5tuple_filter *filter, uint16_t *rx_queue);\n-\n+static const struct rte_eth_rxconf *eth_igb_rxconf_defaults(struct rte_eth_rxconf *conf);\n+static const struct rte_eth_txconf *eth_igb_txconf_defaults(struct rte_eth_txconf *conf);\n /*\n * Define VF Stats MACRO for Non \"cleared on read\" register\n */\n@@ -255,6 +268,8 @@ static struct eth_dev_ops eth_igb_ops = {\n \t.add_5tuple_filter = eth_igb_add_5tuple_filter,\n \t.remove_5tuple_filter = eth_igb_remove_5tuple_filter,\n \t.get_5tuple_filter = eth_igb_get_5tuple_filter,\n+\t.rxconf_defaults = eth_igb_rxconf_defaults,\n+\t.txconf_defaults = eth_igb_txconf_defaults,\n };\n \n /*\n@@ -3008,6 +3023,45 @@ eth_igb_get_5tuple_filter(struct rte_eth_dev *dev, uint16_t index,\n \treturn -ENOENT;\n }\n \n+static const struct rte_eth_rxconf *\n+eth_igb_rxconf_defaults(struct rte_eth_rxconf *conf)\n+{\n+\tstatic const struct rte_eth_rxconf defaults = {\n+\t\t.rx_thresh = {\n+\t\t\t.pthresh = IGB_DEFAULT_RX_PTHRESH,\n+\t\t\t.hthresh = IGB_DEFAULT_RX_HTHRESH,\n+\t\t\t.wthresh = IGB_DEFAULT_RX_WTHRESH,\n+\t\t},\n+\t\t.rx_free_thresh = IGB_DEFAULT_RX_FREE_THRESH,\n+\t\t.rx_drop_en = 0,\n+\t};\n+\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\n+\n+static const struct rte_eth_txconf *\n+eth_igb_txconf_defaults(struct rte_eth_txconf *conf)\n+{\n+\tstatic const struct rte_eth_txconf defaults = {\n+\t\t.tx_thresh = {\n+\t\t\t.pthresh = IGB_DEFAULT_TX_PTHRESH,\n+\t\t\t.hthresh = IGB_DEFAULT_TX_HTHRESH,\n+\t\t\t.wthresh = IGB_DEFAULT_TX_WTHRESH,\n+\t\t},\n+\t\t.txq_flags = 0,\n+\t};\n+\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\n+\n static int\n eth_igb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n {\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 9ed31b5..b89b896 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -58,6 +58,17 @@\n #include \"i40e_rxtx.h\"\n #include \"i40e_pf.h\"\n \n+#define I40E_DEFAULT_RX_FREE_THRESH 32\n+#define I40E_DEFAULT_RX_PTHRESH 8\n+#define I40E_DEFAULT_RX_HTHRESH 8\n+#define I40E_DEFAULT_RX_WTHRESH 0\n+\n+#define I40E_DEFAULT_TX_FREE_THRESH 32\n+#define I40E_DEFAULT_TX_PTHRESH 32\n+#define I40E_DEFAULT_TX_HTHRESH 0\n+#define I40E_DEFAULT_TX_WTHRESH 0\n+#define I40E_DEFAULT_TX_RSBIT_THRESH 32\n+\n /* Maximun number of MAC addresses */\n #define I40E_NUM_MACADDR_MAX 64\n #define I40E_CLEAR_PXE_WAIT_MS 200\n@@ -203,6 +214,8 @@ static int i40e_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf);\n static int i40e_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf);\n+static const struct rte_eth_rxconf *i40e_rxconf_defaults(struct rte_eth_rxconf *conf);\n+static const struct rte_eth_txconf *i40e_txconf_defaults(struct rte_eth_txconf *conf);\n \n /* Default hash key buffer for RSS */\n static uint32_t rss_key_default[I40E_PFQF_HKEY_MAX_INDEX + 1];\n@@ -248,6 +261,8 @@ static struct eth_dev_ops i40e_eth_dev_ops = {\n \t.reta_query = i40e_dev_rss_reta_query,\n \t.rss_hash_update = i40e_dev_rss_hash_update,\n \t.rss_hash_conf_get = i40e_dev_rss_hash_conf_get,\n+\t.rxconf_defaults = i40e_rxconf_defaults,\n+\t.txconf_defaults = i40e_txconf_defaults,\n };\n \n static struct eth_driver rte_i40e_pmd = {\n@@ -3956,3 +3971,44 @@ i40e_pf_config_mq_rx(struct i40e_pf *pf)\n \n \treturn 0;\n }\n+\n+static const struct rte_eth_rxconf *\n+i40e_rxconf_defaults(struct rte_eth_rxconf *conf)\n+{\n+\tstatic const struct rte_eth_rxconf defaults = {\n+\t\t.rx_thresh = {\n+\t\t\t.pthresh = I40E_DEFAULT_RX_PTHRESH,\n+\t\t\t.hthresh = I40E_DEFAULT_RX_HTHRESH,\n+\t\t\t.wthresh = I40E_DEFAULT_RX_WTHRESH,\n+\t\t},\n+\t\t.rx_free_thresh = I40E_DEFAULT_RX_FREE_THRESH,\n+\t\t.rx_drop_en = 0,\n+\t};\n+\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\n+\n+static const struct rte_eth_txconf *\n+i40e_txconf_defaults(struct rte_eth_txconf *conf)\n+{\n+\tstatic const struct rte_eth_txconf defaults = {\n+\t\t.tx_thresh = {\n+\t\t\t.pthresh = I40E_DEFAULT_TX_PTHRESH,\n+\t\t\t.hthresh = I40E_DEFAULT_TX_HTHRESH,\n+\t\t\t.wthresh = I40E_DEFAULT_TX_WTHRESH,\n+\t\t},\n+\t\t.tx_free_thresh = I40E_DEFAULT_TX_FREE_THRESH,\n+\t\t.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,\n+\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS,\n+\t};\n+\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\ndiff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex 59122a1..7f61d00 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -92,6 +92,20 @@\n #define IXGBE_MMW_SIZE_DEFAULT 0x4\n #define IXGBE_MMW_SIZE_JUMBO_FRAME 0x14\n \n+/**\n+ * Default values for RX/TX configuration\n+ */\n+#define IXGBE_DEFAULT_RX_FREE_THRESH 32\n+#define IXGBE_DEFAULT_RX_PTHRESH 8\n+#define IXGBE_DEFAULT_RX_HTHRESH 8\n+#define IXGBE_DEFAULT_RX_WTHRESH 0\n+\n+#define IXGBE_DEFAULT_TX_FREE_THRESH 32\n+#define IXGBE_DEFAULT_TX_PTHRESH 32\n+#define IXGBE_DEFAULT_TX_HTHRESH 0\n+#define IXGBE_DEFAULT_TX_WTHRESH 0\n+#define IXGBE_DEFAULT_TX_RSBIT_THRESH 32\n+\n #define IXGBEVF_PMD_NAME \"rte_ixgbevf_pmd\" /* PMD name */\n \n #define IXGBE_QUEUE_STAT_COUNTERS (sizeof(hw_stats->qprc) / sizeof(hw_stats->qprc[0]))\n@@ -219,6 +233,8 @@ static int ixgbe_remove_5tuple_filter(struct rte_eth_dev *dev,\n \t\t\tuint16_t index);\n static int ixgbe_get_5tuple_filter(struct rte_eth_dev *dev, uint16_t index,\n \t\t\tstruct rte_5tuple_filter *filter, uint16_t *rx_queue);\n+static const struct rte_eth_rxconf *ixgbe_rxconf_defaults(struct rte_eth_rxconf *conf);\n+static const struct rte_eth_txconf *ixgbe_txconf_defaults(struct rte_eth_txconf *conf);\n \n static int ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu);\n \n@@ -362,6 +378,8 @@ static struct eth_dev_ops ixgbe_eth_dev_ops = {\n \t.add_5tuple_filter = ixgbe_add_5tuple_filter,\n \t.remove_5tuple_filter = ixgbe_remove_5tuple_filter,\n \t.get_5tuple_filter = ixgbe_get_5tuple_filter,\n+\t.rxconf_defaults = ixgbe_rxconf_defaults,\n+\t.txconf_defaults = ixgbe_txconf_defaults,\n };\n \n /*\n@@ -388,6 +406,8 @@ static struct eth_dev_ops ixgbevf_eth_dev_ops = {\n \t.tx_queue_release = ixgbe_dev_tx_queue_release,\n \t.mac_addr_add = ixgbevf_add_mac_addr,\n \t.mac_addr_remove = ixgbevf_remove_mac_addr,\n+\t.rxconf_defaults = ixgbe_rxconf_defaults,\n+\t.txconf_defaults = ixgbe_txconf_defaults,\n };\n \n /**\n@@ -3940,6 +3960,45 @@ ixgbe_get_5tuple_filter(struct rte_eth_dev *dev, uint16_t index,\n \treturn -ENOENT;\n }\n \n+const struct rte_eth_rxconf *\n+ixgbe_rxconf_defaults(struct rte_eth_rxconf *conf)\n+{\n+\tstatic const struct rte_eth_rxconf defaults = {\n+\t\t\t.rx_thresh = {\n+\t\t\t\t.pthresh = IXGBE_DEFAULT_RX_PTHRESH,\n+\t\t\t\t.hthresh = IXGBE_DEFAULT_RX_HTHRESH,\n+\t\t\t\t.wthresh = IXGBE_DEFAULT_RX_WTHRESH,\n+\t\t\t},\n+\t\t\t.rx_free_thresh = IXGBE_DEFAULT_RX_FREE_THRESH,\n+\t\t\t.rx_drop_en = 0,\n+\t};\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\n+\n+const struct rte_eth_txconf *\n+ixgbe_txconf_defaults(struct rte_eth_txconf *conf)\n+{\n+\tstatic const struct rte_eth_txconf defaults = {\n+\t\t\t.tx_thresh = {\n+\t\t\t\t.pthresh = IXGBE_DEFAULT_TX_PTHRESH,\n+\t\t\t\t.hthresh = IXGBE_DEFAULT_TX_HTHRESH,\n+\t\t\t\t.wthresh = IXGBE_DEFAULT_TX_WTHRESH,\n+\t\t\t},\n+\t\t\t.tx_free_thresh = IXGBE_DEFAULT_TX_FREE_THRESH,\n+\t\t\t.tx_rs_thresh = IXGBE_DEFAULT_TX_RSBIT_THRESH,\n+\t\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS,\n+\t};\n+\tif (conf == NULL)\n+\t\treturn &defaults;\n+\t*conf = defaults;\n+\n+\treturn conf;\n+}\n+\n static int\n ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n {\n", "prefixes": [ "dpdk-dev", "1/2" ] }