Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58035/?format=api
{ "id": 58035, "url": "https://patches.dpdk.org/api/patches/58035/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com", "date": "2019-08-27T19:30:16", "name": "[1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail.", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "c99d649c9566ba2bd7de5a4b2902c51a3045b6c6", "submitter": { "id": 976, "url": "https://patches.dpdk.org/api/people/976/?format=api", "name": "Nitin Katiyar", "email": "nitin.katiyar@ericsson.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com/mbox/", "series": [ { "id": 6136, "url": "https://patches.dpdk.org/api/series/6136/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6136", "date": "2019-08-27T19:30:16", "name": "[1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail.", "version": 1, "mbox": "https://patches.dpdk.org/series/6136/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/58035/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/58035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 791341BF7B;\n\tTue, 27 Aug 2019 13:30:09 +0200 (CEST)", "from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45])\n\tby dpdk.org (Postfix) with ESMTP id D2F5E1BF77\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 13:30:07 +0200 (CEST)", "from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114])\n\tby sessmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\t62.0A.03329.F34156D5; Tue, 27 Aug 2019 13:30:07 +0200 (CEST)", "from ESESBMB501.ericsson.se (153.88.183.168) by\n\tESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1713.5; Tue, 27 Aug 2019 13:30:06 +0200", "from ESESSHC002.ericsson.se (153.88.183.24) by\n\tESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server\n\t(version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id\n\t15.1.1713.5 via Frontend Transport; Tue, 27 Aug 2019 13:30:06 +0200", "from ESGSCHC006.ericsson.se (146.11.116.83) by\n\tESESSHC002.ericsson.se (153.88.183.24) with Microsoft SMTP Server\n\t(TLS) id 14.3.439.0; Tue, 27 Aug 2019 13:30:06 +0200", "from localhost.localdomain (146.11.116.127) by\n\tsmtps-ao.internal.ericsson.com (146.11.116.83) with Microsoft SMTP\n\tServer (TLS) id 14.3.439.0; Tue, 27 Aug 2019 19:29:43 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801;\n\tc=relaxed/relaxed; \n\tq=dns/txt; i=@ericsson.com; t=1566905407; x=1569497407;\n\th=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=xMOq8cIJ8wN2oTBY2NCOhaxFNO9Y1gIDSw0glj3sMRs=;\n\tb=M6sS2wc/Iyoil6QuN4kNOJJoH5ItG6QWqIb/ef5Y5zgG6lKKWA0B7WeAXGvmaife\n\t0vDIU/7R6eK1YyiMjMv4itrYgcp1OX/ymABpugUIXPtJuB72bmxR5WYAWktRHU3C\n\tRtVTbY/MVDX1aae6OTK3h6DDMgIf8vgzBYWn4jAggM0=;", "X-AuditID": "c1b4fb2d-175ff70000000d01-f5-5d65143f9286", "From": "Nitin Katiyar <nitin.katiyar@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "Nitin Katiyar <nitin.katiyar@ericsson.com>, Venkatesan Pradeep\n\t<venkatesan.pradeep@ericsson.com>", "Date": "Wed, 28 Aug 2019 01:00:16 +0530", "Message-ID": "<1566934217-23824-1-git-send-email-nitin.katiyar@ericsson.com>", "X-Mailer": "git-send-email 1.9.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[146.11.116.127]", "Subject": "[dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all\n\twhitelisted devices fail.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Even if whitelist of devices is provided, rte_pci_probe() increments\nthe probed counter for all the devices present in the system. If probe\nfails for all the whitelisted devices it still return success because\nfailed and probed counts don't match.\n\nThis patch increments probed count only when devices are actually\nprobed.\n\nSigned-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>\nSigned-off-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com>\n\n---\n drivers/bus/pci/pci_common.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 6b46b4f..25d1002 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -300,15 +300,17 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)\n \t\tprobe_all = 1;\n \n \tFOREACH_DEVICE_ON_PCIBUS(dev) {\n-\t\tprobed++;\n-\n \t\tdevargs = dev->device.devargs;\n \t\t/* probe all or only whitelisted devices */\n-\t\tif (probe_all)\n+\t\tif (probe_all) {\n \t\t\tret = pci_probe_all_drivers(dev);\n+\t\t\tprobed++;\n+\t\t}\n \t\telse if (devargs != NULL &&\n-\t\t\tdevargs->policy == RTE_DEV_WHITELISTED)\n+\t\t\tdevargs->policy == RTE_DEV_WHITELISTED) {\n \t\t\tret = pci_probe_all_drivers(dev);\n+\t\t\tprobed++;\n+\t\t}\n \t\tif (ret < 0) {\n \t\t\tif (ret != -EEXIST) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Requested device \"\n", "prefixes": [ "1/2" ] }