Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57812/?format=api
{ "id": 57812, "url": "https://patches.dpdk.org/api/patches/57812/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1566455136-8496-1-git-send-email-abhishek.sachan@altran.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566455136-8496-1-git-send-email-abhishek.sachan@altran.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566455136-8496-1-git-send-email-abhishek.sachan@altran.com", "date": "2019-08-22T06:25:36", "name": "net/af_packet: fix for stale sockets", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "147fb66063a877d21ad8ff882afaa2a193e3d19e", "submitter": { "id": 1396, "url": "https://patches.dpdk.org/api/people/1396/?format=api", "name": "Abhishek Sachan", "email": "abhishek.sachan@altran.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1566455136-8496-1-git-send-email-abhishek.sachan@altran.com/mbox/", "series": [ { "id": 6101, "url": "https://patches.dpdk.org/api/series/6101/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6101", "date": "2019-08-22T06:25:36", "name": "net/af_packet: fix for stale sockets", "version": 1, "mbox": "https://patches.dpdk.org/series/6101/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57812/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 34D171BF6F;\n\tThu, 22 Aug 2019 08:29:19 +0200 (CEST)", "from mx07-001f8a01.pphosted.com (mx07-001f8a01.pphosted.com\n\t[62.209.51.162]) by dpdk.org (Postfix) with ESMTP id 60D701BF48;\n\tThu, 22 Aug 2019 08:29:18 +0200 (CEST)", "from pps.filterd (m0162091.ppops.net [127.0.0.1])\n\tby mx07-001f8a01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx7M6TIJH013173; Thu, 22 Aug 2019 08:29:18 +0200", "from ind01-bo1-obe.outbound.protection.outlook.com\n\t(mail-bo1ind01lp2054.outbound.protection.outlook.com [104.47.101.54])\n\tby mx07-001f8a01.pphosted.com with ESMTP id 2uh8fksegf-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tThu, 22 Aug 2019 08:29:17 +0200", "from MAXPR0101CA0072.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:a00:e::34)\n\tby MAXPR01MB2943.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:54::18)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16;\n\tThu, 22 Aug 2019 06:28:50 +0000", "from HK2APC01FT027.eop-APC01.prod.protection.outlook.com\n\t(2a01:111:f400:7ebc::202) by MAXPR0101CA0072.outlook.office365.com\n\t(2603:1096:a00:e::34) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16 via\n\tFrontend Transport; Thu, 22 Aug 2019 06:28:49 +0000", "from GURHYBRID01.AD.ARICENT.COM (121.241.96.4) by\n\tHK2APC01FT027.mail.protection.outlook.com (10.152.248.179) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n\t15.20.2199.13 via Frontend Transport; Thu, 22 Aug 2019 06:28:49 +0000", "from GURHYBRID02.AD.ARICENT.COM (10.203.26.140) by\n\tGURHYBRID02.AD.ARICENT.COM (10.203.26.140) with Microsoft SMTP Server\n\t(TLS) id 15.0.1367.3; Thu, 22 Aug 2019 11:56:56 +0530", "from gurux105.gur.aricent.com (10.203.159.187) by\n\tGURHYBRID02.AD.ARICENT.COM (10.203.26.100) with Microsoft SMTP Server\n\t(TLS)\n\tid 15.0.1367.3 via Frontend Transport; Thu, 22 Aug 2019 11:56:56 +0530", "from gurux118.gur.aricent.com ([10.203.158.20])\n\tby gurux105.gur.aricent.com (8.14.4/8.14.4) with ESMTP id\n\tx7M6QuCF015638; Thu, 22 Aug 2019 11:56:56 +0530", "from localhost.localdomain ([172.19.57.242])\n\tby gurux118.gur.aricent.com (8.14.4/8.13.8) with ESMTP id\n\tx7M6QAEa008867; Thu, 22 Aug 2019 11:56:41 +0530" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=EcwIkf/g1B/3zTDUiC8fYQpyYsJabHnm5a2z3Xuve9UBCSJeoe9BaAHXz9zBaAkjAqOLG7Wh8wKIR7RhcdM6+mmkfXk6m0KPnBYFNHMGvmLTM6/2YGRUx8RApAM2UNQvsTk8RJ+VDuN4BMARYrx3RcHHrcT6pB38P7k9rY2B0cf4Y4j4LkoTDMKe3lvqakddtrWoiGCmlxZS8h8W7AXLYABDHi8mpBji2LU3+6IMTH2cw1q8ZPnlzLtmm5NrEaVYl0EA+EjvzHUoSN6YibxUE27I5WpAOcGiJxHp3uZ2EjCE+Dro8IdBohXCW/JYRLK3eFUh/++JzkZQ9w9xklc+KA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=evmzIUCsSGxpOeBwfxgO//mpFOlLx4bom0gcUaq/5sk=;\n\tb=ZsXZ5iM1FS4gSqlGDy97DPCNGOdePOcjEtTnCjwnO95xZsAdIbUF7UxvI2u/HiWfBdYcoe76NTcNs+iw79dj7FiOUm+zYGrP+jeuSgwI6d8mEfw2IkRikziXquhkXD7oDxl+TuBG+YHI7zc0uJdSGn1Qgwq0JYxxqByI2CsDr1C5RTYbB6FRmhO+H7IqW5gWga5N+ao0tm/pGpre0008dB4lq9WNbRt/Aco5kD1b7GpEbq9GgB+8vnzoy+mINOCwH2pB2N4bkcQb5BSrdf868VMdFwCUfVkDYKIaA2OIOH6PS32RtUTRWUopB/yTr0K3q5LwU6xXQ4lB6+yzKnap9g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=softfail (sender ip\n\tis 121.241.96.4) smtp.rcpttodomain=dpdk.org\n\tsmtp.mailfrom=aricent.com; \n\tdmarc=fail (p=none sp=none pct=100) action=none\n\theader.from=altran.com; \n\tdkim=none (message not signed); arc=none", "Received-SPF": "SoftFail (protection.outlook.com: domain of transitioning\n\taricent.com discourages use of 121.241.96.4 as permitted sender)", "From": "Abhishek Sachan <abhishek.sachan@altran.com>", "To": "<linville@tuxdriver.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Date": "Thu, 22 Aug 2019 11:55:36 +0530", "Message-ID": "<1566455136-8496-1-git-send-email-abhishek.sachan@altran.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-Office365-Filtering-HT": "Tenant", "X-Forefront-Antispam-Report": "CIP:121.241.96.4; IPV:CAL; SCL:-1; CTRY:IN;\n\tEFV:NLI; SFV:NSPM;\n\tSFS:(10009020)(346002)(136003)(39860400002)(376002)(396003)(2980300002)(199004)(189003)(44832011)(54906003)(16586007)(2906002)(316002)(8676002)(2616005)(305945005)(8936002)(476003)(50226002)(486006)(51416003)(81156014)(26005)(478600001)(48376002)(50466002)(4326008)(47776003)(5660300002)(126002)(36756003)(42882007)(81166006)(336012)(2351001)(49486002)(6666004)(356004)(76130400001)(186003)(26826003)(70206006)(70586007)(6916009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MAXPR01MB2943;\n\tH:GURHYBRID01.AD.ARICENT.COM; \n\tFPR:; SPF:SoftFail; LANG:en; PTR:121.241.96.4.static-delhi.vsnl.net.in;\n\tA:1; MX:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "f0388b16-803a-45a2-e735-08d726c9fe52", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328);\n\tSRVR:MAXPR01MB2943; ", "X-MS-TrafficTypeDiagnostic": "MAXPR01MB2943:", "X-Microsoft-Antispam-PRVS": "<MAXPR01MB294357B00B43ECFCE9979F4EFCA50@MAXPR01MB2943.INDPRD01.PROD.OUTLOOK.COM>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:170;", "X-Forefront-PRVS": "01371B902F", "X-MS-Exchange-SenderADCheck": "2", "X-Microsoft-Antispam-Message-Info": "yMfn8tBHa4X6NYAbmcNizNpoxuQssYkmTZ/jl5GiGtH3qeW4VTPDVuj1oV3dAZ60wT5VmX+pcLClyilZWDXBw+GixFiEcZY0K1CRcjYgfhathyu+P4Bvcans+J6lxqyYa8wgbEX93Sc4GF4KeqRmw808pff0J8uuBee411X4d4n08K1zWlsForll/v0s3LAaguiiyWS5WXTMWOOWkOaJZI3CbdAXHjDEAyYtAlRWpFbZnmFvs6a2iZSR09Dzuhg8TWaPddRYq1af6YVRtrNP6DVizW/bivwbTyzyocbGfqyW01acUJFEEuupLm1wnGap9oZublRHaUCK2vKj94zmHH008hJ17XKe/smcd34pKSiMPQVIVCx9UeNKGavgAPKHL2goGhinxNcHVkjIL3VlH5djAMmiFQfmjDwegAfuKgE=", "X-OriginatorOrg": "Aricent.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Aug 2019 06:28:49.0610\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "f0388b16-803a-45a2-e735-08d726c9fe52", "X-MS-Exchange-CrossTenant-Id": "dbb4cbbe-57c5-469d-b342-a9814e1d2382", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=dbb4cbbe-57c5-469d-b342-a9814e1d2382;\n\tIp=[121.241.96.4]; \n\tHelo=[GURHYBRID01.AD.ARICENT.COM]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MAXPR01MB2943", "X-Proofpoint-Spam-Details": "rule=outgoing_spam_policy_notspam\n\tpolicy=outgoing_spam_policy score=0\n\tpriorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0\n\timpostorscore=0\n\tmlxlogscore=941 adultscore=0 classifier=spam adjust=0 reason=mlx\n\tscancount=1 engine=8.0.1-1906280000 definitions=main-1908220070", "Subject": "[dpdk-dev] [PATCH] net/af_packet: fix for stale sockets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "af_packet driver is leaving stale socket after device is removed.\nRing buffers are memory mapped when device is added using rte_dev_probe.\nThere is no corresponding munmap call when device is removed/closed.\nThis commit fixes the issue by calling munmap\nfrom rte_pmd_af_packet_remove().\n\nBugzilla ID: 339\nCc: stable@dpdk.org\n\nSigned-off-by: Abhishek Sachan <abhishek.sachan@altran.com>\nReviewed-by: John W. Linville <linville@redhat.com>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 82bf2cd..6df09f2 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -972,6 +972,7 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)\n {\n \tstruct rte_eth_dev *eth_dev = NULL;\n \tstruct pmd_internals *internals;\n+\tstruct tpacket_req *req;\n \tunsigned q;\n \n \tPMD_LOG(INFO, \"Closing AF_PACKET ethdev on numa socket %u\",\n@@ -992,7 +993,10 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev)\n \t\treturn rte_eth_dev_release_port(eth_dev);\n \n \tinternals = eth_dev->data->dev_private;\n+\treq = &internals->req;\n \tfor (q = 0; q < internals->nb_queues; q++) {\n+\t\tmunmap(internals->rx_queue[q].map,\n+\t\t\t2 * req->tp_block_size * req->tp_block_nr);\n \t\trte_free(internals->rx_queue[q].rd);\n \t\trte_free(internals->tx_queue[q].rd);\n \t}\n", "prefixes": [] }