Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57802/?format=api
{ "id": 57802, "url": "https://patches.dpdk.org/api/patches/57802/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190822055400.30119-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190822055400.30119-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190822055400.30119-12-ajit.khaparde@broadcom.com", "date": "2019-08-22T05:53:58", "name": "[11/13] net/bnxt: reschedule the health check alarm correctly", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c837c27b9552d33bfc33573b0c636d0324f5c054", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190822055400.30119-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6099, "url": "https://patches.dpdk.org/api/series/6099/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=6099", "date": "2019-08-22T05:53:47", "name": "bnxt patchset to support device error recovery", "version": 1, "mbox": "https://patches.dpdk.org/series/6099/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57802/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 438491BF6E;\n\tThu, 22 Aug 2019 07:54:33 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id C045A1BF34\n\tfor <dev@dpdk.org>; Thu, 22 Aug 2019 07:54:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id CFB3F30C20F;\n\tWed, 21 Aug 2019 22:54:05 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 6B0EDAC06AD;\n\tWed, 21 Aug 2019 22:54:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com CFB3F30C20F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1566453245;\n\tbh=dsERwK1FEFe4jy08G2CmXE/k3AusXZ/rh+CYb2RvkDw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vCclEll7TJhsOzhRC+pW68smls/C5Nxjx0rWUQodStTckdLZ9zwrAyldMWL3JKvo4\n\tIATw23aWwdQM9yXMZcRjdshUH8VEKQs2ttZ5AXfe9jkHvV7FRsnPaF1ya7JXuprYfl\n\tYh9X5ZzuD3570n/K5CFGJBXJ/V3rlI71ytEfOtPY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tSantoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Wed, 21 Aug 2019 22:53:58 -0700", "Message-Id": "<20190822055400.30119-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190822055400.30119-1-ajit.khaparde@broadcom.com>", "References": "<20190822055400.30119-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 11/13] net/bnxt: reschedule the health check\n\talarm correctly", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nWhen the driver receives the error recovery notify event from fw\nfor the first time, it has to read the heartbeat count register and\nrecovery count register and schedule the fw health check task for\nperiodically monitoring the fw health.\n\nFW may send this event at a later time when the state of master function\nchanges. There is no need to schedule the health check task this time.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_cpr.c | 3 +++\n drivers/net/bnxt/bnxt_ethdev.c | 2 ++\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 93aac15b4..edaef7897 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -422,6 +422,7 @@ struct bnxt {\n #define BNXT_FLAG_EXT_STATS_SUPPORTED\tBIT(19)\n #define BNXT_FLAG_NEW_RM\t\tBIT(20)\n #define BNXT_FLAG_INIT_DONE\t\tBIT(21)\n+#define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(22)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n #define BNXT_NPAR(bp)\t\t((bp)->port_partition_type)\ndiff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex a692fbe7c..50f93bd21 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -89,6 +89,9 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\t\t bnxt_is_recovery_enabled(bp),\n \t\t\t bnxt_is_master_func(bp));\n \n+\t\tif (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED)\n+\t\t\treturn;\n+\n \t\tinfo->last_heart_beat =\n \t\t\tbnxt_read_fw_status_reg(bp, BNXT_FW_HEARTBEAT_CNT_REG);\n \t\tinfo->last_reset_counter =\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 0317eb888..e7b0b44c4 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3687,6 +3687,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)\n \n \trte_eal_alarm_set(US_PER_MS * polling_freq,\n \t\t\t bnxt_check_fw_health, (void *)bp);\n+\tbp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;\n }\n \n static void bnxt_cancel_fw_health_check(struct bnxt *bp)\n@@ -3695,6 +3696,7 @@ static void bnxt_cancel_fw_health_check(struct bnxt *bp)\n \t\treturn;\n \n \trte_eal_alarm_cancel(bnxt_check_fw_health, (void *)bp);\n+\tbp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;\n }\n \n static bool bnxt_vf_pciid(uint16_t id)\n", "prefixes": [ "11/13" ] }