Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57446/?format=api
{ "id": 57446, "url": "https://patches.dpdk.org/api/patches/57446/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1565010234-21769-6-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1565010234-21769-6-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1565010234-21769-6-git-send-email-viacheslavo@mellanox.com", "date": "2019-08-05T13:03:53", "name": "[v2,5/6] net/mlx5: fix packet size inline settings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2bedf7e62a4ab912d2bf1c16cf56ac97b7aaeba3", "submitter": { "id": 1102, "url": "https://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1565010234-21769-6-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 5927, "url": "https://patches.dpdk.org/api/series/5927/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5927", "date": "2019-08-05T13:03:48", "name": "fix transmit datapath cumulative series", "version": 2, "mbox": "https://patches.dpdk.org/series/5927/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57446/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57446/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AD9F61BE05;\n\tMon, 5 Aug 2019 15:04:35 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id DAC981BE0F\n\tfor <dev@dpdk.org>; Mon, 5 Aug 2019 15:04:33 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 5 Aug 2019 16:04:32 +0300", "from pegasus12.mtr.labs.mlnx (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x75D4Wgu006657;\n\tMon, 5 Aug 2019 16:04:32 +0300", "from pegasus12.mtr.labs.mlnx (localhost [127.0.0.1])\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id\n\tx75D4WZ4022377; Mon, 5 Aug 2019 13:04:32 GMT", "(from viacheslavo@localhost)\n\tby pegasus12.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id x75D4WlX022376; \n\tMon, 5 Aug 2019 13:04:32 GMT" ], "X-Authentication-Warning": "pegasus12.mtr.labs.mlnx: viacheslavo set sender to\n\tviacheslavo@mellanox.com using -f", "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "yskoh@mellanox.com, matan@mellanox.com", "Date": "Mon, 5 Aug 2019 13:03:53 +0000", "Message-Id": "<1565010234-21769-6-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1565010234-21769-1-git-send-email-viacheslavo@mellanox.com>", "References": "<1565010234-21769-1-git-send-email-viacheslavo@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 5/6] net/mlx5: fix packet size inline settings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes the default settings for packet size to inline\nwith Enhanced Multi-Packet Write feature, allowing 256B packets\nto be inlined with Out-Of-the-Box settings.\n\nFixes: 50724e1bba76 (\"net/mlx5: update Tx definitions\")\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n doc/guides/nics/mlx5.rst | 2 +-\n drivers/net/mlx5/mlx5_prm.h | 5 ++---\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 46538b8..5102bcd 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -449,7 +449,7 @@ Run-time configuration\n and CPU resources are scarce), data inline is not performed by the driver.\n Assigning ``txqs_min_inline`` with zero always enables the data inline.\n \n- The default ``txq_inline_mpw`` value is 188. The specified value may be adjusted\n+ The default ``txq_inline_mpw`` value is 268. The specified value may be adjusted\n by the driver in order not to exceed the limit (930 bytes) and to provide better\n WQE space filling without gaps, the adjustment is reflected in the debug log.\n Due to multiple packets may be included to the same WQE with Enhanced Multi\ndiff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h\nindex 4ee6d89..d62837e 100644\n--- a/drivers/net/mlx5/mlx5_prm.h\n+++ b/drivers/net/mlx5/mlx5_prm.h\n@@ -72,9 +72,8 @@\n * boundary with accounting the title Control and Ethernet\n * segments.\n */\n-#define MLX5_EMPW_DEF_INLINE_LEN (3u * MLX5_WQE_SIZE + \\\n-\t\t\t\t MLX5_DSEG_MIN_INLINE_SIZE - \\\n-\t\t\t\t MLX5_WQE_DSEG_SIZE)\n+#define MLX5_EMPW_DEF_INLINE_LEN (4u * MLX5_WQE_SIZE + \\\n+\t\t\t\t MLX5_DSEG_MIN_INLINE_SIZE)\n /*\n * Maximal inline data length sent with enhanced MPW.\n * Is based on maximal WQE size.\n", "prefixes": [ "v2", "5/6" ] }